)]}'
{"keystone/federation/utils.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"2a7f7b9c006a6f54821d52859d097097212e1285","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            # If there are no direct mappings, then add the local mapping"},{"line_number":529,"context_line":"            # directly to the array of saved values. However, if there is"},{"line_number":530,"context_line":"            # a direct mapping, then perform variable replacement."},{"line_number":531,"context_line":"            if not direct_maps._matches:"},{"line_number":532,"context_line":"                identity_values +\u003d rule[\u0027local\u0027]"},{"line_number":533,"context_line":"            else:"},{"line_number":534,"context_line":"                for local in rule[\u0027local\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_328431b1","line":531,"range":{"start_line":531,"start_character":30,"end_line":531,"end_character":39},"updated":"2017-05-16 17:37:28.000000000","message":"isn\u0027t this checking for when direct_maps is not empty? I see L525 chcks for None already\n\nI am just not getting why checking in a private/internal attribute is buying us.\nwas the behavior wrong before this change? If so we need a bug report and tests","commit_id":"0267f36c67844a7c30a20c051698c1bc848ee7ab"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"13cf725fa93550e37ea76efb89fdbcf8fd913ba7","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            # If there are no direct mappings, then add the local mapping"},{"line_number":529,"context_line":"            # directly to the array of saved values. However, if there is"},{"line_number":530,"context_line":"            # a direct mapping, then perform variable replacement."},{"line_number":531,"context_line":"            if not direct_maps._matches:"},{"line_number":532,"context_line":"                identity_values +\u003d rule[\u0027local\u0027]"},{"line_number":533,"context_line":"            else:"},{"line_number":534,"context_line":"                for local in rule[\u0027local\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_26cab36c","line":531,"range":{"start_line":531,"start_character":30,"end_line":531,"end_character":39},"in_reply_to":"1f013ff3_328431b1","updated":"2017-05-16 19:57:27.000000000","message":"Interesting. I played a bit around and this seems to be a bug as `not direct_maps`  will never evaluate to True, since the actual list object is _matches.http://paste.openstack.org/show/609716/","commit_id":"0267f36c67844a7c30a20c051698c1bc848ee7ab"}]}