)]}'
{"api-ref/source/v3/domains-config-v3.inc":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4da51e13688f650b9fb7dfff60b39b3b9a34dbbb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"The default configuration settings for the options that can be overridden"},{"line_number":43,"context_line":"can be retrieved."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Relationship::"},{"line_number":46,"context_line":"``https://docs.openstack.org/api/openstack-identity/3/rel/domain_config_default``"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f231b9d_f17f1fa9","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":14},"updated":"2017-06-10 04:55:16.000000000","message":"Should this be just one :?  It seems to render \n\n   Relationship:: https://docs... \n\nif there are two.","commit_id":"f133a3ad79fc576dd39ad1b37322de80e5d120b2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"88b836edaaa8813ebbd57963129ee8bbe008a5a5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"The default configuration settings for the options that can be overridden"},{"line_number":43,"context_line":"can be retrieved."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Relationship::"},{"line_number":46,"context_line":"``https://docs.openstack.org/api/openstack-identity/3/rel/domain_config_default``"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f231b9d_517eace4","line":45,"in_reply_to":"7f231b9d_718f6823","updated":"2017-06-12 15:12:34.000000000","message":"Fixed in https://review.openstack.org/#/c/473496/","commit_id":"f133a3ad79fc576dd39ad1b37322de80e5d120b2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"56eec64e060d695296a891b42f0c9688984f6c66","unresolved":false,"context_lines":[{"line_number":42,"context_line":"The default configuration settings for the options that can be overridden"},{"line_number":43,"context_line":"can be retrieved."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Relationship::"},{"line_number":46,"context_line":"``https://docs.openstack.org/api/openstack-identity/3/rel/domain_config_default``"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f231b9d_718f6823","line":45,"in_reply_to":"7f231b9d_f17f1fa9","updated":"2017-06-12 15:08:44.000000000","message":"Yeah - that seemed to be an existing convention of these docs. I can either update the existing patch or pull this out into another change since it\u0027s out of scope.","commit_id":"f133a3ad79fc576dd39ad1b37322de80e5d120b2"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"65959cc5b9232744bf5bc2de079f20bcef3fe78e","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. rest_method:: HEAD /v3/domains/config/default"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The default configuration settings for the options that can be overridden"},{"line_number":72,"context_line":"can be retrieved."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Relationship::"},{"line_number":75,"context_line":"``https://docs.openstack.org/api/openstack-identity/3/rel/domain_config_default``"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f231b9d_6284345f","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":17},"updated":"2017-06-12 16:05:32.000000000","message":"While I agree that there should be a corresponding HEAD to every GET, documentation about it here seems unnecessary. As there is no use I can think of ever making this call, since it is not checking the existence of a resource or relationship. I would argue that the routers.py changes are enough and there is no need for changing the api-ref.","commit_id":"f133a3ad79fc576dd39ad1b37322de80e5d120b2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42a3e8538da700481997f63c5eb7d17bf847b13e","unresolved":false,"context_lines":[{"line_number":69,"context_line":".. rest_method:: HEAD /v3/domains/config/default"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The default configuration settings for the options that can be overridden"},{"line_number":72,"context_line":"can be retrieved."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Relationship::"},{"line_number":75,"context_line":"``https://docs.openstack.org/api/openstack-identity/3/rel/domain_config_default``"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f231b9d_3df54158","line":72,"in_reply_to":"7f231b9d_6284345f","updated":"2017-06-12 16:49:28.000000000","message":"Good point - we discussed this and came to an outcome in IRC: \n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2017-06-12.log.html#t2017-06-12T16:10:34","commit_id":"f133a3ad79fc576dd39ad1b37322de80e5d120b2"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4da51e13688f650b9fb7dfff60b39b3b9a34dbbb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"The default configuration settings for the options that can be overridden"},{"line_number":72,"context_line":"can be retrieved."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Relationship::"},{"line_number":75,"context_line":"``https://docs.openstack.org/api/openstack-identity/3/rel/domain_config_default``"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Show default configuration for a group"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f231b9d_b162c715","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":14},"updated":"2017-06-10 04:55:16.000000000","message":"Ditto","commit_id":"f133a3ad79fc576dd39ad1b37322de80e5d120b2"}],"keystone/tests/unit/test_v3_domain_config.py":[{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"9a29a5c4d40c47efcedbf9dc1d77a360a565749d","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.head("},{"line_number":599,"context_line":"            url,"},{"line_number":600,"context_line":"            token\u003dself._get_non_admin_token(),"},{"line_number":601,"context_line":"            expected_status\u003dhttp_client.OK"},{"line_number":602,"context_line":"        )"},{"line_number":603,"context_line":"        self.head("},{"line_number":604,"context_line":"            url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_c83e8628","line":601,"range":{"start_line":601,"start_character":12,"end_line":601,"end_character":42},"updated":"2017-06-12 18:53:00.000000000","message":"nit: factor these out so that its consistent with self.get calling expected_response as a variable","commit_id":"668d8cdb98facf0635200e8a5709dd92211e47b4"},{"author":{"_account_id":23659,"name":"Jaewoo Park","email":"jaewoopark91@gmail.com","username":"aselius"},"change_message_id":"9f58f55bd7e711c308845404992a360c622de487","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.head("},{"line_number":599,"context_line":"            url,"},{"line_number":600,"context_line":"            token\u003dself._get_non_admin_token(),"},{"line_number":601,"context_line":"            expected_status\u003dhttp_client.OK"},{"line_number":602,"context_line":"        )"},{"line_number":603,"context_line":"        self.head("},{"line_number":604,"context_line":"            url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_7c1b8d80","line":601,"in_reply_to":"7f231b9d_16d598b9","updated":"2017-06-13 20:13:58.000000000","message":"Sorry for the late reply. Kristi covered what I was trying to say. But yeah since the rest are bedded inside the self.get/self.head I think its fine the way it is.","commit_id":"668d8cdb98facf0635200e8a5709dd92211e47b4"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"bc5316cd573a5131be81f8d3364a87c5de1fde0a","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.head("},{"line_number":599,"context_line":"            url,"},{"line_number":600,"context_line":"            token\u003dself._get_non_admin_token(),"},{"line_number":601,"context_line":"            expected_status\u003dhttp_client.OK"},{"line_number":602,"context_line":"        )"},{"line_number":603,"context_line":"        self.head("},{"line_number":604,"context_line":"            url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_16d598b9","line":601,"in_reply_to":"7f231b9d_342e7343","updated":"2017-06-13 19:21:39.000000000","message":"I think he means doing it in two separate lines. Similar to 592-595. r \u003d self.get(); self.assertEqual(). I\u0027m okay with the way it is now. It\u0027s also mostly consistent with the way self.get also has an expected status parameter when we don\u0027t care about the response body.","commit_id":"668d8cdb98facf0635200e8a5709dd92211e47b4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9a2077087e7616d315fe13ce15993b64bcfd282b","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.head("},{"line_number":599,"context_line":"            url,"},{"line_number":600,"context_line":"            token\u003dself._get_non_admin_token(),"},{"line_number":601,"context_line":"            expected_status\u003dhttp_client.OK"},{"line_number":602,"context_line":"        )"},{"line_number":603,"context_line":"        self.head("},{"line_number":604,"context_line":"            url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_342e7343","line":601,"in_reply_to":"7f231b9d_c83e8628","updated":"2017-06-12 20:48:44.000000000","message":"I don\u0027t understand the comment. Can you provide an example? Do you mean refactor this into its own test?","commit_id":"668d8cdb98facf0635200e8a5709dd92211e47b4"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d720046d34c63e5c28a828326d1956b987621427","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def test_get_head_config_default_by_invalid_group(self):"},{"line_number":467,"context_line":"        \"\"\"Call ``GET \u0026 HEAD for /domains/config/{bad-group}/default``.\"\"\""},{"line_number":468,"context_line":"        # First try a valid group, but one we don\u0027t support for domain config"},{"line_number":469,"context_line":"        self.get(\u0027/domains/config/resource/default\u0027,"},{"line_number":470,"context_line":"                 expected_status\u003dhttp_client.FORBIDDEN)"},{"line_number":471,"context_line":"        self.head(\u0027/domains/config/resource/default\u0027,"},{"line_number":472,"context_line":"                  expected_status\u003dhttp_client.FORBIDDEN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_1ed0161f","line":469,"range":{"start_line":469,"start_character":34,"end_line":469,"end_character":42},"updated":"2017-06-23 01:56:13.000000000","message":"fixing the test :)","commit_id":"b56dc828221cb0ea5ab33acb0c09b61c24012e6e"}]}