)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b3df0d5d5774db55d381c3db2af19ae2306d07d8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There was also some inconsistencies in the existing documention"},{"line_number":14,"context_line":"saying the various APIs return 204 No Content when the response"},{"line_number":15,"context_line":"was actually 200 Ok. This corrects that as well."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic1f74b73e27a14428b129bed610d3d1d3d18f24e"},{"line_number":18,"context_line":"Partial-Bug: 1696574"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_6c5b3487","line":15,"updated":"2017-06-10 08:38:13.000000000","message":"I don\u0027t see this change?","commit_id":"0b030defb58a23c8d1d9a8ae3000a1f2caaf9f97"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"699eaa96181491f5e45b2e525298a4d2270bb671","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There was also some inconsistencies in the existing documention"},{"line_number":14,"context_line":"saying the various APIs return 204 No Content when the response"},{"line_number":15,"context_line":"was actually 200 Ok. This corrects that as well."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic1f74b73e27a14428b129bed610d3d1d3d18f24e"},{"line_number":18,"context_line":"Partial-Bug: 1696574"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_a8c8ea54","line":15,"in_reply_to":"7f231b9d_6c5b3487","updated":"2017-06-12 18:49:27.000000000","message":"It\u0027s in the authenticate-v3.inc document.","commit_id":"0b030defb58a23c8d1d9a8ae3000a1f2caaf9f97"}],"api-ref/source/v3/authenticate-v3.inc":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b3df0d5d5774db55d381c3db2af19ae2306d07d8","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"Get available project scopes"},{"line_number":596,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f231b9d_ac614c3c","line":594,"updated":"2017-06-10 08:38:13.000000000","message":"Same comment as on the OS-PKI diff","commit_id":"0b030defb58a23c8d1d9a8ae3000a1f2caaf9f97"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"699eaa96181491f5e45b2e525298a4d2270bb671","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"Get available project scopes"},{"line_number":596,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f231b9d_28bdfab6","line":594,"in_reply_to":"7f231b9d_ac614c3c","updated":"2017-06-12 18:49:27.000000000","message":"++ agreed, I\u0027ll remove this.","commit_id":"0b030defb58a23c8d1d9a8ae3000a1f2caaf9f97"}],"api-ref/source/v3/os-pki.inc":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b3df0d5d5774db55d381c3db2af19ae2306d07d8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Normal response codes: 200"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Error response codes: 413,415,405,404,403,401,400,503,409"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f231b9d_cc724812","line":49,"updated":"2017-06-10 08:38:13.000000000","message":"I don\u0027t think it makes sense to document HEAD for a list operation. We include HEAD for completeness but its value doesn\u0027t have special meaning in the same way that for example HEAD /projects/{}/users/{}/roles/{} does.","commit_id":"0b030defb58a23c8d1d9a8ae3000a1f2caaf9f97"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"699eaa96181491f5e45b2e525298a4d2270bb671","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Normal response codes: 200"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Error response codes: 413,415,405,404,403,401,400,503,409"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f231b9d_c8a2069b","line":49,"in_reply_to":"7f231b9d_cc724812","updated":"2017-06-12 18:49:27.000000000","message":"Agreed - based on our discussion earlier we can document this in a blanket statement for all HEAD APIs. I\u0027ll remove this.","commit_id":"0b030defb58a23c8d1d9a8ae3000a1f2caaf9f97"}],"keystone/auth/routers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f744a17cf4ee757408a821d9aec8b63250a70ff5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self._add_resource("},{"line_number":35,"context_line":"            mapper, auth_controller,"},{"line_number":36,"context_line":"            path\u003d\u0027/auth/tokens/OS-PKI/revoked\u0027,"},{"line_number":37,"context_line":"            get_head_action\u003d\u0027revocation_list\u0027,"},{"line_number":38,"context_line":"            rel\u003djson_home.build_v3_extension_resource_relation("},{"line_number":39,"context_line":"                \u0027OS-PKI\u0027, \u00271.0\u0027, \u0027revocations\u0027))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_d1f9c34d","line":37,"updated":"2017-06-10 04:39:53.000000000","message":"All these changes were rolled into their own commit: https://review.openstack.org/#/c/472881/","commit_id":"b7f321e8a5aee2f29b5012dcffab88973b72bf40"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a714e5dc208f885b6648ecf01268d34a8d6c68ec","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self._add_resource("},{"line_number":35,"context_line":"            mapper, auth_controller,"},{"line_number":36,"context_line":"            path\u003d\u0027/auth/tokens/OS-PKI/revoked\u0027,"},{"line_number":37,"context_line":"            get_head_action\u003d\u0027revocation_list\u0027,"},{"line_number":38,"context_line":"            rel\u003djson_home.build_v3_extension_resource_relation("},{"line_number":39,"context_line":"                \u0027OS-PKI\u0027, \u00271.0\u0027, \u0027revocations\u0027))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_719e6f08","line":37,"in_reply_to":"7f231b9d_d1f9c34d","updated":"2017-06-12 18:50:44.000000000","message":"Disregard this.. i commented on the wrong patch.","commit_id":"b7f321e8a5aee2f29b5012dcffab88973b72bf40"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"60ce7b1b96219b157cc3660fab8a4ef141310717","unresolved":false,"context_lines":[{"line_number":5102,"context_line":"                password\u003dself.default_domain_user[\u0027password\u0027]),"},{"line_number":5103,"context_line":"            expected_status\u003dhttp_client.FORBIDDEN)"},{"line_number":5104,"context_line":""},{"line_number":5105,"context_line":"    def test_get_catalog_no_token(self):"},{"line_number":5106,"context_line":"        \"\"\"Call ``GET /auth/catalog`` without a token.\"\"\""},{"line_number":5107,"context_line":"        self.get("},{"line_number":5108,"context_line":"            \u0027/auth/catalog\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_fca31d9d","line":5105,"range":{"start_line":5105,"start_character":8,"end_line":5105,"end_character":33},"updated":"2017-06-13 20:02:41.000000000","message":"Does this need a HEAD equivalent?","commit_id":"f8bd2b7a627466f8b1650fc9d604b924f67728fe"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e706e5da09fcb3595a530d0aa99938429e8b0604","unresolved":false,"context_lines":[{"line_number":5102,"context_line":"                password\u003dself.default_domain_user[\u0027password\u0027]),"},{"line_number":5103,"context_line":"            expected_status\u003dhttp_client.FORBIDDEN)"},{"line_number":5104,"context_line":""},{"line_number":5105,"context_line":"    def test_get_catalog_no_token(self):"},{"line_number":5106,"context_line":"        \"\"\"Call ``GET /auth/catalog`` without a token.\"\"\""},{"line_number":5107,"context_line":"        self.get("},{"line_number":5108,"context_line":"            \u0027/auth/catalog\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_d80ae888","line":5105,"in_reply_to":"7f231b9d_fca31d9d","updated":"2017-06-21 15:11:14.000000000","message":"Probably - let me test locally and push a new revision if so.","commit_id":"f8bd2b7a627466f8b1650fc9d604b924f67728fe"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8ba076ab72a74dcf23469b3734afacc92cbc1db7","unresolved":false,"context_lines":[{"line_number":5114,"context_line":"            \u0027/auth/catalog\u0027,"},{"line_number":5115,"context_line":"            noauth\u003dTrue,"},{"line_number":5116,"context_line":"            expected_status\u003dhttp_client.UNAUTHORIZED"},{"line_number":5117,"context_line":"        )"},{"line_number":5118,"context_line":""},{"line_number":5119,"context_line":"    def test_get_projects_with_project_scoped_token(self):"},{"line_number":5120,"context_line":"        r \u003d self.get(\u0027/auth/projects\u0027, expected_status\u003dhttp_client.OK)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_f40223b4","line":5117,"updated":"2017-06-22 20:44:22.000000000","message":"I would really rather these be split into separate tests, not because it matters at all but because all the others are that way. I\u0027ll fix in a followup.","commit_id":"e156d337a7f426dce09c000f4d2e00ce16d115f1"}]}
