)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"689a1b8950e2c306c5c4fd89465c9eeeb78f7c59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return 400 when trying to create trust with ambiguous role name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a use is trying to create a trust by specifying roles by name"},{"line_number":10,"context_line":"and the name is used by multiple roles, return a more descriptive"},{"line_number":11,"context_line":"error message. Prior to this it was returning \"role not found\"."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_34878012","line":9,"updated":"2017-06-22 17:57:29.000000000","message":"user*","commit_id":"d63d1cb75a6bf4168e34a81e9cffb03b71546557"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"689a1b8950e2c306c5c4fd89465c9eeeb78f7c59","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return 400 when trying to create trust with ambiguous role name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a use is trying to create a trust by specifying roles by name"},{"line_number":10,"context_line":"and the name is used by multiple roles, return a more descriptive"},{"line_number":11,"context_line":"error message. Prior to this it was returning \"role not found\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ife437ac15774f546f551e191cd5e6fdde7c67d49"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_b4727048","line":10,"updated":"2017-06-22 17:57:29.000000000","message":"The only case where this can happen is if a domain specific role exists with the same name as a global role, right?","commit_id":"d63d1cb75a6bf4168e34a81e9cffb03b71546557"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"3b16f2cd4c023ca1d60046bdce5083558b42a15a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Return 400 when trying to create trust with ambiguous role name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a use is trying to create a trust by specifying roles by name"},{"line_number":10,"context_line":"and the name is used by multiple roles, return a more descriptive"},{"line_number":11,"context_line":"error message. Prior to this it was returning \"role not found\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ife437ac15774f546f551e191cd5e6fdde7c67d49"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_941414a2","line":10,"in_reply_to":"5f201791_b4727048","updated":"2017-06-22 18:03:30.000000000","message":"Yes. since there cannot be two global roles with the same name.","commit_id":"d63d1cb75a6bf4168e34a81e9cffb03b71546557"}],"keystone/trust/controllers.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"511addf0a87c291793bc41c257134403ed2a5af6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                hints.add_filter(\"name\", name, case_sensitive\u003dTrue)"},{"line_number":89,"context_line":"                found_roles \u003d self.role_api.list_roles(hints)"},{"line_number":90,"context_line":"                if not found_roles:"},{"line_number":91,"context_line":"                    raise exception.RoleNotFound("},{"line_number":92,"context_line":"                        _(\"Role %s is not defined\") % name"},{"line_number":93,"context_line":"                    )"},{"line_number":94,"context_line":"                elif len(found_roles) \u003d\u003d 1:"},{"line_number":95,"context_line":"                    roles.append({\u0027id\u0027: found_roles[0][\u0027id\u0027]})"},{"line_number":96,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_9f5e6d10","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":21},"updated":"2017-06-22 18:22:44.000000000","message":"NIT: weird line wrap on the closing parens","commit_id":"1ec118a85f1e31573813e6b433a35d87f0f5bfb8"}]}