)]}'
{"keystone/tests/unit/test_v3_trust.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5ad37a00f892905cd89f3e51f7ffea111e179402","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_c8574458","line":44,"updated":"2017-07-17 18:07:31.000000000","message":"Per the guidelines, I don\u0027t think we can make this change: \n\nhttp://specs.openstack.org/openstack/api-wg/guidelines/api_interoperability.html","commit_id":"fb7070ca5cc908977349fc0b42a6a6409ac0d7bc"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"7d1d44a43c44ecd17fdf444b61231e84bf59ba16","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_aa707b09","line":44,"in_reply_to":"1f1a1f67_272a662b","updated":"2017-07-17 20:08:43.000000000","message":"We could add more posts to this test to show that you get a 400 in any case where at least one of the required attributes is missing, regardless of which attribute that is. That seems like a good addition. Not necessarily tied to this change, but if it helps move this along...","commit_id":"fb7070ca5cc908977349fc0b42a6a6409ac0d7bc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a3cb4c02842e078d0aa723c5ae5c511de3dbcd01","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_272a662b","line":44,"in_reply_to":"1f1a1f67_a78b1666","updated":"2017-07-17 19:12:10.000000000","message":"I guess what I meant by ^ is that a test that singles out the trustor case would help in understand this change. Because an empty trust body could result in a 400 for multiple attributes, right?","commit_id":"fb7070ca5cc908977349fc0b42a6a6409ac0d7bc"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"25a27e95e1038851d8fd10acc3179a63101ab84f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_6a370301","line":44,"in_reply_to":"1f1a1f67_aa707b09","updated":"2017-07-17 20:17:48.000000000","message":"actually, that already exists for the other 2 required props, but not for trustor... Done.","commit_id":"fb7070ca5cc908977349fc0b42a6a6409ac0d7bc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"11ccbeb674f6778a46d62c8311ec01c21daab241","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_a78b1666","line":44,"in_reply_to":"1f1a1f67_c34047a8","updated":"2017-07-17 19:07:18.000000000","message":"We should add another test the covers the case where the trustor isn\u0027t included in the response, because that should now return a 400.","commit_id":"fb7070ca5cc908977349fc0b42a6a6409ac0d7bc"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"5e52b4735ec9cab86fdde815dece5286cb1d5a59","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_c34047a8","line":44,"in_reply_to":"1f1a1f67_c8574458","updated":"2017-07-17 18:45:22.000000000","message":"I don\u0027t agree... Clients must already be coded to support both 400 and 401, since both are already possible today. There is no impact on clients here, interoperability or otherwise.","commit_id":"fb7070ca5cc908977349fc0b42a6a6409ac0d7bc"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"744ea0814fa4ab0d611e440d2b9a1481db3401d4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.trustee_user_id \u003d self.trustee_user[\u0027id\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_trust_bad_request(self):"},{"line_number":43,"context_line":"        self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: {}},"},{"line_number":44,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_trust_crud(self):"},{"line_number":47,"context_line":"        # create a new trust"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_ad42d5a9","line":44,"range":{"start_line":43,"start_character":1,"end_line":44,"end_character":58},"updated":"2017-07-17 20:42:14.000000000","message":"This is a break in the API. This must be reverted. Sorry.","commit_id":"d5450b6446363423a10aa4dc452759b5fa05a01d"}]}