)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"84a9e79c10f070d2df1b8ab9fbe4202f2e7195b6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanghuichan \u003cyanghc@fiberhome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-07 16:26:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace dict.iteritems() with dict.items() in keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.As mentioned in [1], we should avoid using six.iteritems"},{"line_number":10,"context_line":"  to achieve iterators. We can use dict.items instead, as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf3e73b7_0ca8281d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2017-08-07 18:38:22.000000000","message":"the code changed is:\n\n    if *not* isinstance(obj, dict) and hasattr(obj, \u0027iteritems\u0027):\n        return dict(obj.iteritems())\n\nSo we\u0027re not using iteritems on dictionaries as this states","commit_id":"046b520e20f7f4b3c89819dfeb1dbdc0eec9a3cf"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b908425d5974772dd91369177ba77c7d6703ad60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace dict.iteritems() with dict.items() in keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.As mentioned in [1], we should avoid using six.iteritems"},{"line_number":10,"context_line":"  to achieve iterators. We can use dict.items instead, as it"},{"line_number":11,"context_line":"  will return iterators in PY3 as well. And dict.items will"},{"line_number":12,"context_line":"  more readable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f436f4f_2470be72","line":9,"updated":"2017-08-08 15:09:49.000000000","message":"This wasn\u0027t using six. At a minimum the commit message should accurately state what changed and why.","commit_id":"046b520e20f7f4b3c89819dfeb1dbdc0eec9a3cf"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d4a5164efda25f9ebf626ecc86af2d358bd1885d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace dict.iteritems() with dict.items() in keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.As mentioned in [1], we should avoid using six.iteritems"},{"line_number":10,"context_line":"  to achieve iterators. We can use dict.items instead, as it"},{"line_number":11,"context_line":"  will return iterators in PY3 as well. And dict.items will"},{"line_number":12,"context_line":"  more readable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f436f4f_d5c19a30","line":9,"in_reply_to":"9f436f4f_2470be72","updated":"2017-08-08 15:25:25.000000000","message":"I think it is using six, just somehow in the background, otherwise iteritems should fail when running py3.","commit_id":"046b520e20f7f4b3c89819dfeb1dbdc0eec9a3cf"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"992065f0decc76d6307125876c8b31c6f2b2c4bf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace dict.iteritems() with dict.items() in keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.As mentioned in [1], we should avoid using six.iteritems"},{"line_number":10,"context_line":"  to achieve iterators. We can use dict.items instead, as it"},{"line_number":11,"context_line":"  will return iterators in PY3 as well. And dict.items will"},{"line_number":12,"context_line":"  more readable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_c64a1f7f","line":9,"in_reply_to":"9f436f4f_d5c19a30","updated":"2019-04-12 21:02:09.000000000","message":"Not necessarily, because it\u0027s checking hasattr(obj, \u0027iteritems\u0027), so on python3 it just wouldn\u0027t have gone into that case.","commit_id":"046b520e20f7f4b3c89819dfeb1dbdc0eec9a3cf"}]}