)]}'
{"keystone/identity/core.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"483183c3e25116b8edfe72637e80603e3395683e","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        \"\"\""},{"line_number":532,"context_line":"        project_id \u003d payload[\u0027resource_info\u0027]"},{"line_number":533,"context_line":"        for domain, d in self.domain_configs.items():"},{"line_number":534,"context_line":"            try:"},{"line_number":535,"context_line":"                d[\u0027driver\u0027].unset_default_project_id(project_id)"},{"line_number":536,"context_line":"            except exception.Forbidden:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_6a5adff3","line":533,"range":{"start_line":533,"start_character":9,"end_line":533,"end_character":53},"updated":"2017-08-09 21:51:47.000000000","message":"You could have constructed a single iterator of the drivers:\n\n  drivers \u003d itertools.chain(self.domain_configs.values(), [{\u0027driver\u0027: self.driver}])\n  for d in drivers:\n      d[\u0027driver\u0027].unset_default_project_id(project_id)\n  except exception.Forbidden:\n      pass\n\nThis just compresses into a single try/except. This change isn\u0027t needed to accept the code and it may make it less readable overall. YMMV","commit_id":"980e324e22cd101f655b4e594a69128443c04643"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"761b6b23978eeb44a4a812af99c3412aefabafcd","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        \"\"\""},{"line_number":532,"context_line":"        project_id \u003d payload[\u0027resource_info\u0027]"},{"line_number":533,"context_line":"        for domain, d in self.domain_configs.items():"},{"line_number":534,"context_line":"            try:"},{"line_number":535,"context_line":"                d[\u0027driver\u0027].unset_default_project_id(project_id)"},{"line_number":536,"context_line":"            except exception.Forbidden:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_2ddd1170","line":533,"in_reply_to":"9f436f4f_6a5adff3","updated":"2017-08-09 22:41:24.000000000","message":"Done","commit_id":"980e324e22cd101f655b4e594a69128443c04643"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9efe8ae81f2755f0a6a8a7799f3d7779d46e8add","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        project_id \u003d payload[\u0027resource_info\u0027]"},{"line_number":533,"context_line":"        for domain, d in self.domain_configs.items():"},{"line_number":534,"context_line":"            try:"},{"line_number":535,"context_line":"                d[\u0027driver\u0027].unset_default_project_id(project_id)"},{"line_number":536,"context_line":"            except exception.Forbidden:"},{"line_number":537,"context_line":"                # NOTE(lbragstad): If the driver throws a Forbidden, it\u0027s because"},{"line_number":538,"context_line":"                # the driver doesn\u0027t support writes. This is the case with the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_47a836da","line":535,"updated":"2017-08-09 21:06:53.000000000","message":"This is apparently necessary because the default driver doesn\u0027t appear to be in the self.domain_configs dictionary...","commit_id":"980e324e22cd101f655b4e594a69128443c04643"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"a078d250674ee4bbde8093bdcdfe2df021787d29","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"    @mock.patch.object(sql_identity.Identity, \u0027unset_default_project_id\u0027)"},{"line_number":2506,"context_line":"    def test_delete_project_unset_project_ids_for_all_backends(self, sql_mock,"},{"line_number":2507,"context_line":"                                                               ldap_mock):"},{"line_number":2508,"context_line":"        ldap_mock.side_effect \u003d exception.Forbidden"},{"line_number":2509,"context_line":"        project \u003d unit.new_project_ref("},{"line_number":2510,"context_line":"            domain_id\u003dCONF.identity.default_domain_id"},{"line_number":2511,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f436f4f_7d460352","line":2508,"range":{"start_line":2508,"start_character":8,"end_line":2508,"end_character":51},"updated":"2017-08-11 00:03:02.000000000","message":"is this really needed ?","commit_id":"d0ad287df397513dd7cb8dd4da0cae383c6b49b0"}]}