)]}'
{"doc/source/getting-started/policy_mapping.rst":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"09d7d0c9cbb48657f629caab1a629815aab59f9c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"*global_grant_resources* are:"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- /v3/users/{user_id}/roles/{role_id}"},{"line_number":220,"context_line":"- /v3/groups/{group_id}/roles/{role_id}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":".. _global_grant_collections:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f287b81_faa5dd9f","line":220,"updated":"2017-08-30 15:52:24.000000000","message":"I\u0027m not sure if this should be here or in the follow up review adding group functionality","commit_id":"be0f2bf1155db486d0536cf2e3c9841a7f79671f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"35a36a965055c4dadd473555a87b89414881752a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"*global_grant_resources* are:"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- /v3/users/{user_id}/roles/{role_id}"},{"line_number":220,"context_line":"- /v3/groups/{group_id}/roles/{role_id}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":".. _global_grant_collections:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f287b81_b7bbb1c2","line":220,"in_reply_to":"7f287b81_faa5dd9f","updated":"2017-09-01 16:14:12.000000000","message":"Done","commit_id":"be0f2bf1155db486d0536cf2e3c9841a7f79671f"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"09d7d0c9cbb48657f629caab1a629815aab59f9c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"*global_grant_collections* are:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"- /v3/users/{user_id}/roles"},{"line_number":227,"context_line":"- /v3/groups/{group_id}/roles"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":".. _grant_resources:"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f287b81_9ab019df","line":227,"updated":"2017-08-30 15:52:24.000000000","message":"Same as above","commit_id":"be0f2bf1155db486d0536cf2e3c9841a7f79671f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"35a36a965055c4dadd473555a87b89414881752a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"*global_grant_collections* are:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"- /v3/users/{user_id}/roles"},{"line_number":227,"context_line":"- /v3/groups/{group_id}/roles"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":".. _grant_resources:"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f287b81_97b0b5df","line":227,"in_reply_to":"7f287b81_9ab019df","updated":"2017-09-01 16:14:12.000000000","message":"Done","commit_id":"be0f2bf1155db486d0536cf2e3c9841a7f79671f"}],"keystone/assignment/controllers.py":[{"author":{"_account_id":24269,"name":"chenaidong1","email":"chen.aidong@zte.com.cn","username":"chenaidong1"},"change_message_id":"486b776d6c1a33941c1be1428178101c3ec9550b","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    @controller.protected(callback\u003dfunctools.partial("},{"line_number":721,"context_line":"        _check_grant_protection, allow_no_user\u003dTrue))"},{"line_number":722,"context_line":"    def revoke_global_grant(self, request, role_id, user_id\u003dNone):"},{"line_number":723,"context_line":"        \"\"\"Revoke a global role from a user.\"\"\""},{"line_number":724,"context_line":"        self._require_user_xor_group(user_id, None)"},{"line_number":725,"context_line":"        self.assignment_api.delete_grant("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_2e6e74ff","line":722,"range":{"start_line":722,"start_character":8,"end_line":722,"end_character":27},"updated":"2017-08-17 07:27:38.000000000","message":"Hi, in routers.py, should revoke_global_grant be added? such as:\n\nself._add_resource(\n            mapper, grant_controller,\n            path\u003d\u0027/users/{user_id}/roles/{role_id}\u0027,\n            get_head_action\u003d\u0027check_global_grant\u0027,\n            put_action\u003d\u0027create_global_grant\u0027,\n            delete_action\u003d\u0027revoke_global_grant\u0027,\n            rel\u003djson_home.build_v3_resource_relation(\u0027user_roles\u0027),\n            path_vars\u003d{\n                \u0027user_id\u0027: json_home.Parameters.USER_ID,\n                \u0027role_id\u0027: json_home.Parameters.ROLE_ID\n            })","commit_id":"a9509dd92fabbb4e5f117672c68e5f371d1206d7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d0d461ecfab71f5223bac80906dd22f7dbcc1420","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    @controller.protected(callback\u003dfunctools.partial("},{"line_number":721,"context_line":"        _check_grant_protection, allow_no_user\u003dTrue))"},{"line_number":722,"context_line":"    def revoke_global_grant(self, request, role_id, user_id\u003dNone):"},{"line_number":723,"context_line":"        \"\"\"Revoke a global role from a user.\"\"\""},{"line_number":724,"context_line":"        self._require_user_xor_group(user_id, None)"},{"line_number":725,"context_line":"        self.assignment_api.delete_grant("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_0e495e31","line":722,"in_reply_to":"9f436f4f_2e6e74ff","updated":"2017-08-17 18:49:27.000000000","message":"Yep! Good catch","commit_id":"a9509dd92fabbb4e5f117672c68e5f371d1206d7"}]}