)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"3725cc8b4d2c76b7fc337568206269513e1fd074","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zlyqqq \u003chfzhengliuyang@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-17 17:22:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update parameters in sp and idp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8a3769d87fdfcf4becd3b6c72ce8d5955102c5f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_5b9de608","line":7,"updated":"2017-08-17 18:32:32.000000000","message":"Could you add a more detail about why these are no longer required?","commit_id":"ee948722b54185d9e5a8991b856f0c47db8fd95b"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"fdde41aa4f692b41d350068090db4cbd3daadb91","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zlyqqq \u003chfzhengliuyang@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-17 17:22:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update parameters in sp and idp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8a3769d87fdfcf4becd3b6c72ce8d5955102c5f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_0e203e49","line":7,"in_reply_to":"9f436f4f_5b9de608","updated":"2017-08-17 18:53:23.000000000","message":"++","commit_id":"ee948722b54185d9e5a8991b856f0c47db8fd95b"}],"api-ref/source/v3-ext/federation/identity-provider/parameters.yaml":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"51290db716b1369059d79ad3921796c8e2b15c86","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"domain_id:"},{"line_number":44,"context_line":"  description: |"},{"line_number":45,"context_line":"    The ID of a domain that is associated with the Identity Provider. If the"},{"line_number":46,"context_line":"    value is not specified by the client, the service will automatically create"},{"line_number":47,"context_line":"    a domain and associate it to the Identity Provider. Federated users that"},{"line_number":48,"context_line":"    authenticate with the Identity Provider will be created under the domain"},{"line_number":49,"context_line":"    specified."},{"line_number":50,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_9be66344","line":47,"range":{"start_line":45,"start_character":70,"end_line":47,"end_character":54},"updated":"2017-10-06 08:48:50.000000000","message":"Given this is true, any \"GET\" or reponse of \"CREATE\" should return \"domain_id\" in the body, this makes me think it is required for such API, so you might need update those API as well.","commit_id":"e8302029a1376ec4138f83eca4940bd99236d40f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"0d70e25e7e0c6a785118848d037a38228a7e4272","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"domain_id:"},{"line_number":44,"context_line":"  description: |"},{"line_number":45,"context_line":"    The ID of a domain that is associated with the Identity Provider. If the"},{"line_number":46,"context_line":"    value is not specified by the client, the service will automatically create"},{"line_number":47,"context_line":"    a domain and associate it to the Identity Provider. Federated users that"},{"line_number":48,"context_line":"    authenticate with the Identity Provider will be created under the domain"},{"line_number":49,"context_line":"    specified."},{"line_number":50,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f96bb07_d6cae89f","line":47,"range":{"start_line":45,"start_character":70,"end_line":47,"end_character":54},"in_reply_to":"7f515b1d_9be66344","updated":"2018-01-21 13:40:43.000000000","message":"So you would like to see, for example, a `domain_id_response` parameter that sets required to true?","commit_id":"e8302029a1376ec4138f83eca4940bd99236d40f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"51290db716b1369059d79ad3921796c8e2b15c86","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    Whether the Identity Provider is enabled or not. If the value is not"},{"line_number":57,"context_line":"    specified by the client, the service will default this to false."},{"line_number":58,"context_line":"  in: body"},{"line_number":59,"context_line":"  required: false"},{"line_number":60,"context_line":"  type: bool"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"id_body:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_5bd22b5e","line":59,"range":{"start_line":59,"start_character":2,"end_line":59,"end_character":17},"updated":"2017-10-06 08:48:50.000000000","message":"same.","commit_id":"e8302029a1376ec4138f83eca4940bd99236d40f"}]}