)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"2c7bdee9f1058d6bb3d4a8f92a089e417c69f80f","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    session.set_defaults("},{"line_number":63,"context_line":"        sql_connection\u003d\"sqlite:///keystone.db\","},{"line_number":64,"context_line":"        sqlite_db\u003d\"keystone.db\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def initialize_decorator(init):"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAATn%2F9Xzg%3D","line":64,"updated":"2013-12-12 05:46:02.000000000","message":"why hardcoding these? Why not\n\nsession.set_defaults(\n    sql_connection\u003dCONF.database.connection,\n    sqlite_db\u003dCONF.sqlite_db)","commit_id":"eda64e3767dcb57768a1963811e4c245f271db93"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"56627efd271144985b3d49641758a6d0f5a847a8","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    session.set_defaults("},{"line_number":63,"context_line":"        sql_connection\u003d\"sqlite:///keystone.db\","},{"line_number":64,"context_line":"        sqlite_db\u003d\"keystone.db\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def initialize_decorator(init):"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAATn%2F9VzE%3D","line":64,"in_reply_to":"AAAATn%2F9Xzg%3D","updated":"2013-12-12 13:58:05.000000000","message":"This is what sets the defaults for those CONF values. Looks like they\u0027ve got their own default but it\u0027s different from what keystone used before, so I wanted to keep the defaults the same as they were for backwards compat..\n\nSee\nhttps://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/session.py#L21\nfor the doc\n\nhttps://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/session.py#L364\nfor the code","commit_id":"eda64e3767dcb57768a1963811e4c245f271db93"}],"keystone/tests/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"53b895cb6942e5a757bc5494ce1d250e375c28b1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    return os.path.join(TMPDIR, *p)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# TODO(blk-u): this also has to happen when start keystone and http!"},{"line_number":106,"context_line":"session.set_defaults("},{"line_number":107,"context_line":"    sql_connection\u003d\"sqlite:///\" + tmpdir(\u0027test.db\u0027),"},{"line_number":108,"context_line":"    sqlite_db\u003dtmpdir(\u0027test.db\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FIWo%3D","line":105,"updated":"2013-10-03 19:45:09.000000000","message":"starting*? and httpd*?","commit_id":"8ec04a6bffd4ac194bf470da7037c5dfe43540f5"}],"keystone/tests/test_config.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"a9741c0eaf7c443b15d44b15f277bb82130656df","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                     tests.dirs.tests(\u0027test_overrides.conf\u0027),"},{"line_number":50,"context_line":"                     tests.dirs.tests(\u0027deprecated.conf\u0027), ])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def testSql(self):"},{"line_number":53,"context_line":"        # Options in [sql] were moved to [database] in Icehouse for the change"},{"line_number":54,"context_line":"        # to use oslo-incubator\u0027s db.sqlalchemy.sessions."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F89Gc%3D","line":52,"updated":"2013-12-18 12:34:23.000000000","message":"Very minor. I think this is not the best name for the test function. Even service methods named in camel-case, I believe camel-case used for service methods visual separation. \"Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability.\" pep8 (c)","commit_id":"414f3ed412dc38b8e650023142fb1ba1a2ada569"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"881377258305fb5d67f31a1538688559f694ef5a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                     tests.dirs.tests(\u0027test_overrides.conf\u0027),"},{"line_number":50,"context_line":"                     tests.dirs.tests(\u0027deprecated.conf\u0027), ])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def testSql(self):"},{"line_number":53,"context_line":"        # Options in [sql] were moved to [database] in Icehouse for the change"},{"line_number":54,"context_line":"        # to use oslo-incubator\u0027s db.sqlalchemy.sessions."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F88Ts%3D","line":52,"in_reply_to":"AAAATn%2F89Gc%3D","updated":"2013-12-18 14:55:09.000000000","message":"I agree this should be fixed... hopefully will have time to work on this soon.","commit_id":"414f3ed412dc38b8e650023142fb1ba1a2ada569"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"60b9bcbe01635fd7dd3d4bcd82dfdfc170b60c29","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # to use oslo-incubator\u0027s db.sqlalchemy.sessions."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.assertEqual(CONF.database.connection, \u0027sqlite://deprecated\u0027)"},{"line_number":57,"context_line":"        self.assertEqual(CONF.database.idle_timeout, 54321)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F9Axg%3D","line":57,"updated":"2013-12-17 18:01:22.000000000","message":"awesome! I think we need one more test showing that if both [sq] and [database] sections are configured, the ones in [database] will be used.","commit_id":"414f3ed412dc38b8e650023142fb1ba1a2ada569"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"881377258305fb5d67f31a1538688559f694ef5a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # to use oslo-incubator\u0027s db.sqlalchemy.sessions."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.assertEqual(CONF.database.connection, \u0027sqlite://deprecated\u0027)"},{"line_number":57,"context_line":"        self.assertEqual(CONF.database.idle_timeout, 54321)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAATn%2F88To%3D","line":57,"in_reply_to":"AAAATn%2F9Axg%3D","updated":"2013-12-18 14:55:09.000000000","message":"I agree this should be fixed... hopefully will have time to work on this soon.","commit_id":"414f3ed412dc38b8e650023142fb1ba1a2ada569"}]}