)]}'
{"keystone/token/providers/fernet/core.py":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"f362dd6e3187727adf3e8c57be7707fa89f9e45f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            methods.append(\u0027token\u0027)"},{"line_number":163,"context_line":"        project_id \u003d token_data[\u0027access\u0027][\u0027token\u0027].get(\u0027tenant\u0027, {}).get(\u0027id\u0027)"},{"line_number":164,"context_line":"        domain_id \u003d None"},{"line_number":165,"context_line":"        is_global \u003d False"},{"line_number":166,"context_line":"        trust_id \u003d token_data[\u0027access\u0027].get(\u0027trust\u0027, {}).get(\u0027id\u0027)"},{"line_number":167,"context_line":"        access_token_id \u003d None"},{"line_number":168,"context_line":"        federated_info \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_006716b9","line":165,"updated":"2017-08-30 16:55:02.000000000","message":"Is this because we aren\u0027t supporting global roles on the V2 api? If so, I think adding a one line (or inline) comment noting such would be useful down the road","commit_id":"098b0217be4adbe5fb18aa0e583ca410eb949fef"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bc9a6d3498532b3a316508c0d8dfc42b556acc2","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            methods.append(\u0027token\u0027)"},{"line_number":163,"context_line":"        project_id \u003d token_data[\u0027access\u0027][\u0027token\u0027].get(\u0027tenant\u0027, {}).get(\u0027id\u0027)"},{"line_number":164,"context_line":"        domain_id \u003d None"},{"line_number":165,"context_line":"        is_global \u003d False"},{"line_number":166,"context_line":"        trust_id \u003d token_data[\u0027access\u0027].get(\u0027trust\u0027, {}).get(\u0027id\u0027)"},{"line_number":167,"context_line":"        access_token_id \u003d None"},{"line_number":168,"context_line":"        federated_info \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_ee4f5b68","line":165,"in_reply_to":"7f287b81_006716b9","updated":"2017-08-30 18:02:36.000000000","message":"++","commit_id":"098b0217be4adbe5fb18aa0e583ca410eb949fef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7a3e7cff5335b04537defbf767c96371a30800d7","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            methods.append(\u0027token\u0027)"},{"line_number":163,"context_line":"        project_id \u003d token_data[\u0027access\u0027][\u0027token\u0027].get(\u0027tenant\u0027, {}).get(\u0027id\u0027)"},{"line_number":164,"context_line":"        domain_id \u003d None"},{"line_number":165,"context_line":"        is_global \u003d False"},{"line_number":166,"context_line":"        trust_id \u003d token_data[\u0027access\u0027].get(\u0027trust\u0027, {}).get(\u0027id\u0027)"},{"line_number":167,"context_line":"        access_token_id \u003d None"},{"line_number":168,"context_line":"        federated_info \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f771390e","line":165,"in_reply_to":"7f287b81_ee4f5b68","updated":"2017-09-01 16:23:16.000000000","message":"We also have that documented at the controller layer. in a subsequent patch.\n\nhttps://review.openstack.org/#/c/498577/10/keystone/token/controllers.py","commit_id":"098b0217be4adbe5fb18aa0e583ca410eb949fef"}],"keystone/token/providers/fernet/token_formatters.py":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"f362dd6e3187727adf3e8c57be7707fa89f9e45f","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"class GlobalScopedPayload(BasePayload):"},{"line_number":713,"context_line":"    version \u003d 8"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @classmethod"},{"line_number":716,"context_line":"    def create_arguments_apply(cls, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_401f5e07","line":713,"updated":"2017-08-30 16:55:02.000000000","message":"why 8?","commit_id":"098b0217be4adbe5fb18aa0e583ca410eb949fef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7a3e7cff5335b04537defbf767c96371a30800d7","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"class GlobalScopedPayload(BasePayload):"},{"line_number":713,"context_line":"    version \u003d 8"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @classmethod"},{"line_number":716,"context_line":"    def create_arguments_apply(cls, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_57d92df2","line":713,"in_reply_to":"7f287b81_2e49e35e","updated":"2017-09-01 16:23:16.000000000","message":"Yep - the version just increments sequentially and is only used locally in keystone. I opted to add GlobalScopedPayload as version 8 instead of adding it as 0 or 1 and renaming the rest of the payload classes. This version is serialized and encrypted.","commit_id":"098b0217be4adbe5fb18aa0e583ca410eb949fef"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3bc9a6d3498532b3a316508c0d8dfc42b556acc2","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"class GlobalScopedPayload(BasePayload):"},{"line_number":713,"context_line":"    version \u003d 8"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @classmethod"},{"line_number":716,"context_line":"    def create_arguments_apply(cls, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_2e49e35e","line":713,"in_reply_to":"7f287b81_401f5e07","updated":"2017-08-30 18:02:36.000000000","message":"8th version of the payload?","commit_id":"098b0217be4adbe5fb18aa0e583ca410eb949fef"}]}
