)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"caf3dc6e643a3114a5dc18b1a40b8452d8309c84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gage Hugo \u003cgagehugo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-26 18:14:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Refactor test_backend_ldap tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the testing backend for LDAP relies on multiple inheritance"},{"line_number":10,"context_line":"of many base and testing classes, which results in many of these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_6c3941d5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2017-09-29 16:26:49.000000000","message":"Is this waiting on more changes?","commit_id":"613ed56b656e27c26fdeab7a7f8278a3c3b99dc8"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"62b9476303b628465bd2400ae0931b5f6eae3a23","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gage Hugo \u003cgagehugo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-26 18:14:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP - Refactor test_backend_ldap tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the testing backend for LDAP relies on multiple inheritance"},{"line_number":10,"context_line":"of many base and testing classes, which results in many of these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_ccfef569","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"in_reply_to":"7f515b1d_6c3941d5","updated":"2017-09-29 16:53:01.000000000","message":"Yes, this current change isn\u0027t necessarily correct","commit_id":"613ed56b656e27c26fdeab7a7f8278a3c3b99dc8"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"caf3dc6e643a3114a5dc18b1a40b8452d8309c84","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"                  self).test_remove_foreign_assignments_when_deleting_a_domain)"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"class LDAPIdentity(BaseLDAPIdentity):"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"    def assert_backends(self):"},{"line_number":1046,"context_line":"        _assert_backends(self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_ac23b9a6","line":1043,"range":{"start_line":1043,"start_character":6,"end_line":1043,"end_character":18},"updated":"2017-09-29 16:26:49.000000000","message":"What inherits unit.TestCase now that it\u0027s removed from here? The BaseLDAPIdentity class inherits from other classes but they all subclass object.","commit_id":"613ed56b656e27c26fdeab7a7f8278a3c3b99dc8"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"62b9476303b628465bd2400ae0931b5f6eae3a23","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"                  self).test_remove_foreign_assignments_when_deleting_a_domain)"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"class LDAPIdentity(BaseLDAPIdentity):"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"    def assert_backends(self):"},{"line_number":1046,"context_line":"        _assert_backends(self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_6cf7018d","line":1043,"range":{"start_line":1043,"start_character":6,"end_line":1043,"end_character":18},"in_reply_to":"7f515b1d_ac23b9a6","updated":"2017-09-29 16:53:01.000000000","message":"https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_ldap_pool.py#L210\n\nIt does there, but this is not really the correct method right now for this. The inheritance chain is confusing.","commit_id":"613ed56b656e27c26fdeab7a7f8278a3c3b99dc8"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e1fde2bb617b5f3e9e356a089881a63a0bb80c01","unresolved":false,"context_lines":[{"line_number":1769,"context_line":"        return config_files"},{"line_number":1770,"context_line":""},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":"class LDAPIdentityEnabledEmulation(LDAPIdentity, unit.TestCase):"},{"line_number":1773,"context_line":"    def setUp(self):"},{"line_number":1774,"context_line":"        super(LDAPIdentityEnabledEmulation, self).setUp()"},{"line_number":1775,"context_line":"        _assert_backends(self, identity\u003d\u0027ldap\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b65fe270","line":1772,"range":{"start_line":1772,"start_character":35,"end_line":1772,"end_character":47},"updated":"2017-10-23 12:31:13.000000000","message":"looks like it is only inherited here ... why not pull all the code here then?","commit_id":"de9546b4ef2c7a8baab539cc7ae0e205601b23dd"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"14bc68133a368029e394de7708a7747b5874f227","unresolved":false,"context_lines":[{"line_number":1769,"context_line":"        return config_files"},{"line_number":1770,"context_line":""},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":"class LDAPIdentityEnabledEmulation(LDAPIdentity, unit.TestCase):"},{"line_number":1773,"context_line":"    def setUp(self):"},{"line_number":1774,"context_line":"        super(LDAPIdentityEnabledEmulation, self).setUp()"},{"line_number":1775,"context_line":"        _assert_backends(self, identity\u003d\u0027ldap\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_82137d5c","line":1772,"range":{"start_line":1772,"start_character":35,"end_line":1772,"end_character":47},"in_reply_to":"3f4b6375_b65fe270","updated":"2017-10-23 15:39:17.000000000","message":"It\u0027s also inherited here:\n\nhttps://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_ldap_pool.py#L211","commit_id":"de9546b4ef2c7a8baab539cc7ae0e205601b23dd"}]}