)]}'
{"keystone/exception.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b9c89d06c725cf968e9bd6f3c3ffd6b5ea60623b","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"class LDAPSizeLimitExceeded(UnexpectedError):"},{"line_number":614,"context_line":"    message_format \u003d _(\u0027Number of User/Group entities returned by LDAP\u0027"},{"line_number":615,"context_line":"                       \u0027 exceeded size limit. Contact your LDAP administrator.\u0027)"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_72a96122","line":614,"range":{"start_line":614,"start_character":66,"end_line":614,"end_character":71},"updated":"2017-10-13 20:21:00.000000000","message":"nit: add the space here to be consistent with other Exceptions. We can fix the pep8 concern, too:\n\n  message_format \u003d _(\u0027Number of User/Group entities returned by LDAP \u0027\n                     \u0027exceeded size limit. Contact your LDAP \u0027\n                     \u0027administrator.\u0027)","commit_id":"9052564385a113b2ae5462802c0784f7ec5c8fc9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b9c89d06c725cf968e9bd6f3c3ffd6b5ea60623b","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"class LDAPSizeLimitExceeded(UnexpectedError):"},{"line_number":614,"context_line":"    message_format \u003d _(\u0027Number of User/Group entities returned by LDAP\u0027"},{"line_number":615,"context_line":"                       \u0027 exceeded size limit. Contact your LDAP administrator.\u0027)"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_4d45a442","line":615,"range":{"start_line":615,"start_character":34,"end_line":615,"end_character":44},"updated":"2017-10-13 20:21:00.000000000","message":"This is going to be a long shot, but do we want to give more specifics about the actual limit here? \"size limit\" seems vague but I imagine this is going to tie back to a bunch of different implementations and it might be hard to be specific.","commit_id":"9052564385a113b2ae5462802c0784f7ec5c8fc9"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"17abb269d6401f1de77672b7cc8a4a370daed216","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"class LDAPSizeLimitExceeded(UnexpectedError):"},{"line_number":614,"context_line":"    message_format \u003d _(\u0027Number of User/Group entities returned by LDAP\u0027"},{"line_number":615,"context_line":"                       \u0027 exceeded size limit. Contact your LDAP administrator.\u0027)"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_31f075fe","line":615,"range":{"start_line":615,"start_character":34,"end_line":615,"end_character":44},"in_reply_to":"5f4e5783_4d45a442","updated":"2017-10-16 08:40:44.000000000","message":"I\u0027m not sure what other information you could give here, all we have to go on is the exception from pyldap.","commit_id":"9052564385a113b2ae5462802c0784f7ec5c8fc9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b9c89d06c725cf968e9bd6f3c3ffd6b5ea60623b","unresolved":false,"context_lines":[{"line_number":613,"context_line":"class LDAPSizeLimitExceeded(UnexpectedError):"},{"line_number":614,"context_line":"    message_format \u003d _(\u0027Number of User/Group entities returned by LDAP\u0027"},{"line_number":615,"context_line":"                       \u0027 exceeded size limit. Contact your LDAP administrator.\u0027)"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_527b05bd","line":616,"updated":"2017-10-13 20:21:00.000000000","message":"PEP8 is complaining about the newline being here.","commit_id":"9052564385a113b2ae5462802c0784f7ec5c8fc9"}],"keystone/identity/backends/ldap/common.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b9c89d06c725cf968e9bd6f3c3ffd6b5ea60623b","unresolved":false,"context_lines":[{"line_number":934,"context_line":"                ldap_result \u003d self.conn.search_s(base_utf8, scope,"},{"line_number":935,"context_line":"                                                 filterstr_utf8,"},{"line_number":936,"context_line":"                                                 attrlist_utf8, attrsonly)"},{"line_number":937,"context_line":"            except ldap.SIZELIMIT_EXCEEDED:"},{"line_number":938,"context_line":"                raise exception.LDAPSizeLimitExceeded()"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"        py_result \u003d convert_ldap_result(ldap_result)"},{"line_number":941,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_f26af1ea","line":938,"range":{"start_line":937,"start_character":12,"end_line":938,"end_character":55},"updated":"2017-10-13 20:21:00.000000000","message":"We should be able to add a unit test for this somewhere in out backend suite, even if it is using mocks.","commit_id":"9052564385a113b2ae5462802c0784f7ec5c8fc9"}]}