)]}'
{"keystone/assignment/core.py":[{"author":{"_account_id":27385,"name":"lvxianguo","email":"lvxianguo@inspur.com","username":"lvxianguo"},"change_message_id":"0a9a059f515a1f43dd1fe0acacbc596e04184cab","unresolved":false,"context_lines":[{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        \"\"\""},{"line_number":1163,"context_line":"        role \u003d self.role_api.get_role(role_id)"},{"line_number":1164,"context_line":"        if role.get(\u0027domain_id\u0027):"},{"line_number":1165,"context_line":"            raise exception.ValidationError("},{"line_number":1166,"context_line":"                \u0027Role %(role_id)s is a domain-specific role. Unable to use \u0027"},{"line_number":1167,"context_line":"                \u0027a domain-specific role in a system assignment.\u0027 % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_fdc2d052","line":1164,"range":{"start_line":1164,"start_character":15,"end_line":1164,"end_character":16},"updated":"2017-12-20 09:01:36.000000000","message":"Does it also need to check the presence of the group?","commit_id":"fad77169a7853e7b9b9cc85c3906fd425ac92c95"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d4a9d4800023d08089119c48ecab78cd4aff1003","unresolved":false,"context_lines":[{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        \"\"\""},{"line_number":1163,"context_line":"        role \u003d self.role_api.get_role(role_id)"},{"line_number":1164,"context_line":"        if role.get(\u0027domain_id\u0027):"},{"line_number":1165,"context_line":"            raise exception.ValidationError("},{"line_number":1166,"context_line":"                \u0027Role %(role_id)s is a domain-specific role. Unable to use \u0027"},{"line_number":1167,"context_line":"                \u0027a domain-specific role in a system assignment.\u0027 % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_54710ce0","line":1164,"range":{"start_line":1164,"start_character":15,"end_line":1164,"end_character":16},"in_reply_to":"bf8cb3f7_2659c2fd","updated":"2017-12-20 15:59:42.000000000","message":"Added a test for this in a subsequent patch: \n\nhttps://review.openstack.org/#/c/524017/7/keystone/tests/unit/test_v3_assignment.py@3349","commit_id":"fad77169a7853e7b9b9cc85c3906fd425ac92c95"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"424301a1913637bb10017bd4e9b4c3d8fecf6a61","unresolved":false,"context_lines":[{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        \"\"\""},{"line_number":1163,"context_line":"        role \u003d self.role_api.get_role(role_id)"},{"line_number":1164,"context_line":"        if role.get(\u0027domain_id\u0027):"},{"line_number":1165,"context_line":"            raise exception.ValidationError("},{"line_number":1166,"context_line":"                \u0027Role %(role_id)s is a domain-specific role. Unable to use \u0027"},{"line_number":1167,"context_line":"                \u0027a domain-specific role in a system assignment.\u0027 % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_2659c2fd","line":1164,"range":{"start_line":1164,"start_character":15,"end_line":1164,"end_character":16},"in_reply_to":"df87a7cf_fdc2d052","updated":"2017-12-20 14:31:02.000000000","message":"Good question - I\u0027ll add a test for this case and see what happens.","commit_id":"fad77169a7853e7b9b9cc85c3906fd425ac92c95"}]}