)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"8cb7f0b2fb7a819fbe7e3a29dfd57791f4c88cfb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit introduces new policies that control RBAC for assigning"},{"line_number":10,"context_line":"users roles on the system."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bp system-scope"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie606e769427a5ca422997efe92402e712f3cf45f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f485f77_3e90904e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":15},"updated":"2017-11-14 18:27:28.000000000","message":"When I click on this I get \"No feature specifications match your criteria.\"","commit_id":"f51ad843ada563aad4a8720bed2d5ddc83e9eac2"}],"etc/policy.v3cloudsample.json":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"1eb0d1e7c40c894c1d7f1b58b2707d31401e755b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"identity:list_role_inference_rules\": \"rule:cloud_admin\","},{"line_number":110,"context_line":"    \"identity:check_implied_role\": \"rule:cloud_admin or rule:admin_and_matching_prior_role_domain_id\","},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    \"identity:list_system_grants_for_user\": \"rule:admin_required\","},{"line_number":113,"context_line":"    \"identity:check_system_grant_for_user\": \"rule:admin_required\","},{"line_number":114,"context_line":"    \"identity:create_system_grant_for_user\": \"rule:admin_required\","},{"line_number":115,"context_line":"    \"identity:revoke_system_grant_for_user\": \"rule:admin_required\","}],"source_content_type":"application/json","patch_set":3,"id":"df87a7cf_97a9a57c","line":112,"updated":"2017-12-04 20:23:29.000000000","message":"these should be cloud_admin","commit_id":"573cc46b2a3bab817c14983bba3d189927de5961"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"e6c3e97a808e9503c1f672353e52343805f80be1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"identity:list_role_inference_rules\": \"rule:cloud_admin\","},{"line_number":110,"context_line":"    \"identity:check_implied_role\": \"rule:cloud_admin or rule:admin_and_matching_prior_role_domain_id\","},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    \"identity:list_system_grants_for_user\": \"rule:admin_required\","},{"line_number":113,"context_line":"    \"identity:check_system_grant_for_user\": \"rule:admin_required\","},{"line_number":114,"context_line":"    \"identity:create_system_grant_for_user\": \"rule:admin_required\","},{"line_number":115,"context_line":"    \"identity:revoke_system_grant_for_user\": \"rule:admin_required\","},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    \"identity:check_grant\": \"rule:cloud_admin or rule:domain_admin_for_grants or rule:project_admin_for_grants\","},{"line_number":118,"context_line":"    \"identity:list_grants\": \"rule:cloud_admin or rule:domain_admin_for_list_grants or rule:project_admin_for_list_grants\","}],"source_content_type":"application/json","patch_set":7,"id":"bf8cb3f7_3119d6d6","line":115,"range":{"start_line":112,"start_character":4,"end_line":115,"end_character":67},"updated":"2017-12-21 20:41:54.000000000","message":"cloud_admin vs just admin?","commit_id":"616542a05167e98bfa6a9088436baa2ee8d73d3a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ff58d0443461815a666c2333f6df81279ba69d67","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"identity:list_role_inference_rules\": \"rule:cloud_admin\","},{"line_number":110,"context_line":"    \"identity:check_implied_role\": \"rule:cloud_admin or rule:admin_and_matching_prior_role_domain_id\","},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    \"identity:list_system_grants_for_user\": \"rule:admin_required\","},{"line_number":113,"context_line":"    \"identity:check_system_grant_for_user\": \"rule:admin_required\","},{"line_number":114,"context_line":"    \"identity:create_system_grant_for_user\": \"rule:admin_required\","},{"line_number":115,"context_line":"    \"identity:revoke_system_grant_for_user\": \"rule:admin_required\","},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    \"identity:check_grant\": \"rule:cloud_admin or rule:domain_admin_for_grants or rule:project_admin_for_grants\","},{"line_number":118,"context_line":"    \"identity:list_grants\": \"rule:cloud_admin or rule:domain_admin_for_list_grants or rule:project_admin_for_list_grants\","}],"source_content_type":"application/json","patch_set":7,"id":"bf8cb3f7_71043e18","line":115,"range":{"start_line":112,"start_character":4,"end_line":115,"end_character":67},"in_reply_to":"bf8cb3f7_3119d6d6","updated":"2017-12-21 20:51:12.000000000","message":"We\u0027re associating scope_types to each of these in this patch too, which hard-codes the scope to the \u0027system\u0027 level. This is pretty much the equivalent of the cloud_admin role, but not defining it as a rule.","commit_id":"616542a05167e98bfa6a9088436baa2ee8d73d3a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31a105bba57a3072a5906221f3ab45ddb10d0a2d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"identity:list_role_inference_rules\": \"rule:cloud_admin\","},{"line_number":110,"context_line":"    \"identity:check_implied_role\": \"rule:cloud_admin or rule:admin_and_matching_prior_role_domain_id\","},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    \"identity:list_system_grants_for_user\": \"rule:admin_required\","},{"line_number":113,"context_line":"    \"identity:check_system_grant_for_user\": \"rule:admin_required\","},{"line_number":114,"context_line":"    \"identity:create_system_grant_for_user\": \"rule:admin_required\","},{"line_number":115,"context_line":"    \"identity:revoke_system_grant_for_user\": \"rule:admin_required\","},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    \"identity:check_grant\": \"rule:cloud_admin or rule:domain_admin_for_grants or rule:project_admin_for_grants\","},{"line_number":118,"context_line":"    \"identity:list_grants\": \"rule:cloud_admin or rule:domain_admin_for_list_grants or rule:project_admin_for_list_grants\","}],"source_content_type":"application/json","patch_set":7,"id":"bf8cb3f7_e3d16559","line":115,"range":{"start_line":112,"start_character":4,"end_line":115,"end_character":67},"in_reply_to":"bf8cb3f7_43b5b130","updated":"2017-12-21 21:01:23.000000000","message":"So are you advocating that we just keep these as cloud_admin for consistency?","commit_id":"616542a05167e98bfa6a9088436baa2ee8d73d3a"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"2719e936da7f20501968f1b985445d96172f960d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"identity:list_role_inference_rules\": \"rule:cloud_admin\","},{"line_number":110,"context_line":"    \"identity:check_implied_role\": \"rule:cloud_admin or rule:admin_and_matching_prior_role_domain_id\","},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    \"identity:list_system_grants_for_user\": \"rule:admin_required\","},{"line_number":113,"context_line":"    \"identity:check_system_grant_for_user\": \"rule:admin_required\","},{"line_number":114,"context_line":"    \"identity:create_system_grant_for_user\": \"rule:admin_required\","},{"line_number":115,"context_line":"    \"identity:revoke_system_grant_for_user\": \"rule:admin_required\","},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    \"identity:check_grant\": \"rule:cloud_admin or rule:domain_admin_for_grants or rule:project_admin_for_grants\","},{"line_number":118,"context_line":"    \"identity:list_grants\": \"rule:cloud_admin or rule:domain_admin_for_list_grants or rule:project_admin_for_list_grants\","}],"source_content_type":"application/json","patch_set":7,"id":"bf8cb3f7_43b5b130","line":115,"range":{"start_line":112,"start_character":4,"end_line":115,"end_character":67},"in_reply_to":"bf8cb3f7_71043e18","updated":"2017-12-21 20:58:44.000000000","message":"Yes, but we\u0027re making system scope optional at first through a configuration setting. So cloud_admin and admin are different, at least at first, regardless of scope.","commit_id":"616542a05167e98bfa6a9088436baa2ee8d73d3a"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"6da4cfa387aa7cbe8d6bb192564001482e97173e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"identity:list_role_inference_rules\": \"rule:cloud_admin\","},{"line_number":110,"context_line":"    \"identity:check_implied_role\": \"rule:cloud_admin or rule:admin_and_matching_prior_role_domain_id\","},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    \"identity:list_system_grants_for_user\": \"rule:admin_required\","},{"line_number":113,"context_line":"    \"identity:check_system_grant_for_user\": \"rule:admin_required\","},{"line_number":114,"context_line":"    \"identity:create_system_grant_for_user\": \"rule:admin_required\","},{"line_number":115,"context_line":"    \"identity:revoke_system_grant_for_user\": \"rule:admin_required\","},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    \"identity:check_grant\": \"rule:cloud_admin or rule:domain_admin_for_grants or rule:project_admin_for_grants\","},{"line_number":118,"context_line":"    \"identity:list_grants\": \"rule:cloud_admin or rule:domain_admin_for_list_grants or rule:project_admin_for_list_grants\","}],"source_content_type":"application/json","patch_set":7,"id":"bf8cb3f7_e313a5b7","line":115,"range":{"start_line":112,"start_character":4,"end_line":115,"end_character":67},"in_reply_to":"bf8cb3f7_e3d16559","updated":"2017-12-21 21:28:58.000000000","message":"Since policy in code doesn\u0027t define cloud_admin at all, admin should be fine.","commit_id":"616542a05167e98bfa6a9088436baa2ee8d73d3a"}]}
