)]}'
{"keystone/catalog/backends/sql.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95b8564aaa918c8a6d84175c3e3db95c5eb47f38","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            for attr in Region.attributes:"},{"line_number":177,"context_line":"                if attr !\u003d \u0027id\u0027:"},{"line_number":178,"context_line":"                    setattr(ref, attr, getattr(new_region, attr))"},{"line_number":179,"context_line":"            ref.extra \u003d new_region.extra"},{"line_number":180,"context_line":"            return ref.to_dict()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Services"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_36f0db67","line":179,"range":{"start_line":179,"start_character":12,"end_line":179,"end_character":40},"updated":"2017-11-21 20:42:01.000000000","message":"I don\u0027t think we want to do this. This would mean operators can update enabled (or any value in extras) without it having any other impact in the API. For example, I could update enabled to False by the region would still be usable. I feel like that would be confusing for operators. I also don\u0027t think we do this for any other entity that supports extras.","commit_id":"5fee7dd7a402dcc54ed84adbec371df98d1d70b9"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"1c817bc62945b9db305b7fef574765055be1ba08","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            for attr in Region.attributes:"},{"line_number":177,"context_line":"                if attr !\u003d \u0027id\u0027:"},{"line_number":178,"context_line":"                    setattr(ref, attr, getattr(new_region, attr))"},{"line_number":179,"context_line":"            ref.extra \u003d new_region.extra"},{"line_number":180,"context_line":"            return ref.to_dict()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Services"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_1d8a921a","line":179,"range":{"start_line":179,"start_character":12,"end_line":179,"end_character":40},"in_reply_to":"ff82abbf_36f0db67","updated":"2017-11-22 00:45:07.000000000","message":"It looks like this adds the extra values to the project response object after updating, which we do for projects[0]. I\u0027m not sure if there was a specific reason for omitting extra from catalog objects?\n\n[0] https://github.com/openstack/keystone/blob/master/keystone/resource/backends/sql.py#L260","commit_id":"5fee7dd7a402dcc54ed84adbec371df98d1d70b9"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"c71da32e1a4b139a183852e6f6035715e10fe8d4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                if attr !\u003d \u0027id\u0027:"},{"line_number":178,"context_line":"                    setattr(ref, attr, getattr(new_region, attr))"},{"line_number":179,"context_line":"            ref.extra \u003d new_region.extra"},{"line_number":180,"context_line":"            return ref.to_dict()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Services"},{"line_number":183,"context_line":"    @driver_hints.truncated"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c33dadbb","line":180,"range":{"start_line":180,"start_character":19,"end_line":180,"end_character":32},"updated":"2017-11-05 22:07:49.000000000","message":"I think you may need to add \"include_extra_dict\u003dTrue\" here like [0].\n\n[0]https://github.com/openstack/keystone/blob/master/keystone/resource/backends/sql.py#L261","commit_id":"5fee7dd7a402dcc54ed84adbec371df98d1d70b9"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"077a1b7656f93c53d9dbe6bf6687491d71e4a531","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                if attr !\u003d \u0027id\u0027:"},{"line_number":178,"context_line":"                    setattr(ref, attr, getattr(new_region, attr))"},{"line_number":179,"context_line":"            ref.extra \u003d new_region.extra"},{"line_number":180,"context_line":"            return ref.to_dict()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Services"},{"line_number":183,"context_line":"    @driver_hints.truncated"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_b89b0f16","line":180,"range":{"start_line":180,"start_character":19,"end_line":180,"end_character":32},"in_reply_to":"1f485f77_38cf1f57","updated":"2017-11-16 22:37:09.000000000","message":"This might not need it, from the previous comment it looks like only User and Project take advantage of \"include_extra_dict\u003dTrue\".  I\u0027m not sure of the history behind it other than it looks like it\u0027s a backwards compatibility fix.","commit_id":"5fee7dd7a402dcc54ed84adbec371df98d1d70b9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a302f31eb5264323260ebd045f4a33dbd100c6a2","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                if attr !\u003d \u0027id\u0027:"},{"line_number":178,"context_line":"                    setattr(ref, attr, getattr(new_region, attr))"},{"line_number":179,"context_line":"            ref.extra \u003d new_region.extra"},{"line_number":180,"context_line":"            return ref.to_dict()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # Services"},{"line_number":183,"context_line":"    @driver_hints.truncated"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_38cf1f57","line":180,"range":{"start_line":180,"start_character":19,"end_line":180,"end_character":32},"in_reply_to":"3f4b6375_c33dadbb","updated":"2017-11-16 22:30:20.000000000","message":"+1","commit_id":"5fee7dd7a402dcc54ed84adbec371df98d1d70b9"}],"releasenotes/notes/bug-1729933-4a09201e9dface2a.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2dda2529b66b8483e08c38548ac6c45fc33bd08f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The Region Update API now correctly updates extra values. Previously"},{"line_number":6,"context_line":"    adding any extra values to a region via the update API would discard"},{"line_number":7,"context_line":"    any added values besides the default ones. Any extra values are now"},{"line_number":8,"context_line":"    correctly added and returned."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_899a7b0f","line":8,"updated":"2018-11-07 22:53:52.000000000","message":"Can we add that this change was only for the sake of consistency with other places in keystone that use `extra` and that we still highly discourage the use of `extra` anywhere?","commit_id":"1da2e01f35d5cd6fd5546ca4da680f8058b80553"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"6b58dea5de04fee34924b500462bc91fdf17bbad","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The Region Update API now correctly updates extra values. Previously"},{"line_number":6,"context_line":"    adding any extra values to a region via the update API would discard"},{"line_number":7,"context_line":"    any added values besides the default ones. Any extra values are now"},{"line_number":8,"context_line":"    correctly added and returned."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_496ea3fe","line":8,"in_reply_to":"3f79a3b5_899a7b0f","updated":"2018-11-07 22:58:00.000000000","message":"Done","commit_id":"1da2e01f35d5cd6fd5546ca4da680f8058b80553"}]}