)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"83b23485e34cd82e1526b5d21a572056070d4d97","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"# Seconds to wait for a response from a call. (integer value)"},{"line_number":401,"context_line":"#rpc_response_timeout \u003d 60"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"# The network address and optional user credentials for connecting to the"},{"line_number":404,"context_line":"# messaging backend, in URL format. The expected format is:"},{"line_number":405,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1f485f77_bef4b65c","line":402,"updated":"2017-11-10 12:26:39.000000000","message":"Is that an unrelated change? maybe some bad rebase?","commit_id":"851373c57c1d28948a927c014511c36afcd63472"}],"keystone/common/authorization.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"72c7496a77b0a6cead4997fdf93484bcb83c1bf1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"It is a dictionary with the following attributes:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ``token``: Token from the request"},{"line_number":45,"context_line":"* ``user_id``: user ID of the principal"},{"line_number":46,"context_line":"* ``user_domain_id`` (optional): Domain ID of the principal if the principal"},{"line_number":47,"context_line":"                                 has a domain."},{"line_number":48,"context_line":"* ``project_id`` (optional): project ID of the scoped project if auth is"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_22af9b95","line":45,"updated":"2017-11-09 16:11:28.000000000","message":"Shouldn\u0027t we have that parameters described here as well?","commit_id":"7052ee9ed7198a311d50cb262d899c83a3214560"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4b92be102617b9cb751af638f276903986e83685","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        auth_context[\u0027project_name\u0027] \u003d token.project_name"},{"line_number":97,"context_line":"        auth_context[\u0027project_domain_id\u0027] \u003d token.project_domain_id"},{"line_number":98,"context_line":"        auth_context[\u0027project_domain_name\u0027] \u003d token.project_domain_name"},{"line_number":99,"context_line":"        auth_context[\u0027is_domain\u0027] \u003d token.is_domain"},{"line_number":100,"context_line":"    elif token.domain_scoped:"},{"line_number":101,"context_line":"        auth_context[\u0027domain_id\u0027] \u003d token.domain_id"},{"line_number":102,"context_line":"        auth_context[\u0027domain_name\u0027] \u003d token.domain_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_f0c69749","line":99,"updated":"2017-11-14 13:20:12.000000000","message":"It looks like we have a test class for this method [0]. It should be pretty straight-forward, but we can add a test that ensures \u0027user_name\u0027 and \u0027user_domain_name\u0027 are always in the context. We can also amend the project-scoped token tests to ensure \u0027project_name\u0027 and \u0027project_domain_name\u0027 are also populated.\n\nThis should give us some protection against regression.\n\n[0] https://github.com/openstack/keystone/blob/a6c4b75e1b2878f1966b481936bc68067ab63243/keystone/tests/unit/common/test_authorization.py","commit_id":"04f361b7a28112abf024d3a1788406f2f268448a"},{"author":{"_account_id":25273,"name":"zhengliuyang","email":"hfzhengliuyang@163.com","username":"zlyqqq"},"change_message_id":"9ae7c9afeeaba45d30185e442fbd860abb2e373e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                               project-scoped"},{"line_number":55,"context_line":"* ``project_domain_id`` (optional): Domain ID of the scoped project if auth is"},{"line_number":56,"context_line":"                                    project-scoped."},{"line_number":57,"context_line":"* ``project_domain_name`` (optional): Domain ID of the scoped project if auth"},{"line_number":58,"context_line":"                                      is project-scoped."},{"line_number":59,"context_line":"* ``domain_id`` (optional): domain ID of the scoped domain if auth is"},{"line_number":60,"context_line":"                            domain-scoped"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_c24797bc","line":57,"range":{"start_line":57,"start_character":45,"end_line":57,"end_character":47},"updated":"2017-11-20 12:12:20.000000000","message":"name","commit_id":"043545467d7bf71dbfc4608900ea4ffa3b7c9033"}]}
