)]}'
{"keystone/conf/security_compliance.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9b43676cec854a112bdeedef9e4b0fa9ad146f16","unresolved":false,"context_lines":[{"line_number":74,"context_line":"count which includes the new password should not greater or equal to this"},{"line_number":75,"context_line":"value. Setting the value to one (the default) disables this feature. Thus, to"},{"line_number":76,"context_line":"enable this feature, values must be greater than 1. This feature depends on"},{"line_number":77,"context_line":"the `sql` backend for the `[identity] driver`."},{"line_number":78,"context_line":"\"\"\"))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"minimum_password_age \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_928af318","line":77,"updated":"2017-11-22 18:09:11.000000000","message":"We should update the exception to be clearer since that was the original issue in the bug report.\n\nhttps://github.com/openstack/keystone/blob/master/keystone/exception.py#L107-L110","commit_id":"a76b4e96e58f81a8ecc1647af73dbd6b23aca277"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"12a92a589945bdbe06fb70b59d0b9541962db1d4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":72,"context_line":"This controls the number of previous user password iterations to keep in"},{"line_number":73,"context_line":"history, in order to enforce that newly created passwords are unique. The total"},{"line_number":74,"context_line":"number which includes the new password should not greater or equal to this"},{"line_number":75,"context_line":"value. Setting the value to one (the default) disables this feature. Thus, to"},{"line_number":76,"context_line":"enable this feature, values must be greater than 1. This feature depends on"},{"line_number":77,"context_line":"the `sql` backend for the `[identity] driver`."}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_ea700ddf","line":74,"range":{"start_line":74,"start_character":46,"end_line":74,"end_character":49},"updated":"2017-11-23 14:30:58.000000000","message":"not be*","commit_id":"936f2923898fef626223ab0e345c0a7a43527567"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a79341e828724635bfa4e40078b52db6c2f46538","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":72,"context_line":"This controls the number of previous user password iterations to keep in"},{"line_number":73,"context_line":"history, in order to enforce that newly created passwords are unique. The total"},{"line_number":74,"context_line":"number which includes the new password should not greater or equal to this"},{"line_number":75,"context_line":"value. Setting the value to one (the default) disables this feature. Thus, to"},{"line_number":76,"context_line":"enable this feature, values must be greater than 1. This feature depends on"},{"line_number":77,"context_line":"the `sql` backend for the `[identity] driver`."}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_9f3bbae9","line":74,"range":{"start_line":74,"start_character":46,"end_line":74,"end_character":49},"in_reply_to":"ff82abbf_ea700ddf","updated":"2017-11-24 00:52:02.000000000","message":"Done","commit_id":"936f2923898fef626223ab0e345c0a7a43527567"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2faba35a36da4247e3308f3c026e1b4ec19f4b99","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    default\u003d1,"},{"line_number":70,"context_line":"    min\u003d1,"},{"line_number":71,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":72,"context_line":"This controls the number of previous user password iterations to keep in"},{"line_number":73,"context_line":"history, in order to enforce that newly created passwords are unique. The total"},{"line_number":74,"context_line":"number which includes the new password should not be greater or equal to this"},{"line_number":75,"context_line":"value. Setting the value to one (the default) disables this feature. Thus, to"},{"line_number":76,"context_line":"enable this feature, values must be greater than 1. This feature depends on"},{"line_number":77,"context_line":"the `sql` backend for the `[identity] driver`."},{"line_number":78,"context_line":"\"\"\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_55a42ea6","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":6},"updated":"2017-11-24 06:15:44.000000000","message":"The other config settings here seem to describe the setting in the first sentence. I think this example[0] could work, or be tweaked to work. But I would be ok with this as well, as long as it\u0027s clear that this value is equal to new password + (n-1) previous passwords.\n\n[0]\n\"The number of unique passwords a user must have before reuse, this total includes the users new password when changed. This controls the number of previous user password iterations to keep in history, in order to enforce that newly created passwords are unique. Setting the value...\"","commit_id":"49d75d668cdfd757f9e064b22d0acf1213f4b574"}],"keystone/exception.py":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2faba35a36da4247e3308f3c026e1b4ec19f4b99","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class PasswordHistoryValidationError(PasswordValidationError):"},{"line_number":107,"context_line":"    message_format \u003d _(\"The new password cannot be identical to a \""},{"line_number":108,"context_line":"                       \"previous password. The total number which\""},{"line_number":109,"context_line":"                       \"includes the new password must be unique is \""},{"line_number":110,"context_line":"                       \"%(unique_count)s.\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_d5b91ecc","line":109,"range":{"start_line":108,"start_character":43,"end_line":109,"end_character":69},"updated":"2017-11-24 06:15:44.000000000","message":"I like this.","commit_id":"49d75d668cdfd757f9e064b22d0acf1213f4b574"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"baebe190ce3622e9c1c5422000bb3d8be228a7b7","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class PasswordHistoryValidationError(PasswordValidationError):"},{"line_number":107,"context_line":"    message_format \u003d _(\"The new password cannot be identical to a \""},{"line_number":108,"context_line":"                       \"previous password. The total number which\""},{"line_number":109,"context_line":"                       \"includes the new password must be unique is \""},{"line_number":110,"context_line":"                       \"%(unique_count)s.\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_92b0818c","line":109,"range":{"start_line":108,"start_character":43,"end_line":109,"end_character":69},"in_reply_to":"ff82abbf_d5b91ecc","updated":"2017-11-24 14:48:00.000000000","message":"I think this covers that case in your previous comment?","commit_id":"49d75d668cdfd757f9e064b22d0acf1213f4b574"}],"releasenotes/notes/bug-1727099-1af277b35db34372.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"12a92a589945bdbe06fb70b59d0b9541962db1d4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1727099 \u003chttps://bugs.launchpad.net/keystone/+bug/1727099\u003e`_]"},{"line_number":5,"context_line":"    When users try to changes their password, the total number which"},{"line_number":6,"context_line":"    includes the new password should not greater or equal to"},{"line_number":7,"context_line":"    ``unique_last_password_count`` config options. But the help and error"},{"line_number":8,"context_line":"    messages for this scenario are not described clearly. Now the messges"},{"line_number":9,"context_line":"    are updated to be more clear."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff82abbf_8ab2a193","line":6,"range":{"start_line":6,"start_character":37,"end_line":6,"end_character":40},"updated":"2017-11-23 14:30:58.000000000","message":"not be*","commit_id":"936f2923898fef626223ab0e345c0a7a43527567"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"12a92a589945bdbe06fb70b59d0b9541962db1d4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1727099 \u003chttps://bugs.launchpad.net/keystone/+bug/1727099\u003e`_]"},{"line_number":5,"context_line":"    When users try to changes their password, the total number which"},{"line_number":6,"context_line":"    includes the new password should not greater or equal to"},{"line_number":7,"context_line":"    ``unique_last_password_count`` config options. But the help and error"},{"line_number":8,"context_line":"    messages for this scenario are not described clearly. Now the messges"},{"line_number":9,"context_line":"    are updated to be more clear."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff82abbf_0a645121","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":60},"updated":"2017-11-23 14:30:58.000000000","message":"to the*","commit_id":"936f2923898fef626223ab0e345c0a7a43527567"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a79341e828724635bfa4e40078b52db6c2f46538","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1727099 \u003chttps://bugs.launchpad.net/keystone/+bug/1727099\u003e`_]"},{"line_number":5,"context_line":"    When users try to changes their password, the total number which"},{"line_number":6,"context_line":"    includes the new password should not greater or equal to"},{"line_number":7,"context_line":"    ``unique_last_password_count`` config options. But the help and error"},{"line_number":8,"context_line":"    messages for this scenario are not described clearly. Now the messges"},{"line_number":9,"context_line":"    are updated to be more clear."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff82abbf_bf49de8b","line":6,"range":{"start_line":6,"start_character":37,"end_line":6,"end_character":40},"in_reply_to":"ff82abbf_8ab2a193","updated":"2017-11-24 00:52:02.000000000","message":"Done","commit_id":"936f2923898fef626223ab0e345c0a7a43527567"}]}
