)]}'
{"keystone/assignment/core.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c89c9617f7b36d5d6955e219b2772c4f87c4f6f2","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                         \"was already created\","},{"line_number":167,"context_line":"                         CONF.member_role_id)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def add_user_to_project(self, tenant_id, user_id):"},{"line_number":170,"context_line":"        \"\"\"Add user to a tenant by creating a default role relationship."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :raises keystone.exception.ProjectNotFound: If the project doesn\u0027t"},{"line_number":173,"context_line":"            exist."},{"line_number":174,"context_line":"        :raises keystone.exception.UserNotFound: If the user doesn\u0027t exist."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        self.resource_api.get_project(tenant_id)"},{"line_number":178,"context_line":"        self.ensure_default_role()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # now that default role exists, the add should succeed"},{"line_number":181,"context_line":"        self.driver.add_role_to_user_and_project("},{"line_number":182,"context_line":"            user_id,"},{"line_number":183,"context_line":"            tenant_id,"},{"line_number":184,"context_line":"            CONF.member_role_id)"},{"line_number":185,"context_line":"        COMPUTED_ASSIGNMENTS_REGION.invalidate()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @notifications.role_assignment(\u0027created\u0027)"},{"line_number":188,"context_line":"    def _add_role_to_user_and_project_adapter(self, role_id, user_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_1c6a4aed","line":185,"range":{"start_line":169,"start_character":4,"end_line":185,"end_character":47},"updated":"2017-11-24 13:05:48.000000000","message":"I think this can just be removed, it was used in the v2 API but now there\u0027s nothing that calls this method.","commit_id":"933072a0dd553c61f2631d7d2a4e10373ec3bf0a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"24e9c85d880f154f3d3d11b7918c2791a0910d11","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                         \"was already created\","},{"line_number":167,"context_line":"                         CONF.member_role_id)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def add_user_to_project(self, tenant_id, user_id):"},{"line_number":170,"context_line":"        \"\"\"Add user to a tenant by creating a default role relationship."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :raises keystone.exception.ProjectNotFound: If the project doesn\u0027t"},{"line_number":173,"context_line":"            exist."},{"line_number":174,"context_line":"        :raises keystone.exception.UserNotFound: If the user doesn\u0027t exist."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        self.resource_api.get_project(tenant_id)"},{"line_number":178,"context_line":"        self.ensure_default_role()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # now that default role exists, the add should succeed"},{"line_number":181,"context_line":"        self.driver.add_role_to_user_and_project("},{"line_number":182,"context_line":"            user_id,"},{"line_number":183,"context_line":"            tenant_id,"},{"line_number":184,"context_line":"            CONF.member_role_id)"},{"line_number":185,"context_line":"        COMPUTED_ASSIGNMENTS_REGION.invalidate()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @notifications.role_assignment(\u0027created\u0027)"},{"line_number":188,"context_line":"    def _add_role_to_user_and_project_adapter(self, role_id, user_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_1b5d5ee8","line":185,"range":{"start_line":169,"start_character":4,"end_line":185,"end_character":47},"in_reply_to":"ff82abbf_1c6a4aed","updated":"2017-11-27 08:58:04.000000000","message":"I did it here for concise review: https://review.openstack.org/#/c/523005/","commit_id":"933072a0dd553c61f2631d7d2a4e10373ec3bf0a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"fef2be7ca06417ea93dc7366900004775121a341","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            LOG.warning(\"The default _Member_ role is only used for Keystone\""},{"line_number":154,"context_line":"                        \"V2 which has been removed already. This creation step\""},{"line_number":155,"context_line":"                        \"in \u0027Keystone-manage bootstrp\u0027 will be removed in the\""},{"line_number":156,"context_line":"                        \"future. Please avoid using it any more.\")"},{"line_number":157,"context_line":"            LOG.info(\"Creating the default role %s \""},{"line_number":158,"context_line":"                     \"because it does not exist.\","},{"line_number":159,"context_line":"                     CONF.member_role_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_3bbfcdaa","line":156,"updated":"2017-11-28 20:26:10.000000000","message":"With https://review.openstack.org/#/c/523005/ and the changes in cli.py and the oslo.config deprecations I think nothing else uses this method so I don\u0027t think this warning is really needed.\n\nIf you think the warning here is important, it should identify the action that is causing the warning to be emitted (calling the method?) so that the user knows what to stop doing.","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"}],"keystone/cmd/cli.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"fef2be7ca06417ea93dc7366900004775121a341","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                  \u0027placed in during the keystone bootstrap \u0027"},{"line_number":125,"context_line":"                                  \u0027process.\u0027))"},{"line_number":126,"context_line":"        parser.add_argument(\u0027--add-member-role\u0027,"},{"line_number":127,"context_line":"                            metavar\u003d\u0027OS_ADD_MEMBER_ROLE\u0027, default\u003dTrue,"},{"line_number":128,"context_line":"                            help\u003d(\u0027Whether to create the default member role.\u0027"},{"line_number":129,"context_line":"                                  \u0027To keep the backwards compatibility, the\u0027"},{"line_number":130,"context_line":"                                  \u0027default value is True in Queens, False\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_7bac75ec","line":127,"updated":"2017-11-28 20:26:10.000000000","message":"I think there is no need to add an environment variable equivalent here. The other OS_ variables are properties of the cloud, this is just a flag to turn on or off behavior.\n\nAlso, I don\u0027t think this is correct syntax for an argument that is just a boolean flag, you will need something like action\u003d\u0027store_true\u0027 or action\u003d\u0027store_false\u0027: https://docs.python.org/3/library/argparse.html#action\n\nProbably the default behavior should be to add the member role, so adding the flag should cause a store_false. In that case the flag should be be in the negative, so something like --no-add-member-role","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f2531ace88b5ea0561aebd31dd7266456e2b6e3b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                  \u0027placed in during the keystone bootstrap \u0027"},{"line_number":125,"context_line":"                                  \u0027process.\u0027))"},{"line_number":126,"context_line":"        parser.add_argument(\u0027--add-member-role\u0027,"},{"line_number":127,"context_line":"                            metavar\u003d\u0027OS_ADD_MEMBER_ROLE\u0027, default\u003dTrue,"},{"line_number":128,"context_line":"                            help\u003d(\u0027Whether to create the default member role.\u0027"},{"line_number":129,"context_line":"                                  \u0027To keep the backwards compatibility, the\u0027"},{"line_number":130,"context_line":"                                  \u0027default value is True in Queens, False\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_7879d0c5","line":127,"in_reply_to":"ff82abbf_7bac75ec","updated":"2017-11-30 01:36:52.000000000","message":"Done","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4a167996cb271ad6654008211c905be29287d17b","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                self.endpoints[interface] \u003d endpoint_ref[\u0027id\u0027]"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # TODO(wxy): Remove ensure_default_role in R or S release."},{"line_number":381,"context_line":"        if not CONF.command.no_add_member_role:"},{"line_number":382,"context_line":"            self.assignment_manager.ensure_default_role()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_4cc3e789","line":381,"updated":"2017-11-29 09:35:22.000000000","message":"Oops, I think I asked you to remove the warning from the ensure_default_role method because I thought there was a warning here. Could you add a warning here that users should set --no-add-member-role?","commit_id":"2de664e2fb947c7fa4004b7b78a45c149168adef"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f2531ace88b5ea0561aebd31dd7266456e2b6e3b","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                self.endpoints[interface] \u003d endpoint_ref[\u0027id\u0027]"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # TODO(wxy): Remove ensure_default_role in R or S release."},{"line_number":381,"context_line":"        if not CONF.command.no_add_member_role:"},{"line_number":382,"context_line":"            self.assignment_manager.ensure_default_role()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_3ba6c610","line":381,"in_reply_to":"ff82abbf_4cc3e789","updated":"2017-11-30 01:36:52.000000000","message":"lol, No problem","commit_id":"2de664e2fb947c7fa4004b7b78a45c149168adef"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"7f9013d2b5848cc7dce6840d4d10649e3e1aca5e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            help\u003d(\u0027The initial region_id endpoints will be \u0027"},{"line_number":124,"context_line":"                                  \u0027placed in during the keystone bootstrap \u0027"},{"line_number":125,"context_line":"                                  \u0027process.\u0027))"},{"line_number":126,"context_line":"        parser.add_argument(\u0027--no-add-member-role\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":127,"context_line":"                            help\u003d(\u0027Do not create the default member role.\u0027"},{"line_number":128,"context_line":"                                  \u0027This parameter will be removed in the\u0027"},{"line_number":129,"context_line":"                                  \u0027future and then Keystone will force stop\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_91d6c627","line":126,"updated":"2017-11-30 13:43:40.000000000","message":"I don\u0027t think this is necessary. Bootstrapping is something you only do when you\u0027re first setting things up, so there shouldn\u0027t be a backward compatability concern here. Just document that bootstrap no longer does this and be done. Even in the worst case any operator impact is in a non-production environment (still being setup, so can\u0027t be prod) and easily resolved.","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1c89fa2e62e1520f2380aef35820af82d7a92753","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            help\u003d(\u0027The initial region_id endpoints will be \u0027"},{"line_number":124,"context_line":"                                  \u0027placed in during the keystone bootstrap \u0027"},{"line_number":125,"context_line":"                                  \u0027process.\u0027))"},{"line_number":126,"context_line":"        parser.add_argument(\u0027--no-add-member-role\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":127,"context_line":"                            help\u003d(\u0027Do not create the default member role.\u0027"},{"line_number":128,"context_line":"                                  \u0027This parameter will be removed in the\u0027"},{"line_number":129,"context_line":"                                  \u0027future and then Keystone will force stop\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_ba5dd0ea","line":126,"in_reply_to":"ff82abbf_91d6c627","updated":"2017-12-06 07:05:09.000000000","message":"You are right. Bootstrap is not related to upgrade. But as \t\nColleen said, what if","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2d3b94c8b0538249e52a040a11187b5e47f8c3ff","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            help\u003d(\u0027The initial region_id endpoints will be \u0027"},{"line_number":124,"context_line":"                                  \u0027placed in during the keystone bootstrap \u0027"},{"line_number":125,"context_line":"                                  \u0027process.\u0027))"},{"line_number":126,"context_line":"        parser.add_argument(\u0027--no-add-member-role\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":127,"context_line":"                            help\u003d(\u0027Do not create the default member role.\u0027"},{"line_number":128,"context_line":"                                  \u0027This parameter will be removed in the\u0027"},{"line_number":129,"context_line":"                                  \u0027future and then Keystone will force stop\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_1a1b9c73","line":126,"in_reply_to":"ff82abbf_91d6c627","updated":"2017-12-01 01:51:20.000000000","message":"yeah, you are right. Bootstrap is not related to upgrade. As Colleen said, if there is a CI use the newest Keystone and has a private test about the member role, then it will be broken.\n\nMaybe we don\u0027t need to consider this small probability event IMO.","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"7f9013d2b5848cc7dce6840d4d10649e3e1aca5e","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                        \"into this behavior. You can create additional roles \""},{"line_number":387,"context_line":"                        \"after keystone is bootstrapped using the `openstack \""},{"line_number":388,"context_line":"                        \"role create` command.\")"},{"line_number":389,"context_line":"            self.assignment_manager.ensure_default_role()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @classmethod"},{"line_number":392,"context_line":"    def main(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_d1c44e62","line":389,"updated":"2017-11-30 13:43:40.000000000","message":"per comment above, I think we can just remove this. And the method that it calls, which is only called by one other place (add_user_to_project) which also appears to need removing (only called by test code).","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2d3b94c8b0538249e52a040a11187b5e47f8c3ff","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                        \"into this behavior. You can create additional roles \""},{"line_number":387,"context_line":"                        \"after keystone is bootstrapped using the `openstack \""},{"line_number":388,"context_line":"                        \"role create` command.\")"},{"line_number":389,"context_line":"            self.assignment_manager.ensure_default_role()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @classmethod"},{"line_number":392,"context_line":"    def main(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_97e545df","line":389,"in_reply_to":"ff82abbf_d1c44e62","updated":"2017-12-01 01:51:20.000000000","message":"add_user_to_project is removed here: https://review.openstack.org/#/c/523005/","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"}],"keystone/conf/default.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"f6c9f2fc883206bf36fcf85bb789c2758c50e20e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"bootstrap\" uses it. And maybe some consumers still use it for V3 as well."},{"line_number":29,"context_line":"Please avoid using it anymore."},{"line_number":30,"context_line":"\"\"\""},{"line_number":31,"context_line":")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"admin_token \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_3d672c28","line":31,"updated":"2017-11-23 07:32:59.000000000","message":"should be \n\"\"\")","commit_id":"23add93e79a69d49aa53f5d00e8e85e16698fd21"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"8d1dc7a2ec2dc4d3240ff23212de0ddee15e746a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that \"\"keystone-manage"},{"line_number":28,"context_line":"bootstrap\" uses it. And maybe some consumers still use it for V3 as well."},{"line_number":29,"context_line":"Please avoid using it anymore."},{"line_number":30,"context_line":"\"\"\""},{"line_number":31,"context_line":")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"admin_token \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_bbb80be5","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":1},"updated":"2017-11-24 08:05:13.000000000","message":"again, :)","commit_id":"933072a0dd553c61f2631d7d2a4e10373ec3bf0a"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"4074de66e5dc6ca22589da72741f730b0d8e2e68","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_DEPRECATE_MEMBER_ID_AND_NAME \u003d utils.fmt(\"\"\""},{"line_number":26,"context_line":"This option has been deprecated because it\u0027s only used for Keystone V2 which is"},{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that \"\"keystone-manage"},{"line_number":28,"context_line":"bootstrap\" uses it. And maybe some consumers still use it for V3 as well."},{"line_number":29,"context_line":"Please avoid using it anymore."},{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_c6e67d45","line":28,"range":{"start_line":27,"start_character":57,"end_line":28,"end_character":18},"updated":"2017-12-05 19:49:13.000000000","message":"no, it\u0027s because role creation may use it. Should make it clear that role creation will no longer use these in a future release.","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1c89fa2e62e1520f2380aef35820af82d7a92753","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_DEPRECATE_MEMBER_ID_AND_NAME \u003d utils.fmt(\"\"\""},{"line_number":26,"context_line":"This option has been deprecated because it\u0027s only used for Keystone V2 which is"},{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that \"\"keystone-manage"},{"line_number":28,"context_line":"bootstrap\" uses it. And maybe some consumers still use it for V3 as well."},{"line_number":29,"context_line":"Please avoid using it anymore."},{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_e46ff08f","line":28,"range":{"start_line":27,"start_character":57,"end_line":28,"end_character":18},"in_reply_to":"df87a7cf_c6e67d45","updated":"2017-12-06 07:05:09.000000000","message":"Done","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5f647c1cf79c3076fe40cee62a2bf4964b5a439c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"This option has been deprecated because it\u0027s only used for Keystone V2 which is"},{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that \"\"keystone-manage"},{"line_number":28,"context_line":"bootstrap\" uses it. And maybe some consumers still use it for V3 as well."},{"line_number":29,"context_line":"Please avoid using it anymore."},{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_931af97a","line":29,"updated":"2017-12-05 19:42:07.000000000","message":"We could add to this saying when we plan to remove it. Which should be Queens +2 I think?","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1c89fa2e62e1520f2380aef35820af82d7a92753","unresolved":false,"context_lines":[{"line_number":26,"context_line":"This option has been deprecated because it\u0027s only used for Keystone V2 which is"},{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that \"\"keystone-manage"},{"line_number":28,"context_line":"bootstrap\" uses it. And maybe some consumers still use it for V3 as well."},{"line_number":29,"context_line":"Please avoid using it anymore."},{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_c4742c6b","line":29,"in_reply_to":"df87a7cf_931af97a","updated":"2017-12-06 07:05:09.000000000","message":"Done","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"03e6bfc8c4c01f11532f4c9c127d71265a3c8f4a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_DEPRECATE_MEMBER_ID_AND_NAME \u003d utils.fmt(\"\"\""},{"line_number":26,"context_line":"This option has been deprecated because it\u0027s only used for Keystone V2 which is"},{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that maybe some consumers"},{"line_number":28,"context_line":"still use it for V3 via the API of creating role. Please avoid using it"},{"line_number":29,"context_line":"anymore. It will be removed in S release."},{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"df87a7cf_de9b4f15","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":41},"updated":"2017-12-08 16:48:07.000000000","message":"I would be more explicit about that it was for and what action the admin might need to take. Something like:\n\nThis option was used to create a default member role for keystone v2 role assignments, but with the removal of the v2 API it is no longer necessary to create this default role. This option is deprecated and will be removed in the S release. If you are depending on having a predictable role name and ID for this member role you will need to update your tooling.","commit_id":"ca794155f1751d8a1c3acbca9ff87e874b0d58e7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5840e835f266115d144d900a660111420851de34","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_DEPRECATE_MEMBER_ID_AND_NAME \u003d utils.fmt(\"\"\""},{"line_number":26,"context_line":"This option has been deprecated because it\u0027s only used for Keystone V2 which is"},{"line_number":27,"context_line":"already removed. Still keep it alive for the reason that maybe some consumers"},{"line_number":28,"context_line":"still use it for V3 via the API of creating role. Please avoid using it"},{"line_number":29,"context_line":"anymore. It will be removed in S release."},{"line_number":30,"context_line":"\"\"\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"df87a7cf_e6222fb9","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":41},"in_reply_to":"df87a7cf_de9b4f15","updated":"2017-12-11 03:14:41.000000000","message":"Done","commit_id":"ca794155f1751d8a1c3acbca9ff87e874b0d58e7"}],"releasenotes/notes/deprecated-as-of-queens-8ad7f826e4f08f57.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for \"keystone-manage"},{"line_number":14,"context_line":"    bootstrap\" by deafult and maybe some consumers still use them for V3."},{"line_number":15,"context_line":"    Please avoid using them any more. They will be removed in the future"},{"line_number":16,"context_line":"    realese. A new parameter called \"--add-member-role\" is added to"},{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_9b97f93a","line":14,"range":{"start_line":13,"start_character":62,"end_line":14,"end_character":14},"updated":"2017-11-28 20:25:30.000000000","message":"`keystone-manage bootstrap`","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for \"keystone-manage"},{"line_number":14,"context_line":"    bootstrap\" by deafult and maybe some consumers still use them for V3."},{"line_number":15,"context_line":"    Please avoid using them any more. They will be removed in the future"},{"line_number":16,"context_line":"    realese. A new parameter called \"--add-member-role\" is added to"},{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_7b7b1527","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":25},"updated":"2017-11-28 20:25:30.000000000","message":"default*","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    but are not removed for the reason that they are used for \"keystone-manage"},{"line_number":14,"context_line":"    bootstrap\" by deafult and maybe some consumers still use them for V3."},{"line_number":15,"context_line":"    Please avoid using them any more. They will be removed in the future"},{"line_number":16,"context_line":"    realese. A new parameter called \"--add-member-role\" is added to"},{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"},{"line_number":18,"context_line":"    its default value is True, means that the member role will be created. It"},{"line_number":19,"context_line":"    will be changed to False in Rock and will be removed together with"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_bb9afd5e","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":11},"updated":"2017-11-28 20:25:30.000000000","message":"release*","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    bootstrap\" by deafult and maybe some consumers still use them for V3."},{"line_number":15,"context_line":"    Please avoid using them any more. They will be removed in the future"},{"line_number":16,"context_line":"    realese. A new parameter called \"--add-member-role\" is added to"},{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"},{"line_number":18,"context_line":"    its default value is True, means that the member role will be created. It"},{"line_number":19,"context_line":"    will be changed to False in Rock and will be removed together with"},{"line_number":20,"context_line":"    \"member_role_id\" and \"member_role_name\" config options in R release."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_3ba6edac","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":31},"updated":"2017-11-28 20:25:30.000000000","message":"nit: use literals\n\n  `keystone-manage bootstrap --add-member-role`","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    Please avoid using them any more. They will be removed in the future"},{"line_number":16,"context_line":"    realese. A new parameter called \"--add-member-role\" is added to"},{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"},{"line_number":18,"context_line":"    its default value is True, means that the member role will be created. It"},{"line_number":19,"context_line":"    will be changed to False in Rock and will be removed together with"},{"line_number":20,"context_line":"    \"member_role_id\" and \"member_role_name\" config options in R release."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_fbbde5b6","line":18,"range":{"start_line":18,"start_character":25,"end_line":18,"end_character":29},"updated":"2017-11-28 20:25:30.000000000","message":"`True`","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    realese. A new parameter called \"--add-member-role\" is added to"},{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"},{"line_number":18,"context_line":"    its default value is True, means that the member role will be created. It"},{"line_number":19,"context_line":"    will be changed to False in Rock and will be removed together with"},{"line_number":20,"context_line":"    \"member_role_id\" and \"member_role_name\" config options in R release."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_bbb3dde8","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":28},"updated":"2017-11-28 20:25:30.000000000","message":"`False` in Rocky*","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e1de551cf92221e93674ef454cc54ef3d8e544a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \"keystone-manage bootstrap\" command. To keep the backwards compatibility,"},{"line_number":18,"context_line":"    its default value is True, means that the member role will be created. It"},{"line_number":19,"context_line":"    will be changed to False in Rock and will be removed together with"},{"line_number":20,"context_line":"    \"member_role_id\" and \"member_role_name\" config options in R release."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_dbdfc10a","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":43},"updated":"2017-11-28 20:25:30.000000000","message":"nit: use literals\n\nRocky*","commit_id":"8be94ffc4d68e614d386d70f28acf3e39bafaf14"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"7f9013d2b5848cc7dce6840d4d10649e3e1aca5e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for `keystone-manage"},{"line_number":14,"context_line":"    bootstrap` by default and maybe some consumers still use them for V3."},{"line_number":15,"context_line":"    Please avoid using them any more. A new parameter called"},{"line_number":16,"context_line":"    ``--no-add-member-role`` is added to ``keystone-manage bootstrap`` command."},{"line_number":17,"context_line":"    If this parameter is specified, the member role will not be created. It"},{"line_number":18,"context_line":"    will be removed together with ``member_role_id`` and ``member_role_name``"},{"line_number":19,"context_line":"    config options in the future."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff82abbf_11d636c5","line":19,"range":{"start_line":13,"start_character":44,"end_line":19,"end_character":33},"updated":"2017-11-30 13:43:40.000000000","message":"no, the reason they\u0027re not removed is because of https://github.com/openstack/keystone/blob/cc294b7ccdb202ef6e2f80207c037078e3080038/keystone/assignment/controllers.py#L199-L203","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1058ddd79a81468aab8d095964e7390a56b436e0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for `keystone-manage"},{"line_number":14,"context_line":"    bootstrap` by default and maybe some consumers still use them for V3."},{"line_number":15,"context_line":"    Please avoid using them any more. A new parameter called"},{"line_number":16,"context_line":"    ``--no-add-member-role`` is added to ``keystone-manage bootstrap`` command."},{"line_number":17,"context_line":"    If this parameter is specified, the member role will not be created. It"},{"line_number":18,"context_line":"    will be removed together with ``member_role_id`` and ``member_role_name``"},{"line_number":19,"context_line":"    config options in the future."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff82abbf_fcf7e98b","line":19,"range":{"start_line":13,"start_character":44,"end_line":19,"end_character":33},"in_reply_to":"ff82abbf_11d636c5","updated":"2017-11-30 14:21:15.000000000","message":"I think that really has no meaning if there is nothing calling ensure_default_role. As long as bootstrap isn\u0027t running it, there\u0027s no need to check for that conflict and you might as well let the role have whatever ID it wants.","commit_id":"11da1fe706841f83a4d7ba0e096c00f89586fc29"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5f647c1cf79c3076fe40cee62a2bf4964b5a439c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for both"},{"line_number":14,"context_line":"    `keystone-manage bootstrap` and the API of creating role. Some consumers"},{"line_number":15,"context_line":"    maybe still use them for V3. Please avoid using them any more."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df87a7cf_73497589","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":31},"updated":"2017-12-05 19:42:07.000000000","message":"``keystone-manage bootstrap`` to be consistent with the literal usage above.","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1c89fa2e62e1520f2380aef35820af82d7a92753","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for both"},{"line_number":14,"context_line":"    `keystone-manage bootstrap` and the API of creating role. Some consumers"},{"line_number":15,"context_line":"    maybe still use them for V3. Please avoid using them any more."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df87a7cf_a469e88b","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":31},"in_reply_to":"df87a7cf_46a58d03","updated":"2017-12-06 07:05:09.000000000","message":"Done","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"4074de66e5dc6ca22589da72741f730b0d8e2e68","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options are"},{"line_number":12,"context_line":"    deprecated due to the removal of Keystone V2. They are only useful for V2"},{"line_number":13,"context_line":"    but are not removed for the reason that they are used for both"},{"line_number":14,"context_line":"    `keystone-manage bootstrap` and the API of creating role. Some consumers"},{"line_number":15,"context_line":"    maybe still use them for V3. Please avoid using them any more."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df87a7cf_46a58d03","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":31},"in_reply_to":"df87a7cf_73497589","updated":"2017-12-05 19:49:13.000000000","message":"Actually this should be removed now, since the patch has been updated to remove the call that was formerly made in the keystone-manage bootstrap flow.","commit_id":"77c582f5eb5a74b7ae1d5e9f231d70076086cf4e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b56cd568bd92ca8ab9eafdb99c90dbd4d4b8d8f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    More information regarding this deprecation can be found in the `patch"},{"line_number":9,"context_line":"    \u003chttps://review.openstack.org/#/c/115423/\u003e`_ that proposed the deprecation."},{"line_number":10,"context_line":"  - \u003e"},{"line_number":11,"context_line":"    The ``member_role_id`` and ``member_role_name`` config options have been"},{"line_number":12,"context_line":"    deprecated because they are only used for Keystone V2 which is already"},{"line_number":13,"context_line":"    removed. Still keep them alive for the reason that maybe some consumers"},{"line_number":14,"context_line":"    still use it for V3 via the API of creating role. Please avoid using them"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df87a7cf_9e4abea9","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":76},"updated":"2017-12-07 20:20:49.000000000","message":"This could actually reference the bug number. Either in this specific note or in a separate note.\n\nhttps://docs.openstack.org/keystone/latest/contributor/release-notes.html","commit_id":"e63c484dac0d013ec245d7de651856f6c0d0b9c6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"03e6bfc8c4c01f11532f4c9c127d71265a3c8f4a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    deprecated because they are only used for Keystone V2 which is already"},{"line_number":14,"context_line":"    removed. Still keep them alive for the reason that maybe some consumers"},{"line_number":15,"context_line":"    still use it for V3 via the API of creating role. Please avoid using them"},{"line_number":16,"context_line":"    anymore. They will be removed in S release."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df87a7cf_de37cffe","line":16,"updated":"2017-12-08 16:48:07.000000000","message":"Same comment as on the deprecation message in conf/","commit_id":"ca794155f1751d8a1c3acbca9ff87e874b0d58e7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5840e835f266115d144d900a660111420851de34","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    deprecated because they are only used for Keystone V2 which is already"},{"line_number":14,"context_line":"    removed. Still keep them alive for the reason that maybe some consumers"},{"line_number":15,"context_line":"    still use it for V3 via the API of creating role. Please avoid using them"},{"line_number":16,"context_line":"    anymore. They will be removed in S release."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df87a7cf_c6b4cb82","line":16,"in_reply_to":"df87a7cf_de37cffe","updated":"2017-12-11 03:14:41.000000000","message":"Done","commit_id":"ca794155f1751d8a1c3acbca9ff87e874b0d58e7"}],"releasenotes/notes/removed-as-of-queens-94c04e88c08f89aa.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"03e6bfc8c4c01f11532f4c9c127d71265a3c8f4a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1728690 \u003chttps://bugs.launchpad.net/keystone/+bug/1728690\u003e`_]"},{"line_number":5,"context_line":"    The member role creation step in ``keystone-manage bootstrap`` is removed."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df87a7cf_7e43236d","line":5,"updated":"2017-12-08 16:48:07.000000000","message":"Be more explicit about what action the admin needs to take, like:\n\nThe ``bootstrap`` command will only create the admin role and will no longer create a default member role. Please create any additional roles you need after running ``bootstrap`` by using the ``openstack role create`` command.","commit_id":"ca794155f1751d8a1c3acbca9ff87e874b0d58e7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5840e835f266115d144d900a660111420851de34","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1728690 \u003chttps://bugs.launchpad.net/keystone/+bug/1728690\u003e`_]"},{"line_number":5,"context_line":"    The member role creation step in ``keystone-manage bootstrap`` is removed."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df87a7cf_c6792bc8","line":5,"in_reply_to":"df87a7cf_7e43236d","updated":"2017-12-11 03:14:41.000000000","message":"Done","commit_id":"ca794155f1751d8a1c3acbca9ff87e874b0d58e7"}]}