)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9c2be1c04a185184f68fe20c721ce8e87947198d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The groups API can be considered both `project` and `system`"},{"line_number":10,"context_line":"accessible. System administrators should be able to create new groups"},{"line_number":11,"context_line":"but if a project administrator creates a new group, it should be"},{"line_number":12,"context_line":"limited to the project the administrator is in."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icf6575e4e67f0bd72b87faf06acde1a00b3bc244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_40ccdc60","line":12,"updated":"2018-01-19 20:12:42.000000000","message":"Commit message needs an update","commit_id":"f9d3c5c73d84690d4e1a117aaad47e6fa41c260c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47e5a11b498cf55991f867f751519aef3b9f7c36","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The groups API can be considered both `project` and `system`"},{"line_number":10,"context_line":"accessible. System administrators should be able to create new groups"},{"line_number":11,"context_line":"but if a project administrator creates a new group, it should be"},{"line_number":12,"context_line":"limited to the project the administrator is in."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icf6575e4e67f0bd72b87faf06acde1a00b3bc244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_60e8f87b","line":12,"in_reply_to":"7f96bb07_40ccdc60","updated":"2018-01-19 20:21:52.000000000","message":"Done","commit_id":"f9d3c5c73d84690d4e1a117aaad47e6fa41c260c"}],"keystone/common/policies/group.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a2aaa4db0051170f19138a9a6593e84c57e87639","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":19,"context_line":"        name\u003dbase.IDENTITY % \u0027get_group\u0027,"},{"line_number":20,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":21,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":22,"context_line":"        description\u003d\u0027Show group details.\u0027,"},{"line_number":23,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/groups/{group_id}\u0027,"},{"line_number":24,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_5ef60afc","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":42},"updated":"2018-01-19 14:41:29.000000000","message":"Given the commit message, should this be \u0027system\u0027 only for now until we get code written to handle project administrators?","commit_id":"91937298837f97327b22cd129cc50c404d277930"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"8c6641f1e3f9033555a1cb81d0beacfb95160da1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":19,"context_line":"        name\u003dbase.IDENTITY % \u0027get_group\u0027,"},{"line_number":20,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":21,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":22,"context_line":"        description\u003d\u0027Show group details.\u0027,"},{"line_number":23,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/groups/{group_id}\u0027,"},{"line_number":24,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_b4d64d27","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":42},"in_reply_to":"7f96bb07_5ef60afc","updated":"2018-01-19 15:58:13.000000000","message":"I\u0027d say yes, a project admin shouldn\u0027t be able to get groups from another project they are not scoped to.","commit_id":"91937298837f97327b22cd129cc50c404d277930"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f53cbe9197b3a205abc278a562cfa91001602bb9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":19,"context_line":"        name\u003dbase.IDENTITY % \u0027get_group\u0027,"},{"line_number":20,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":21,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":22,"context_line":"        description\u003d\u0027Show group details.\u0027,"},{"line_number":23,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/groups/{group_id}\u0027,"},{"line_number":24,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_32ca4a4f","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":42},"in_reply_to":"7f96bb07_b4d64d27","updated":"2018-01-19 18:53:56.000000000","message":"Ok - I can respin this with a FIXME to add \u0027project\u0027 later on and we can track that with a bug. But for now, this will be a system-level API until we get that working.","commit_id":"91937298837f97327b22cd129cc50c404d277930"}]}
