)]}'
{"keystone/common/policies/trust.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f2d8723197df4a992a11e9ab8be64d6a98a8271e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        # I\u0027m curious if someone can fact-check me here. Trusts don\u0027t *require*"},{"line_number":22,"context_line":"        # a project when they are created, but are they useful without them? If"},{"line_number":23,"context_line":"        # trusts have a hard dependency on a project being present, then trusts"},{"line_number":24,"context_line":"        # make sense as a project-level resource."},{"line_number":25,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":26,"context_line":"        description\u003d\u0027Create trust.\u0027,"},{"line_number":27,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/OS-TRUST/trusts\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_e8687c88","line":24,"updated":"2018-01-19 13:34:42.000000000","message":"It looks like there is a bug that makes this completely break, since None gets passed in here: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/token/providers/fernet/token_formatters.py#n447\n\nIn theory this could have worked, and the user would have gotten a sort of un-scoped-trust-scoped token but that is really not very useful. project_id really should have not been made optional.\n\nIn any case I think it still kind of makes sense for these to allow system scope, same as you pointed out that an application credential might make sense as a system-scoped thing.","commit_id":"9c1a76fa44b25867ceb5245937815ee20d67476d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8cd1d59aa11dbec5fc8ecf48163a466f3a4eb071","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        # I\u0027m curious if someone can fact-check me here. Trusts don\u0027t *require*"},{"line_number":22,"context_line":"        # a project when they are created, but are they useful without them? If"},{"line_number":23,"context_line":"        # trusts have a hard dependency on a project being present, then trusts"},{"line_number":24,"context_line":"        # make sense as a project-level resource."},{"line_number":25,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":26,"context_line":"        description\u003d\u0027Create trust.\u0027,"},{"line_number":27,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/OS-TRUST/trusts\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_cbcfa127","line":24,"in_reply_to":"7f96bb07_818666db","updated":"2018-01-21 12:49:41.000000000","message":"Since the rule is TRUST_OWNER and not ADMIN_REQUIRED, and effectively trusts can\u0027t be created or used without a project, then making this project-only for now is the way to go. Currently, even an admin can\u0027t create a project for another user, so even with the admin-ness bug this isn\u0027t really a system-scoped thing.","commit_id":"9c1a76fa44b25867ceb5245937815ee20d67476d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"477584ddf8e432f68c9fb95c26f2a22d2cb23aba","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        # I\u0027m curious if someone can fact-check me here. Trusts don\u0027t *require*"},{"line_number":22,"context_line":"        # a project when they are created, but are they useful without them? If"},{"line_number":23,"context_line":"        # trusts have a hard dependency on a project being present, then trusts"},{"line_number":24,"context_line":"        # make sense as a project-level resource."},{"line_number":25,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":26,"context_line":"        description\u003d\u0027Create trust.\u0027,"},{"line_number":27,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/OS-TRUST/trusts\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_818666db","line":24,"in_reply_to":"7f96bb07_e8687c88","updated":"2018-01-19 22:25:16.000000000","message":"So should we just keep these scope_types as [\u0027project\u0027, \u0027system\u0027] and rely on the existing policy enforcement in the trust/controllers.py? \n\nDo we need a FIXME to refactor that logic now that this is landing?","commit_id":"9c1a76fa44b25867ceb5245937815ee20d67476d"}]}
