)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2085ef10174ebb3bbd3961ad242fc1682a10fa46","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Instead of making the WSGI layer know about a growing superset of"},{"line_number":15,"context_line":"authentication attributes, the context contains a link to the wsgi"},{"line_number":16,"context_line":"environment.  The environment is removed from the request dictionary"},{"line_number":17,"context_line":"to prevent ciruclar references and potential GC issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixed tests  to set environment in the context.  While this"},{"line_number":20,"context_line":"changed alot of tests, the alternative was to make the check"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FRyg%3D","line":17,"updated":"2013-11-11 20:40:21.000000000","message":"circular*?","commit_id":"0bf77dd15200d5b1b8827eebbbe0949fb24689b9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2085ef10174ebb3bbd3961ad242fc1682a10fa46","unresolved":false,"context_lines":[{"line_number":17,"context_line":"to prevent ciruclar references and potential GC issues."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixed tests  to set environment in the context.  While this"},{"line_number":20,"context_line":"changed alot of tests, the alternative was to make the check"},{"line_number":21,"context_line":"for the environment optional in the controllers.  This is not a"},{"line_number":22,"context_line":"realistic way to test.  If context[\u0027environment\u0027] it missing, a test"},{"line_number":23,"context_line":"will trigger a key_error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FRyc%3D","line":20,"updated":"2013-11-11 20:40:21.000000000","message":"(NIT): \u0027a lot\u0027","commit_id":"0bf77dd15200d5b1b8827eebbbe0949fb24689b9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e37fd4ccd35dddf1235967aa9689d21abffa316a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"realistic way to test.  If context[\u0027environment\u0027] it missing, a test"},{"line_number":23,"context_line":"will trigger a key_error."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Fixes Bug: 1241812"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I234677547204e9ddc0ab33db3e6aa8b7d959a01a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FPWM%3D","line":25,"updated":"2013-11-12 12:49:39.000000000","message":"This is not linked to the launchpad\u0027s bug page. So the recommendable commit msg should be used [1]. \n\nCloses-Bug: #1241812\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"0bf77dd15200d5b1b8827eebbbe0949fb24689b9"}],"keystone/common/wsgi.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"0f27785ff5c8c3e8ed3cd9b4cdeccf6e2ad435b9","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                try:"},{"line_number":224,"context_line":"                    del context[name]"},{"line_number":225,"context_line":"                except KeyError:"},{"line_number":226,"context_line":"                    pass"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        params.update(arg_dict)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FOgM%3D","line":226,"updated":"2013-10-21 00:41:01.000000000","message":"you can remove this then because REMOTE_USER and AUTH_TYPE can be accessed from the environment. \n\nAny reason we can\u0027t just drop the context all together and pass the request?","commit_id":"2db376d2f7c2589a6622162b0a6fb731c7854b47"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cca98b8b6effb323fd7fc6f365f13816ac744be9","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                try:"},{"line_number":224,"context_line":"                    del context[name]"},{"line_number":225,"context_line":"                except KeyError:"},{"line_number":226,"context_line":"                    pass"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        params.update(arg_dict)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Foa4%3D","line":226,"in_reply_to":"AAAATH%2F%2FOgM%3D","updated":"2013-10-31 06:40:00.000000000","message":"I agree with removing the remote_user and auth_type, we can go in and find where they are called.\n\nrenaming all the others, while do-able, might be a bit of a pain, and maybe there is a reason (not that i know of) that the entire request can\u0027t be sent","commit_id":"2db376d2f7c2589a6622162b0a6fb731c7854b47"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e37fd4ccd35dddf1235967aa9689d21abffa316a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        context[\u0027headers\u0027] \u003d dict(req.headers.iteritems())"},{"line_number":216,"context_line":"        context[\u0027path\u0027] \u003d req.environ[\u0027PATH_INFO\u0027]"},{"line_number":217,"context_line":"        params \u003d req.environ.get(PARAMS_ENV, {})"},{"line_number":218,"context_line":"        #authenticaion and authorization attributes are set as environment"},{"line_number":219,"context_line":"        #values by the container and processed by the pipeline.  the complete"},{"line_number":220,"context_line":"        #set is not yet know."},{"line_number":221,"context_line":"        context[\u0027environment\u0027] \u003d req.environ"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FPUo%3D","line":218,"updated":"2013-11-12 12:49:39.000000000","message":"authentication?","commit_id":"0bf77dd15200d5b1b8827eebbbe0949fb24689b9"}]}