)]}'
{"keystone/assignment/backends/ldap.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9d95c7b2f69816f3feff56b54611b078869cc480","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        try:"},{"line_number":452,"context_line":"            conn.modify_s(role_dn, [(ldap.MOD_DELETE,"},{"line_number":453,"context_line":"                                     self.member_attribute, user_dn)])"},{"line_number":454,"context_line":"        except ldap.NO_SUCH_OBJECT:"},{"line_number":455,"context_line":"            raise exception.RoleNotFound(message\u003d_("},{"line_number":456,"context_line":"                \u0027Cannot remove role that has not been granted, %s\u0027) %"},{"line_number":457,"context_line":"                role_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FLDU%3D","line":454,"updated":"2013-10-22 00:40:03.000000000","message":"combine these except blocks into one?\n\n  except (ldap.NO_SUCH_OBJECT, ldap.NO_SUCH_ATTRIBUTE):","commit_id":"17f2d49ebd3d215f99d90111324f8af68214e129"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e1fa7bb5373f9ac576f59cc88496517da784449a","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        except (ldap.NO_SUCH_OBJECT, ldap.NO_SUCH_ATTRIBUTE):"},{"line_number":455,"context_line":"            raise exception.RoleNotFound(message\u003d_("},{"line_number":456,"context_line":"                \u0027Cannot remove role that has not been granted, %s\u0027) %"},{"line_number":457,"context_line":"                role_id)"},{"line_number":458,"context_line":"        finally:"},{"line_number":459,"context_line":"            conn.unbind_s()"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FJVc%3D","line":457,"updated":"2013-10-22 14:35:01.000000000","message":"The changes seem fine. Not sure if the method name is correct though. The code is clearly trying to remove a role assignment, but the method name is \u0027delete_user\u0027.\n\nMay want to fix the method name at some point.","commit_id":"c6800ca1ac984c879e75826df6694d6199444ea0"}]}