)]}'
{"api-ref/source/v3-ext/federation/identity-provider/idp.inc":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5754ee7c6313c21000a9cb74dd79b72c383a5d66","unresolved":false,"context_lines":[{"line_number":6,"context_line":".. rest_method::  PUT /v3/OS-FEDERATION/identity_providers/{id}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/ext/OS-FEDERATION/1.0/rel/identity_provider``"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Normal response code: 201"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f96bb07_0b2c9045","line":9,"updated":"2018-01-22 15:49:51.000000000","message":"We could add a description here.","commit_id":"5dde0603c8128c8fa73889f24658e8a55fa7d6a6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5754ee7c6313c21000a9cb74dd79b72c383a5d66","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Status Codes"},{"line_number":50,"context_line":"~~~~~~~~~~~~"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. rest_status_code:: success status.yaml"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   - 201"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f96bb07_abcebc80","line":52,"range":{"start_line":52,"start_character":30,"end_line":52,"end_character":36},"updated":"2018-01-22 15:49:51.000000000","message":"This will need to be referenced with the path in order to pass doc tests.","commit_id":"5dde0603c8128c8fa73889f24658e8a55fa7d6a6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5754ee7c6313c21000a9cb74dd79b72c383a5d66","unresolved":false,"context_lines":[{"line_number":66,"context_line":".. rest_method::  GET /v3/OS-FEDERATION/identity_providers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/ext/OS-FEDERATION/1.0/rel/identity_providers``"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Request"},{"line_number":71,"context_line":"-------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"7f96bb07_cb1d4810","line":69,"updated":"2018-01-22 15:49:51.000000000","message":"Same comment here.","commit_id":"5dde0603c8128c8fa73889f24658e8a55fa7d6a6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"276482031c45447f81359b4b2b24e2d0efa40ee5","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/ext/OS-FEDERATION/1.0/rel/identity_provider``"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"When an identity provider is registered, any tokens generated by that identity"},{"line_number":11,"context_line":"provider will be revoked."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_e8c5d85c","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":39},"updated":"2018-02-05 11:39:36.000000000","message":"it\u0027s not correct. The token will be revoked when the idp is deleted/diabled. We should describe something here for what this API does. Such as \"register an identity provider which are used for federation authentication\".\n\nI think other English native guys can make it better here. :)","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ec089f60580225e73d646d15e9948d6e083542e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/ext/OS-FEDERATION/1.0/rel/identity_provider``"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"When an identity provider is registered, any tokens generated by that identity"},{"line_number":11,"context_line":"provider will be revoked."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_157038a5","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":39},"in_reply_to":"3fa0c359_e8c5d85c","updated":"2018-02-06 12:28:39.000000000","message":"How about \"Register an identity provider to be used to authenticate federated users.\" ?","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"276482031c45447f81359b4b2b24e2d0efa40ee5","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_status_code:: success ../v3/status.yaml"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   - 201"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Example"},{"line_number":58,"context_line":"~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_a81830d3","line":55,"updated":"2018-02-05 11:39:36.000000000","message":"according to L26. 409 should be returned at least. And 400, 401 as well.","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fdd8c093f312f482bc83946c8b764eef4816e0a7","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_status_code:: success ../v3/status.yaml"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   - 201"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Example"},{"line_number":58,"context_line":"~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_9d89ed27","line":55,"in_reply_to":"3fa0c359_a81830d3","updated":"2018-02-05 15:28:01.000000000","message":"True - there are a lot of places like this where the list isn\u0027t exactly accurate with what the API does. I know a few APIs advertise 413 for example, which keystone doesn\u0027t raise. A lot of those cases are mostly dependent on the web server used to run keystone.\n\nI agree we should fix that, but I think we can also do it in another patch dedicated to correcting all inaccurate responses for the API. Where-as this patch is only applying consistent conventions.","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"276482031c45447f81359b4b2b24e2d0efa40ee5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/ext/OS-FEDERATION/1.0/rel/identity_providers``"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"When an identity provider is listed, any tokens generated by that identity"},{"line_number":72,"context_line":"provider will be revoked."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Request"},{"line_number":75,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_08d044f7","line":72,"updated":"2018-02-05 11:39:36.000000000","message":"ditto","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ec089f60580225e73d646d15e9948d6e083542e6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/ext/OS-FEDERATION/1.0/rel/identity_providers``"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"When an identity provider is listed, any tokens generated by that identity"},{"line_number":72,"context_line":"provider will be revoked."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Request"},{"line_number":75,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_b56064d0","line":72,"in_reply_to":"3fa0c359_08d044f7","updated":"2018-02-06 12:28:39.000000000","message":"How about just \"List registered identity providers.\" ?","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"14cf7a5c7673f4ca9d2f06b9c5d79642effacb78","unresolved":false,"context_lines":[{"line_number":106,"context_line":"   :language: javascript"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Get Identity provider"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. rest_method::  GET /v3/OS-FEDERATION/identity_providers/{id}"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_bd506934","line":109,"range":{"start_line":109,"start_character":4,"end_line":109,"end_character":5},"updated":"2018-02-05 15:38:55.000000000","message":"Lower case this to be consistent with other APIs:\n\n  Get identity provider","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"276482031c45447f81359b4b2b24e2d0efa40ee5","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":".. rest_status_code:: success ../v3/status.yaml"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"   - 200"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Example"},{"line_number":239,"context_line":"~~~~~~~"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3fa0c359_c8201cfb","line":236,"updated":"2018-02-05 11:39:36.000000000","message":"400, 401","commit_id":"fd9ba1cc2ff3bed8e0427ce760303ed9f19898e1"}]}