)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5b1e60c400bf82146528cb295906701f64dcf787","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to protect against possible abuse or bloat, add a config option"},{"line_number":10,"context_line":"to set a limit on the number of application credentials a user may have."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieab33c3265fa0c0b1b1c6d586e5ea8a9a39edfb1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_9a620cad","line":11,"updated":"2018-01-23 11:53:52.000000000","message":"missed \"bp application-credentials\"\nif need a new ps.","commit_id":"396131de8acc73eace651561412ae9c25cf6c363"}],"keystone/conf/application_credential.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9247eccf513bd3d775ef2b5af8268abb4e8024ec","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    default\u003d-1,"},{"line_number":46,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":47,"context_line":"Maximum number of application credentials a user is permitted to create. A"},{"line_number":48,"context_line":"value of -1 means unlimited."},{"line_number":49,"context_line":"\"\"\"))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_2af93f7f","line":48,"updated":"2018-01-22 19:57:38.000000000","message":"We could note here that not regulating this will give uses the ability to create application credentials at will, which can bloat the keystone database and cause performance issues (or open up an opportunity for a DoS).","commit_id":"546c4597c2bbb412595a7f54ed34c58ad18bb363"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"acb65a71208af52cf261fb6ea1fea036e5d96584","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"user_limit \u003d cfg.IntOpt("},{"line_number":44,"context_line":"    \u0027user_limit\u0027,"},{"line_number":45,"context_line":"    default\u003d-1,"},{"line_number":46,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":47,"context_line":"Maximum number of application credentials a user is permitted to create. A"},{"line_number":48,"context_line":"value of -1 means unlimited. If a limit is not set, users are permitted to"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_756dc396","line":45,"updated":"2018-01-23 19:38:11.000000000","message":"Is there a sane default that we could set that is not unlimited?","commit_id":"396131de8acc73eace651561412ae9c25cf6c363"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2f201951d040b0e80c815d8a997c4316fc27f2f3","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"user_limit \u003d cfg.IntOpt("},{"line_number":44,"context_line":"    \u0027user_limit\u0027,"},{"line_number":45,"context_line":"    default\u003d-1,"},{"line_number":46,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":47,"context_line":"Maximum number of application credentials a user is permitted to create. A"},{"line_number":48,"context_line":"value of -1 means unlimited. If a limit is not set, users are permitted to"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_d51cd714","line":45,"in_reply_to":"7f96bb07_756dc396","updated":"2018-01-23 19:42:11.000000000","message":"Not really. I would only expect an operator to set this if they are having problems or anticipate problems. This is going to be used for a wide variety of applications and a wide variety of deployment types so if we set a limit we\u0027d be guessing in the dark.","commit_id":"396131de8acc73eace651561412ae9c25cf6c363"}]}