)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e2b6eba25f763548b1eb1ea83cfa050ffee5f0ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix inconsistency in using the \"enabled\" field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"enabled\" field of project and domain entities should accept only"},{"line_number":10,"context_line":"boolean values like the \"enabled\" field of user entity, so no more"},{"line_number":11,"context_line":"integer values for this field."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2B5W8%3D","line":9,"updated":"2013-11-18 21:26:50.000000000","message":"(NIT): I agree with the consistency of having the value of \u0027enabled\u0027 be a boolean but do you think we could add a little to the commit message explain *why* we should only accept boolean values?","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"e23c419b1a0710e6a1b20b5daee4cffd0eeb74c9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix inconsistency in using the \"enabled\" field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"enabled\" field of project and domain entities should accept only"},{"line_number":10,"context_line":"boolean values like the \"enabled\" field of user entity, so no more"},{"line_number":11,"context_line":"integer values for this field."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2Bz8k%3D","line":9,"in_reply_to":"AAAATn%2F%2B5W8%3D","updated":"2013-11-19 20:43:32.000000000","message":"Done","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"}],"keystone/assignment/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2e4a5031a4b011d983fa3144df2f71705c32ef4d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            self.get_domain_by_name.set(ret, self, ret[\u0027name\u0027])"},{"line_number":280,"context_line":"        return ret"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def update_domain(self, domain_id, domain_ref):"},{"line_number":283,"context_line":"        domain \u003d domain_ref.copy()"},{"line_number":284,"context_line":"        if \u0027enabled\u0027 in domain:"},{"line_number":285,"context_line":"            domain[\u0027enabled\u0027] \u003d clean.domain_enabled(domain[\u0027enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9%2Fsg%3D","line":282,"updated":"2013-12-03 17:06:56.000000000","message":"just keep \u0027domain\u0027 in the method signature -- the extra reference is unnecessary","commit_id":"d54ca38d55af5de1739a43c1b570499ce83ea8c5"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"c4f0937cbe25a066f0c32c1b305eb821d5fffaed","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            self.get_domain_by_name.set(ret, self, ret[\u0027name\u0027])"},{"line_number":280,"context_line":"        return ret"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def update_domain(self, domain_id, domain_ref):"},{"line_number":283,"context_line":"        domain \u003d domain_ref.copy()"},{"line_number":284,"context_line":"        if \u0027enabled\u0027 in domain:"},{"line_number":285,"context_line":"            domain[\u0027enabled\u0027] \u003d clean.domain_enabled(domain[\u0027enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F97%2BA%3D","line":282,"in_reply_to":"AAAATn%2F9%2Fsg%3D","updated":"2013-12-04 09:15:24.000000000","message":"I would like to keep the function without side effect :)","commit_id":"d54ca38d55af5de1739a43c1b570499ce83ea8c5"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"abf1df300177db1065b746719c73ab9c51707b10","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            self.get_domain_by_name.set(ret, self, ret[\u0027name\u0027])"},{"line_number":280,"context_line":"        return ret"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def update_domain(self, domain_id, domain_ref):"},{"line_number":283,"context_line":"        domain \u003d domain_ref.copy()"},{"line_number":284,"context_line":"        if \u0027enabled\u0027 in domain:"},{"line_number":285,"context_line":"            domain[\u0027enabled\u0027] \u003d clean.domain_enabled(domain[\u0027enabled\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F92M0%3D","line":282,"in_reply_to":"AAAATn%2F97%2BA%3D","updated":"2013-12-05 09:49:11.000000000","message":"Ohh i think i misunderstood your comment, you were only asking for change the attribute name right ? Sorry for that .","commit_id":"d54ca38d55af5de1739a43c1b570499ce83ea8c5"}],"keystone/identity/controllers.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"b67c846227111bd9d82d6a4b4cf5ded1461e6481","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if \u0027name\u0027 not in user or not user[\u0027name\u0027]:"},{"line_number":199,"context_line":"            msg \u003d _(\u0027Name field is required and cannot be empty\u0027)"},{"line_number":200,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":203,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F0VU%3D","line":200,"updated":"2013-10-28 14:50:02.000000000","message":"Why were you able to remove this check?  The clean that you added was for domain.  Or was this already redundant code?","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"0310d646cb8831f3ad9d7606966c85bac1025b25","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if \u0027name\u0027 not in user or not user[\u0027name\u0027]:"},{"line_number":199,"context_line":"            msg \u003d _(\u0027Name field is required and cannot be empty\u0027)"},{"line_number":200,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":203,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Fz9w%3D","line":200,"in_reply_to":"AAAATn%2F%2F0R8%3D","updated":"2013-10-28 16:47:50.000000000","message":"K. I looked and I agree, Thanks","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"4cb8b660cb0ef0bea54371ba0eff408ce8fe70a1","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if \u0027name\u0027 not in user or not user[\u0027name\u0027]:"},{"line_number":199,"context_line":"            msg \u003d _(\u0027Name field is required and cannot be empty\u0027)"},{"line_number":200,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":203,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F0R8%3D","line":200,"in_reply_to":"AAAATn%2F%2F0VU%3D","updated":"2013-10-28 14:58:35.000000000","message":"As far as i can tell it was a redundant code, so that\u0027s why i removed it, the create_user in identity/core.py do the same check and it\u0027s more consistent with other methods like create_project, update_project.","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"b67c846227111bd9d82d6a4b4cf5ded1461e6481","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def update_user(self, context, user_id, user):"},{"line_number":219,"context_line":"        # NOTE(termie): this is really more of a patch than a put"},{"line_number":220,"context_line":"        self.assert_admin(context)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":223,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F0VE%3D","line":220,"updated":"2013-10-28 14:50:02.000000000","message":"Why were you able to remove this check?  The clean that you added was for domain.  Or was this already redundant code?","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"4cb8b660cb0ef0bea54371ba0eff408ce8fe70a1","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def update_user(self, context, user_id, user):"},{"line_number":219,"context_line":"        # NOTE(termie): this is really more of a patch than a put"},{"line_number":220,"context_line":"        self.assert_admin(context)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":223,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F0R0%3D","line":220,"in_reply_to":"AAAATn%2F%2F0VE%3D","updated":"2013-10-28 14:58:35.000000000","message":"Same answer as above :)","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2e4a5031a4b011d983fa3144df2f71705c32ef4d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":201,"context_line":"        if \u0027enabled\u0027 in user and not isinstance(user[\u0027enabled\u0027], bool):"},{"line_number":202,"context_line":"            msg \u003d _(\u0027Enabled field must be a boolean\u0027)"},{"line_number":203,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":206,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9%2FrU%3D","side":"PARENT","line":203,"updated":"2013-12-03 17:06:56.000000000","message":"i assume this is redundant with the manager implementation, but this change seems out of scope with the rest of the patch","commit_id":"2ab2c624353067ba0989720414e5cde2d4792bcc"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"c4f0937cbe25a066f0c32c1b305eb821d5fffaed","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":201,"context_line":"        if \u0027enabled\u0027 in user and not isinstance(user[\u0027enabled\u0027], bool):"},{"line_number":202,"context_line":"            msg \u003d _(\u0027Enabled field must be a boolean\u0027)"},{"line_number":203,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":206,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9774%3D","side":"PARENT","line":203,"in_reply_to":"AAAATn%2F9%2FrU%3D","updated":"2013-12-04 09:15:24.000000000","message":"I don\u0027t see why it\u0027s not part of this patch, this code make sure that enabled is a boolean which what this patch does but the problem with this code is that it may break future changes relaying on this path (think git blame), i my self spend sometime trying to figure out where changes from bug #1110435  and #1167593 fit together, that\u0027s why i am fixing it here, thoughts ?","commit_id":"2ab2c624353067ba0989720414e5cde2d4792bcc"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"aac2800e1dadceb1ee5e288dad0c56f1636a30a1","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":201,"context_line":"        if \u0027enabled\u0027 in user and not isinstance(user[\u0027enabled\u0027], bool):"},{"line_number":202,"context_line":"            msg \u003d _(\u0027Enabled field must be a boolean\u0027)"},{"line_number":203,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        default_project_id \u003d user.pop(\u0027tenantId\u0027, None)"},{"line_number":206,"context_line":"        if default_project_id is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9iZY%3D","side":"PARENT","line":203,"in_reply_to":"AAAATn%2F9774%3D","updated":"2013-12-10 13:38:57.000000000","message":"I think this is a good reason to remove this code.","commit_id":"2ab2c624353067ba0989720414e5cde2d4792bcc"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e2b6eba25f763548b1eb1ea83cfa050ffee5f0ca","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"                   \u0027enabled\u0027: True,"},{"line_number":1786,"context_line":"                   \u0027domain_id\u0027: DEFAULT_DOMAIN_ID}"},{"line_number":1787,"context_line":"        self.assignment_api.create_project(project[\u0027id\u0027], project)"},{"line_number":1788,"context_line":"        project_ref \u003d self.identity_api.get_project(project[\u0027id\u0027])"},{"line_number":1789,"context_line":"        self.assertEqual(project_ref[\u0027enabled\u0027], True)"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"        # Strings are not valid boolean values."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B5Tg%3D","line":1788,"updated":"2013-11-18 21:26:50.000000000","message":"Failing jenkins since we don\u0027t have get_project contained within the identity.core.. Only CRUD on users, domains, and groups. \n\n\nhttps://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L293","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"e23c419b1a0710e6a1b20b5daee4cffd0eeb74c9","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"                   \u0027enabled\u0027: True,"},{"line_number":1786,"context_line":"                   \u0027domain_id\u0027: DEFAULT_DOMAIN_ID}"},{"line_number":1787,"context_line":"        self.assignment_api.create_project(project[\u0027id\u0027], project)"},{"line_number":1788,"context_line":"        project_ref \u003d self.identity_api.get_project(project[\u0027id\u0027])"},{"line_number":1789,"context_line":"        self.assertEqual(project_ref[\u0027enabled\u0027], True)"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"        # Strings are not valid boolean values."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bz5U%3D","line":1788,"in_reply_to":"AAAATn%2F%2B3lQ%3D","updated":"2013-11-19 20:43:32.000000000","message":"It wasn\u0027t :) in previous path i used identity_api but it\u0027s because of this change https://review.openstack.org/#/c/51688/ and my lack of attention while rebasing my new patch that create this problem.","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"ab33c95f685fec4a42d9809fee3a2ac0d09d467e","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"                   \u0027enabled\u0027: True,"},{"line_number":1786,"context_line":"                   \u0027domain_id\u0027: DEFAULT_DOMAIN_ID}"},{"line_number":1787,"context_line":"        self.assignment_api.create_project(project[\u0027id\u0027], project)"},{"line_number":1788,"context_line":"        project_ref \u003d self.identity_api.get_project(project[\u0027id\u0027])"},{"line_number":1789,"context_line":"        self.assertEqual(project_ref[\u0027enabled\u0027], True)"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"        # Strings are not valid boolean values."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B3lQ%3D","line":1788,"in_reply_to":"AAAATn%2F%2B5Tg%3D","updated":"2013-11-19 06:35:16.000000000","message":"Weird, it was assignment in the previous versions of the code. I wonder what made Mouad decide to change this to identity???","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"}],"keystone/tests/test_content_types.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"c8029e736351bbc9e34f3dfb8d2ec003513cf042","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            body\u003d{"},{"line_number":578,"context_line":"                \u0027user\u0027: {"},{"line_number":579,"context_line":"                    # In JSON, 0|1 are not booleans."},{"line_number":580,"context_line":"                    \u0027enabled\u0027: 0,"},{"line_number":581,"context_line":"                },"},{"line_number":582,"context_line":"            },"},{"line_number":583,"context_line":"            token\u003dtoken,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F29w%3D","line":580,"updated":"2013-10-26 19:41:10.000000000","message":"Is there a good reason why you changed the testing value from 1 to 0?  1 should have been just fine correct?","commit_id":"5ef9b9b103bdb71da6ecd8607b46ef632f108c34"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"d8955bbf3210d015fc6c9e58f063e4496e1d8bc6","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            body\u003d{"},{"line_number":578,"context_line":"                \u0027user\u0027: {"},{"line_number":579,"context_line":"                    # In JSON, 0|1 are not booleans."},{"line_number":580,"context_line":"                    \u0027enabled\u0027: 0,"},{"line_number":581,"context_line":"                },"},{"line_number":582,"context_line":"            },"},{"line_number":583,"context_line":"            token\u003dtoken,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F2jQ%3D","line":580,"in_reply_to":"AAAATn%2F%2F29w%3D","updated":"2013-10-27 10:07:51.000000000","message":"Nothing special i just wanted to keep it consistent, i.e. between create and update, and the string test tested \u0027enabled\u0027: \u0027False\u0027 so it looked to me that \u0027enabled\u0027: 0 is also appropriate.\n\nBut i can change it if it\u0027s required.","commit_id":"5ef9b9b103bdb71da6ecd8607b46ef632f108c34"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7fb86b4c7e282afa52a09ed059e5c034f878db04","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            body\u003d{"},{"line_number":578,"context_line":"                \u0027user\u0027: {"},{"line_number":579,"context_line":"                    # In JSON, 0|1 are not booleans."},{"line_number":580,"context_line":"                    \u0027enabled\u0027: 0,"},{"line_number":581,"context_line":"                },"},{"line_number":582,"context_line":"            },"},{"line_number":583,"context_line":"            token\u003dtoken,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FbBA%3D","line":580,"updated":"2013-11-06 15:45:35.000000000","message":"Why change the 1 to a 0 here?","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"591d4463435a32d42831af2ca36ee43f7480cdb7","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            body\u003d{"},{"line_number":578,"context_line":"                \u0027user\u0027: {"},{"line_number":579,"context_line":"                    # In JSON, 0|1 are not booleans."},{"line_number":580,"context_line":"                    \u0027enabled\u0027: 0,"},{"line_number":581,"context_line":"                },"},{"line_number":582,"context_line":"            },"},{"line_number":583,"context_line":"            token\u003dtoken,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FbAQ%3D","line":580,"in_reply_to":"AAAATn%2F%2FbBA%3D","updated":"2013-11-06 15:53:25.000000000","message":"The same question was asked in \"Patch set 2\" :) but i will re-answer here:\n\n\"\"\"\nNothing special i just wanted to keep it consistent, i.e. between create and update, and the string test tested \u0027enabled\u0027: \u0027False\u0027 so it looked to me that \u0027enabled\u0027: 0 is also appropriate.\n\nBut i can change it if it\u0027s required.\n\"\"\"","commit_id":"09decb0b14ec623734ac9e8c9e7d1b07e3389dbc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e2b6eba25f763548b1eb1ea83cfa050ffee5f0ca","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"        self.assertValidTenant(r.result[\u0027tenant\u0027])"},{"line_number":1334,"context_line":"        self.assertEqual(r.result[\u0027tenant\u0027].get(\u0027description\u0027), \"\")"},{"line_number":1335,"context_line":""},{"line_number":1336,"context_line":"    def test_create_project_invalid_enabled_type(self):"},{"line_number":1337,"context_line":"        # Forbidden usage of string for \u0027enabled\u0027 field in JSON and XML"},{"line_number":1338,"context_line":"        token \u003d self.get_scoped_token()"},{"line_number":1339,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B5V4%3D","line":1336,"updated":"2013-11-18 21:26:50.000000000","message":"Just out of curiosity, are there positive test cases for this situation? Or are they needed?","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"e23c419b1a0710e6a1b20b5daee4cffd0eeb74c9","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"        self.assertValidTenant(r.result[\u0027tenant\u0027])"},{"line_number":1334,"context_line":"        self.assertEqual(r.result[\u0027tenant\u0027].get(\u0027description\u0027), \"\")"},{"line_number":1335,"context_line":""},{"line_number":1336,"context_line":"    def test_create_project_invalid_enabled_type(self):"},{"line_number":1337,"context_line":"        # Forbidden usage of string for \u0027enabled\u0027 field in JSON and XML"},{"line_number":1338,"context_line":"        token \u003d self.get_scoped_token()"},{"line_number":1339,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bz4U%3D","line":1336,"in_reply_to":"AAAATn%2F%2B5V4%3D","updated":"2013-11-19 20:43:32.000000000","message":"Indirectly yes there is, like in test_backends.py test_update_project_invalid_enabled_type method.","commit_id":"92f8b60809fe806f815df18db220ca025d980a7b"}]}