)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ec2acd6ebc0233df07893298e00d773266901d60","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Skip cache specific tests if caching is disabled.  Cache should only"},{"line_number":10,"context_line":"be disabled to eliminate caching as an issue with tests, but in all"},{"line_number":11,"context_line":"cases tests should pass in either configuration.  The default is"},{"line_number":12,"context_line":"to use caching for all tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7848128aeaf3f578b89ab0b9201c45e00efecf11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2BDiQ%3D","line":12,"updated":"2013-12-03 01:16:21.000000000","message":"suggest add some docs for how to disable caching for tests.","commit_id":"99bd7673167bbbbde8152ef319b454361b9cce7d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9e4e13d2240d031add6f2f521ca857419e9185f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Skip cache specific tests if caching is disabled.  Cache should only"},{"line_number":10,"context_line":"be disabled to eliminate caching as an issue with tests, but in all"},{"line_number":11,"context_line":"cases tests should pass in either configuration.  The default is"},{"line_number":12,"context_line":"to use caching for all tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7848128aeaf3f578b89ab0b9201c45e00efecf11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2BDN4%3D","line":12,"in_reply_to":"AAAATn%2F%2BDiQ%3D","updated":"2013-12-03 02:39:55.000000000","message":"Done","commit_id":"99bd7673167bbbbde8152ef319b454361b9cce7d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"aa7e4f53f4aec3cbff0eff9e255bf3ec36c33d01","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Skip cache specific tests if caching is disabled.  Cache should only"},{"line_number":10,"context_line":"be disabled to eliminate caching as an issue with tests, but in all"},{"line_number":11,"context_line":"cases tests should pass in either configuration.  The default is"},{"line_number":12,"context_line":"to use caching for all tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To use the decorator to skip a test only if caching is disabled"},{"line_number":15,"context_line":"globally use:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATn%2F%2BAYA%3D","line":12,"updated":"2013-12-03 15:29:21.000000000","message":"I should have been clearer in the previous patch set -- how do I change the configuration from the default so that I\u0027m not using caching for any or all tests?\n\nI thought this was a feature so that I could reconfigure my local system to disable caching and run tests and have it pass rather than fail.\n\nThe decorator is already documented in its docstring.","commit_id":"2f5a1df7055b8e9958e01699a02608983553567d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c98627d0b3cd975c456b627d74f685f5d8a72eea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Skip cache specific tests if caching is disabled.  Cache should only"},{"line_number":10,"context_line":"be disabled to eliminate caching as an issue with tests, but in all"},{"line_number":11,"context_line":"cases tests should pass in either configuration.  The default is"},{"line_number":12,"context_line":"to use caching for all tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To use the decorator to skip a test only if caching is disabled"},{"line_number":15,"context_line":"globally use:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATn%2F9%2FLQ%3D","line":12,"in_reply_to":"AAAATn%2F%2BAYA%3D","updated":"2013-12-03 18:36:29.000000000","message":"Ah.  I was a bit confused.  The documentation on caching is: \nhttps://github.com/openstack/keystone/blob/master/doc/source/configuration.rst#caching-layer\n \nShould I outline placing those options in test-overrides.conf?","commit_id":"2f5a1df7055b8e9958e01699a02608983553567d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"98aac7fdbac0c8c498e54a5d81b3ff7afa18405c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Skip cache specific tests if caching is disabled.  Cache should only"},{"line_number":10,"context_line":"be disabled to eliminate caching as an issue with tests, but in all"},{"line_number":11,"context_line":"cases tests should pass in either configuration.  The default is"},{"line_number":12,"context_line":"to use caching for all tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To use the decorator to skip a test only if caching is disabled"},{"line_number":15,"context_line":"globally use:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATn%2F9%2FFg%3D","line":12,"in_reply_to":"AAAATn%2F9%2FI0%3D","updated":"2013-12-03 18:44:55.000000000","message":"Done and Done.  Will post an updated commit message in a few minutes.  Thanks!","commit_id":"2f5a1df7055b8e9958e01699a02608983553567d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9b4fde97bce12a85ee4f1cfb4fa13a1931b65ca5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Skip cache specific tests if caching is disabled.  Cache should only"},{"line_number":10,"context_line":"be disabled to eliminate caching as an issue with tests, but in all"},{"line_number":11,"context_line":"cases tests should pass in either configuration.  The default is"},{"line_number":12,"context_line":"to use caching for all tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To use the decorator to skip a test only if caching is disabled"},{"line_number":15,"context_line":"globally use:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATn%2F9%2FI0%3D","line":12,"in_reply_to":"AAAATn%2F9%2FLQ%3D","updated":"2013-12-03 18:39:57.000000000","message":"yes, just something that says you can override the caching options in test-overrides.conf is enough.","commit_id":"2f5a1df7055b8e9958e01699a02608983553567d"}],"keystone/tests/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"67e59524689bd92848037423f9ec9bb1a3677146","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fkvw%3D","line":179,"updated":"2013-11-01 03:49:57.000000000","message":"Nice, good comment.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9a37e2d999aab8305de4542c22a136bbd76ae409","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fc%2B4%3D","line":179,"updated":"2013-11-05 20:47:42.000000000","message":"Seems like this could (should?) be converted into a doc comment.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dcd313807a471c9202bf9ed2f5e61a7e070efe2a","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BpgA%3D","line":179,"updated":"2013-11-22 01:30:14.000000000","message":"not sure what \"this\" is referring to here.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7f753ecc871ac3125c7d3d4a2cdc0a2e54e9aa00","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BlpM%3D","line":179,"in_reply_to":"AAAATn%2F%2BpNY%3D","updated":"2013-11-22 19:15:24.000000000","message":"I\u0027ll reword this and make it a docstring?","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"27e56345636de0871926d6c0e9893569155f1001","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BpNY%3D","line":179,"in_reply_to":"AAAATn%2F%2BpgA%3D","updated":"2013-11-22 03:21:16.000000000","message":"Instead of being a Python comment I think all of the information here would be better as a doc comment.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dcd313807a471c9202bf9ed2f5e61a7e070efe2a","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"},{"line_number":183,"context_line":"    # is disabled in any dependant sections, skip the test."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Bpf4%3D","line":180,"updated":"2013-11-22 01:30:14.000000000","message":"not really a list since these are the positional arguments.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7f753ecc871ac3125c7d3d4a2cdc0a2e54e9aa00","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":179,"context_line":"    # NOTE(morganfainberg): this should specify any sections that the cache"},{"line_number":180,"context_line":"    # specific tests rely on (e.g. assignment) in a list.  These will be used"},{"line_number":181,"context_line":"    # to determine if the cache is enabled globally and subsequently check to"},{"line_number":182,"context_line":"    # see if cache has been explicitly disabled for the \"section\".  If cache"},{"line_number":183,"context_line":"    # is disabled in any dependant sections, skip the test."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BlpI%3D","line":180,"in_reply_to":"AAAATn%2F%2Bpf4%3D","updated":"2013-11-22 19:15:24.000000000","message":"Will fix in re-wording","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dcd313807a471c9202bf9ed2f5e61a7e070efe2a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if not CONF.cache.enabled:"},{"line_number":188,"context_line":"                raise testcase.TestSkipped(\u0027Cache globally disabled.\u0027)"},{"line_number":189,"context_line":"            for s in sections:"},{"line_number":190,"context_line":"                conf_sec \u003d getattr(CONF, s, None)"},{"line_number":191,"context_line":"                if conf_sec is not None:"},{"line_number":192,"context_line":"                    if not getattr(conf_sec, \u0027caching\u0027, True):"},{"line_number":193,"context_line":"                        raise testcase.TestSkipped(\u0027%s caching disabled.\u0027 % s)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Bpfo%3D","line":190,"updated":"2013-11-22 01:30:14.000000000","message":"seems a little dangerous to have a default here since a mistyped section name would not be caught.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7f753ecc871ac3125c7d3d4a2cdc0a2e54e9aa00","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if not CONF.cache.enabled:"},{"line_number":188,"context_line":"                raise testcase.TestSkipped(\u0027Cache globally disabled.\u0027)"},{"line_number":189,"context_line":"            for s in sections:"},{"line_number":190,"context_line":"                conf_sec \u003d getattr(CONF, s, None)"},{"line_number":191,"context_line":"                if conf_sec is not None:"},{"line_number":192,"context_line":"                    if not getattr(conf_sec, \u0027caching\u0027, True):"},{"line_number":193,"context_line":"                        raise testcase.TestSkipped(\u0027%s caching disabled.\u0027 % s)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Bln4%3D","line":190,"in_reply_to":"AAAATn%2F%2Bpfo%3D","updated":"2013-11-22 19:15:24.000000000","message":"This is mirroring the base functionality.  If the section doesn\u0027t define the caching option, we make the assumption we should cache.  Changing this logic would (in theory) necessitate a change in the common cache logic.  I\u0027m ok with that but I\u0027d rather not make that change in this test-logic-fix patchset.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ec2acd6ebc0233df07893298e00d773266901d60","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":176,"context_line":"    \"\"\"`skip_if_cache_is_disabled` is a decorator to skip a test if caching is"},{"line_number":177,"context_line":"    disabled either globally or for the specific section."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    In the code fragment:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BDiI%3D","line":176,"updated":"2013-12-03 01:16:21.000000000","message":"suggest don\u0027t copy the name, use \"This decorator\"","commit_id":"99bd7673167bbbbde8152ef319b454361b9cce7d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9e4e13d2240d031add6f2f521ca857419e9185f1","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def skip_if_cache_disabled(*sections):"},{"line_number":176,"context_line":"    \"\"\"`skip_if_cache_is_disabled` is a decorator to skip a test if caching is"},{"line_number":177,"context_line":"    disabled either globally or for the specific section."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    In the code fragment:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BDN8%3D","line":176,"in_reply_to":"AAAATn%2F%2BDiI%3D","updated":"2013-12-03 02:39:55.000000000","message":"Done","commit_id":"99bd7673167bbbbde8152ef319b454361b9cce7d"}],"keystone/tests/test_cache.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"1856896f45749c8b781f97d6efbba0b533a7555e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            return value"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        setattr(CONF.cache, \u0027enabled\u0027, True)"},{"line_number":110,"context_line":"        setattr(CONF.cache, \u0027caching\u0027, False)"},{"line_number":111,"context_line":"        cacheable_function(test_value)"},{"line_number":112,"context_line":"        cached_value \u003d cacheable_function(test_value)"},{"line_number":113,"context_line":"        self.assertFalse(cached_value.cached)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FpJQ%3D","line":110,"updated":"2013-10-31 00:35:12.000000000","message":"self.opt_in_group(\u0027cache\u0027, enabled\u003dTrue, caching\u003dFalse)\n\nand below","commit_id":"0cd90889eb3e23a480312659cd19e68d11c3afc3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4cb97a2bba9a39e882f907324d2d9c79ceedd122","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            return value"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        setattr(CONF.cache, \u0027enabled\u0027, True)"},{"line_number":110,"context_line":"        setattr(CONF.cache, \u0027caching\u0027, False)"},{"line_number":111,"context_line":"        cacheable_function(test_value)"},{"line_number":112,"context_line":"        cached_value \u003d cacheable_function(test_value)"},{"line_number":113,"context_line":"        self.assertFalse(cached_value.cached)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FlJk%3D","line":110,"in_reply_to":"AAAATn%2F%2FpJQ%3D","updated":"2013-10-31 23:48:31.000000000","message":"Done","commit_id":"0cd90889eb3e23a480312659cd19e68d11c3afc3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dcd313807a471c9202bf9ed2f5e61a7e070efe2a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        cache.configure_cache_region(self.region)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_should_cache_fn_global_cache_enabled(self):"},{"line_number":110,"context_line":"        cacheable_function \u003d self._get_cacheable_function()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.opt_in_group(\u0027cache\u0027, enabled\u003dTrue)"},{"line_number":113,"context_line":"        cacheable_function(self.test_value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BpfM%3D","line":110,"updated":"2013-11-22 01:30:14.000000000","message":"\u003c Why was the comment removed? Don\u0027t we need to test this anymore?","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7f753ecc871ac3125c7d3d4a2cdc0a2e54e9aa00","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        cache.configure_cache_region(self.region)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_should_cache_fn_global_cache_enabled(self):"},{"line_number":110,"context_line":"        cacheable_function \u003d self._get_cacheable_function()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.opt_in_group(\u0027cache\u0027, enabled\u003dTrue)"},{"line_number":113,"context_line":"        cacheable_function(self.test_value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BlpQ%3D","line":110,"in_reply_to":"AAAATn%2F%2BpfM%3D","updated":"2013-11-22 19:15:24.000000000","message":"Good catch, shouldn\u0027t be removed. will add back in.","commit_id":"68fb26ff0f9ab99fed012e21b80c3ba786171000"}]}