)]}'
{"keystone/tests/test_associate_project_endpoint_extension.conf":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9e7883467e41bddafe5d765275ad177d00889219","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[catalog]"},{"line_number":2,"context_line":"driver \u003d keystone.contrib.endpoint_filter.backends.catalog_sql.EndpointFilterCatalog"}],"source_content_type":"text/plain","patch_set":2,"id":"AAAATn%2F%2Fu7k%3D","line":2,"updated":"2013-10-29 18:43:59.000000000","message":"why this change? seems like should be a separate commit.","commit_id":"3039b7c1852a241cf13afbaa85fa27751f7cd2a3"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"fcbeaef47e3f8a42958456f0ebf89bfe9140ff12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[catalog]"},{"line_number":2,"context_line":"driver \u003d keystone.contrib.endpoint_filter.backends.catalog_sql.EndpointFilterCatalog"}],"source_content_type":"text/plain","patch_set":2,"id":"AAAATn%2F%2FuzM%3D","line":2,"in_reply_to":"AAAATn%2F%2Fu7k%3D","updated":"2013-10-29 19:16:28.000000000","message":"Once I got to the point that load_backends was only being called once per test I started seeing the test that uses this config fail.  I think that this config was previously not actually being used by the test because of the goofy setup.  I needed this changed to make my changes pass.\n\nI initially thought about making a commit before this one for only this change.  I ended up not doing that because I didn\u0027t have a failing test and I try to only make changes that make failing tests pass.  I can go have and add a single line commit if you like.","commit_id":"3039b7c1852a241cf13afbaa85fa27751f7cd2a3"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2996686cac314dce682540a0242b1cde5450e08e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[catalog]"},{"line_number":2,"context_line":"driver \u003d keystone.contrib.endpoint_filter.backends.catalog_sql.Endpoint_Filter_Catalog"}],"source_content_type":"text/plain","patch_set":8,"id":"AAAATn%2F%2FmsM%3D","side":"PARENT","line":2,"updated":"2013-10-31 15:10:44.000000000","message":"first of all: lol.\n\nsecond, is this unused? how does this change not break something?","commit_id":"013b74ff7a7ca613e18a2ef95c850cc214db3ca2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7ed67ff7ca63a1b9400d48472e5a9c15d77a60f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[catalog]"},{"line_number":2,"context_line":"driver \u003d keystone.contrib.endpoint_filter.backends.catalog_sql.Endpoint_Filter_Catalog"}],"source_content_type":"text/plain","patch_set":8,"id":"AAAATn%2F%2Fmn0%3D","side":"PARENT","line":2,"in_reply_to":"AAAATn%2F%2FmsM%3D","updated":"2013-10-31 15:24:37.000000000","message":"With this change it actually does get used.  Previously load_backend was called over and over again it the test likely ran with the wrong config.\n\nIt was a tangled mess and I didn\u0027t want to take the time to see what it was actually doing.","commit_id":"013b74ff7a7ca613e18a2ef95c850cc214db3ca2"}],"keystone/tests/test_content_types.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9e7883467e41bddafe5d765275ad177d00889219","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_public_extensions(self):"},{"line_number":109,"context_line":"        r \u003d self.public_request(path\u003d\u0027/v2.0/extensions\u0027)"},{"line_number":110,"context_line":"        self.assertValidExtensionListResponse(r,"},{"line_number":111,"context_line":"                                              extension.PUBLIC_EXTENSIONS)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_admin_extensions(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fu7E%3D","side":"PARENT","line":110,"updated":"2013-10-29 18:43:59.000000000","message":"whitespace cleanup should be done separately, see https://wiki.openstack.org/wiki/GitCommitMessages#Things_to_avoid_when_creating_commits","commit_id":"b6f471a45cbc94d3a17f54af6bcb12f07c626e9c"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"fcbeaef47e3f8a42958456f0ebf89bfe9140ff12","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_public_extensions(self):"},{"line_number":109,"context_line":"        r \u003d self.public_request(path\u003d\u0027/v2.0/extensions\u0027)"},{"line_number":110,"context_line":"        self.assertValidExtensionListResponse(r,"},{"line_number":111,"context_line":"                                              extension.PUBLIC_EXTENSIONS)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_admin_extensions(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FuzI%3D","side":"PARENT","line":110,"in_reply_to":"AAAATn%2F%2Fu7E%3D","updated":"2013-10-29 19:16:28.000000000","message":"Removed.  I have Vim map that I\u0027m use to using that fixes these things automatically.  When working on Keystone I don\u0027t use it, but it\u0027s a habit :-)","commit_id":"b6f471a45cbc94d3a17f54af6bcb12f07c626e9c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9e7883467e41bddafe5d765275ad177d00889219","unresolved":false,"context_lines":[{"line_number":746,"context_line":"    def setUp(self):"},{"line_number":747,"context_line":"        super(RestfulTestCase, self).setUp()"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        # TODO(termie): add an admin user to the fixtures and use that user"},{"line_number":750,"context_line":"        # override the fixtures, for now"},{"line_number":751,"context_line":"        self.metadata_foobar \u003d self.identity_api.add_role_to_user_and_project("},{"line_number":752,"context_line":"            self.user_foo[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fu64%3D","line":749,"updated":"2013-10-29 18:43:59.000000000","message":"now this is duplicated... I thought the goal was to remove duplication.","commit_id":"3039b7c1852a241cf13afbaa85fa27751f7cd2a3"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"fcbeaef47e3f8a42958456f0ebf89bfe9140ff12","unresolved":false,"context_lines":[{"line_number":746,"context_line":"    def setUp(self):"},{"line_number":747,"context_line":"        super(RestfulTestCase, self).setUp()"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        # TODO(termie): add an admin user to the fixtures and use that user"},{"line_number":750,"context_line":"        # override the fixtures, for now"},{"line_number":751,"context_line":"        self.metadata_foobar \u003d self.identity_api.add_role_to_user_and_project("},{"line_number":752,"context_line":"            self.user_foo[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FuyE%3D","line":749,"in_reply_to":"AAAATn%2F%2Fu64%3D","updated":"2013-10-29 19:16:28.000000000","message":"This is only a step towards where I would like to go.  The step was to fix the setup issue with these test.  I have another patch I\u0027m working on that removes both blocks and adds an admin user to use during the tests.","commit_id":"3039b7c1852a241cf13afbaa85fa27751f7cd2a3"}]}