)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"289411abd468eea8039350181c299bf1d9d935d7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Consolidate Keystone docs: federated-identity.rst"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consolidate advanced-topics/federation into admin/federated-identity.rst as most of the information is duplicate and can be merged."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I35c3d261ecf7c042c30c1272d4af85a0916515e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_2a522314","line":9,"updated":"2018-02-22 21:43:52.000000000","message":"For readability, we typically try and wrap commit messages at 70 characters.","commit_id":"8f137413e3fb460369348b915b63265db12e87fc"}],"doc/source/admin/federated-identity.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"289411abd468eea8039350181c299bf1d9d935d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* `Identity Provider (IdP)`: service that stores information about users and"},{"line_number":10,"context_line":"  groups."},{"line_number":11,"context_line":"* `SAML assertion`: contains information about a user as provided by an IdP."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"You can use federation for the Identity service (keystone) in two ways:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Supporting keystone as a :abbr:`SP (Service Provider)`: consuming identity"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_6a8a6b64","line":12,"updated":"2018-02-22 21:43:52.000000000","message":"This bit here has a little overlap with the next few lines. We can try and combine them for the sake of simplicity. It looks like both Fedeated Identity documents used different definitions. We\u0027ll need to make sure whatever set we ultimately go with, is used consistently throughout the document (since copy/pasting from the old doc might have references to the old definition).","commit_id":"8f137413e3fb460369348b915b63265db12e87fc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"289411abd468eea8039350181c299bf1d9d935d7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   created in keystone."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Support keystone as a SP"},{"line_number":66,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"To have keystone as an SP, you will need to configure"},{"line_number":69,"context_line":"keystone to accept assertions from external IdPs. Examples of external"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_0a8c0734","line":66,"updated":"2018-02-22 21:43:52.000000000","message":"This should be consolidated with the following section:\n\n  Configure Identity as a Service Provider","commit_id":"8f137413e3fb460369348b915b63265db12e87fc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"289411abd468eea8039350181c299bf1d9d935d7","unresolved":false,"context_lines":[{"line_number":172,"context_line":"      POST /auth/tokens"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Support keystone as an IdP"},{"line_number":175,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"When acting as an IdP, the primary role of keystone is"},{"line_number":178,"context_line":"to issue assertions about users owned by keystone. This is done using PySAML2."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_ca813ffd","line":175,"updated":"2018-02-22 21:43:52.000000000","message":"Same comment here as above:\n\n Configure Identity as an Identity Provider","commit_id":"8f137413e3fb460369348b915b63265db12e87fc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"289411abd468eea8039350181c299bf1d9d935d7","unresolved":false,"context_lines":[{"line_number":283,"context_line":"and another keystone is acting as the IdP. All IdPs issue"},{"line_number":284,"context_line":"assertions about the identities it owns using a `Protocol`."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Test it all out"},{"line_number":287,"context_line":"---------------"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Use keystoneauth to create a password session with the IdP, then use the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_6a410ba6","line":286,"updated":"2018-02-22 21:43:52.000000000","message":"This could be more descriptive. What are we testing? As a reader, this title doesn\u0027t really tell me what the section is about. Instead I have to read it anyway to figure out that this section is meant to showcase federated authentication from the CLI. Maybe something like:\n\n  Federated Authentication","commit_id":"8f137413e3fb460369348b915b63265db12e87fc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"289411abd468eea8039350181c299bf1d9d935d7","unresolved":false,"context_lines":[{"line_number":540,"context_line":"* ``whitelist`` does not match any assertion except those listed in the"},{"line_number":541,"context_line":"  specified value."},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"Auto-Provisioning"},{"line_number":544,"context_line":"-----------------"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"The mapping engine has the ability to aid in the auto-provisioning of resources"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_ca7b7f78","line":543,"updated":"2018-02-22 21:43:52.000000000","message":"This should probably be a child section of the Mapping rules section, since auto-provisioning is a feature built into the mapping engine and used with mappings.","commit_id":"8f137413e3fb460369348b915b63265db12e87fc"}]}