)]}'
{"keystone/common/manager.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d0bb3a8c376cee7eeaf5eaa3760df9054b87e72e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return driver_manager.driver"},{"line_number":79,"context_line":"    except stevedore.exception.NoMatches:"},{"line_number":80,"context_line":"        msg \u003d (_(\u0027Unable to find %(name)r driver in %(namespace)r.\u0027))"},{"line_number":81,"context_line":"        raise ImportError(msg % {\u0027name\u0027: driver_name, \u0027namespace\u0027: namespace})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class _TraceMeta(type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_067d971b","line":81,"updated":"2018-03-05 21:26:16.000000000","message":"Nice - I\u0027m surprised this wasn\u0027t caught sooner. We should test that providing an unsupported option actually logs what we expect.","commit_id":"873a321d9597034f75121c4daa66dce4f515e4ef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95e338993a8bfd0a3f4fae17bba8be28ef3a77fe","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return driver_manager.driver"},{"line_number":79,"context_line":"    except stevedore.exception.NoMatches:"},{"line_number":80,"context_line":"        msg \u003d (_(\u0027Unable to find %(name)r driver in %(namespace)r.\u0027))"},{"line_number":81,"context_line":"        raise ImportError(msg % {\u0027name\u0027: driver_name, \u0027namespace\u0027: namespace})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class _TraceMeta(type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_d383c755","line":81,"in_reply_to":"ff6b8bd7_067d971b","updated":"2018-03-06 23:19:21.000000000","message":"I was able to test this with - http://paste.openstack.org/show/693465/\n\nBut we should probably put it in a more generic place instead of in the token provider tests since it\u0027s no longer token specific.","commit_id":"873a321d9597034f75121c4daa66dce4f515e4ef"}],"keystone/tests/unit/token/test_common.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95e338993a8bfd0a3f4fae17bba8be28ef3a77fe","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        s \u003d common.random_urlsafe_str()"},{"line_number":23,"context_line":"        self.assertEqual(s, urllib.parse.quote_plus(s))"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_import_error_for_uuid_provider(self):"},{"line_number":26,"context_line":"        namespace \u003d \"keystone.token.provider\""},{"line_number":27,"context_line":"        driver \u003d \"uuid\""},{"line_number":28,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, provider\u003ddriver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_19342b4a","line":25,"range":{"start_line":25,"start_character":30,"end_line":25,"end_character":43},"updated":"2018-03-06 23:19:21.000000000","message":"Some people might still use a uuid provider out-of-tree. We could be more specific here by clarifying the provider that causes the exception is one that isn\u0027t installed.\n\n  def test_unsupported_provider_raises_import_error(self):\n      driver \u003d uuid.uuid4().hex\n      ...","commit_id":"d3ccb53ac1931f9ea2e9d4163585f0a8d8a206eb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95e338993a8bfd0a3f4fae17bba8be28ef3a77fe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        namespace \u003d \"keystone.token.provider\""},{"line_number":27,"context_line":"        driver \u003d \"uuid\""},{"line_number":28,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, provider\u003ddriver)"},{"line_number":29,"context_line":"        msg \u003d \"Unable to find \u0027%(driver)s\u0027 driver in \u0027%(namespace)s\u0027.\" % {"},{"line_number":30,"context_line":"            \u0027namespace\u0027: namespace, \u0027driver\u0027: driver"},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_d9cf9355","line":29,"range":{"start_line":29,"start_character":33,"end_line":29,"end_character":39},"updated":"2018-03-06 23:19:21.000000000","message":"nit: We could hardcode this string for a more clear assertion.","commit_id":"d3ccb53ac1931f9ea2e9d4163585f0a8d8a206eb"}],"releasenotes/notes/fix-uuid-driver-namespace-error-2548fa5cb398699d.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d0bb3a8c376cee7eeaf5eaa3760df9054b87e72e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix formatting of ImportError when using a driver not found in the list"},{"line_number":5,"context_line":"    of token providers."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff6b8bd7_c676bf3f","line":5,"updated":"2018-03-05 21:26:16.000000000","message":"Thanks for including a release note. We typically follow a set of conventions that make release notes easier to manage. Mainly including the bug in the release note filename and including a link to the bug in the release note so that operators can get more context if they need to.\n\nhttps://docs.openstack.org/keystone/latest/contributor/release-notes.html#release-notes-for-bugs","commit_id":"873a321d9597034f75121c4daa66dce4f515e4ef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95e338993a8bfd0a3f4fae17bba8be28ef3a77fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1753584 \u003chttps://bugs.launchpad.net/keystone/+bug/1753584\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_d9f8f37d","line":1,"updated":"2018-03-06 23:19:21.000000000","message":"We should change the name of this file to match the conventions documented here: https://docs.openstack.org/keystone/latest/contributor/release-notes.html#release-notes-for-bugs","commit_id":"d3ccb53ac1931f9ea2e9d4163585f0a8d8a206eb"}]}