)]}'
{"keystone/tests/fixtures/appserver.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9a0492e380c5d8b8172133cdca4a07aec50cab82","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"A fixture for managing an application server instance."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, config, name\u003dNone, cert\u003dNone, key\u003dNone, ca\u003dNone,"},{"line_number":37,"context_line":"                 cert_required\u003dNone, host\u003d\u0027127.0.0.1\u0027, port\u003d0):"},{"line_number":38,"context_line":"        super(AppServer, self).__init__()"},{"line_number":39,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUh0%3D","line":36,"updated":"2013-11-11 00:50:28.000000000","message":"doesn\u0027t look like you can use the default name, so suggest make it a required parameter. Also, suggest have constants for the name (either ADMIN or MAIN)","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0bb6c2f28e66832246c7213f69c533aef4c7ec94","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"A fixture for managing an application server instance."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, config, name\u003dNone, cert\u003dNone, key\u003dNone, ca\u003dNone,"},{"line_number":37,"context_line":"                 cert_required\u003dNone, host\u003d\u0027127.0.0.1\u0027, port\u003d0):"},{"line_number":38,"context_line":"        super(AppServer, self).__init__()"},{"line_number":39,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUHM%3D","line":36,"in_reply_to":"AAAATn%2F%2FUh0%3D","updated":"2013-11-11 19:25:54.000000000","message":"That is true.  I went though a series of refactoring steps where I tried not to change the existing code other than to move and transform it into a class.  I\u0027ve made this change.","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9a0492e380c5d8b8172133cdca4a07aec50cab82","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, config, name\u003dNone, cert\u003dNone, key\u003dNone, ca\u003dNone,"},{"line_number":37,"context_line":"                 cert_required\u003dNone, host\u003d\u0027127.0.0.1\u0027, port\u003d0):"},{"line_number":38,"context_line":"        super(AppServer, self).__init__()"},{"line_number":39,"context_line":"        self.config \u003d config"},{"line_number":40,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUik%3D","line":37,"updated":"2013-11-11 00:50:28.000000000","message":"should cert_required default to False?","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0bb6c2f28e66832246c7213f69c533aef4c7ec94","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, config, name\u003dNone, cert\u003dNone, key\u003dNone, ca\u003dNone,"},{"line_number":37,"context_line":"                 cert_required\u003dNone, host\u003d\u0027127.0.0.1\u0027, port\u003d0):"},{"line_number":38,"context_line":"        super(AppServer, self).__init__()"},{"line_number":39,"context_line":"        self.config \u003d config"},{"line_number":40,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUGk%3D","line":37,"in_reply_to":"AAAATn%2F%2FUik%3D","updated":"2013-11-11 19:25:54.000000000","message":"It can and probably should be so I made the change.","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9a0492e380c5d8b8172133cdca4a07aec50cab82","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._setup_SSL_if_requested()"},{"line_number":54,"context_line":"        self.server.start(key\u003d\u0027socket\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Service catalog tests need to know the port we ran on."},{"line_number":57,"context_line":"        self.port \u003d self.server.socket_info[\u0027socket\u0027][1]"},{"line_number":58,"context_line":"        self._update_config_opt()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUiE%3D","line":56,"updated":"2013-11-11 00:50:28.000000000","message":"suggest remove comment since might add new tests that need to know the port and then would have to update this comment.","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0bb6c2f28e66832246c7213f69c533aef4c7ec94","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._setup_SSL_if_requested()"},{"line_number":54,"context_line":"        self.server.start(key\u003d\u0027socket\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Service catalog tests need to know the port we ran on."},{"line_number":57,"context_line":"        self.port \u003d self.server.socket_info[\u0027socket\u0027][1]"},{"line_number":58,"context_line":"        self._update_config_opt()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUAw%3D","line":56,"in_reply_to":"AAAATn%2F%2FUiE%3D","updated":"2013-11-11 19:25:54.000000000","message":"modified the comment to be more generic","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9a0492e380c5d8b8172133cdca4a07aec50cab82","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.port \u003d self.server.socket_info[\u0027socket\u0027][1]"},{"line_number":58,"context_line":"        self._update_config_opt()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.addCleanup(self.server.kill)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _setup_SSL_if_requested(self):"},{"line_number":63,"context_line":"        # TODO(dstanek): fix environment.Server to take a SSLOpts instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUh4%3D","line":60,"updated":"2013-11-11 00:50:28.000000000","message":"should also set self.server \u003d None like the old cleanup code did?","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0bb6c2f28e66832246c7213f69c533aef4c7ec94","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.port \u003d self.server.socket_info[\u0027socket\u0027][1]"},{"line_number":58,"context_line":"        self._update_config_opt()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.addCleanup(self.server.kill)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _setup_SSL_if_requested(self):"},{"line_number":63,"context_line":"        # TODO(dstanek): fix environment.Server to take a SSLOpts instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUDE%3D","line":60,"in_reply_to":"AAAATn%2F%2FUh4%3D","updated":"2013-11-11 19:25:54.000000000","message":"No. It really doesn\u0027t provide much value at all.  Killing the server will clean up the networking resources. Reference counting should be just fine.","commit_id":"91b9c1866180d717c49ac4ac45f97f3708779325"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ff5f38c0c467700978571dd72c7b4679108fd7e3","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _setup_SSL_if_requested(self):"},{"line_number":66,"context_line":"        # TODO(dstanek): fix environment.Server to take a SSLOpts instance"},{"line_number":67,"context_line":"        # so that the params are eithe always set or not"},{"line_number":68,"context_line":"        if (self.cert is not None and"},{"line_number":69,"context_line":"                self.ca is not None and"},{"line_number":70,"context_line":"                self.key is not None):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FRqs%3D","line":67,"updated":"2013-11-11 21:20:13.000000000","message":"(NIT): either*","commit_id":"2bcdae3c38eb56140165231d4949cf71c2538bf4"}],"keystone/tests/test_ssl.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"77352c2907afb1b1e4585d107e623286f7c8d0e2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_1way_ssl_ok(self):"},{"line_number":43,"context_line":"        \"\"\"Make sure both public and admin API work with 1-way SSL.\"\"\""},{"line_number":44,"context_line":"        paste_conf \u003d self._paste_config(\u0027keystone\u0027)"},{"line_number":45,"context_line":"        ssl_kwargs \u003d dict(cert\u003dCERT, key\u003dKEY, ca\u003dCA)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Verify Admin"},{"line_number":48,"context_line":"        with appserver.AppServer(paste_conf, appserver.ADMIN, **ssl_kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B5AI%3D","line":45,"updated":"2013-11-18 22:18:52.000000000","message":"suggest making this the default and then add/change as required.  This seems copied all over below for each and every test below.","commit_id":"f3bcd2c10ac871521eed3b8515d029c115ec6cf0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"41a0f4bee7ac5ed31ce2547317195f1dc2b586cd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_1way_ssl_ok(self):"},{"line_number":43,"context_line":"        \"\"\"Make sure both public and admin API work with 1-way SSL.\"\"\""},{"line_number":44,"context_line":"        paste_conf \u003d self._paste_config(\u0027keystone\u0027)"},{"line_number":45,"context_line":"        ssl_kwargs \u003d dict(cert\u003dCERT, key\u003dKEY, ca\u003dCA)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Verify Admin"},{"line_number":48,"context_line":"        with appserver.AppServer(paste_conf, appserver.ADMIN, **ssl_kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B4WU%3D","line":45,"in_reply_to":"AAAATn%2F%2B4fA%3D","updated":"2013-11-19 01:11:43.000000000","message":"Fair enough.","commit_id":"f3bcd2c10ac871521eed3b8515d029c115ec6cf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"63fa4fb7257e7477da630264c6a644f611fc969b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test_1way_ssl_ok(self):"},{"line_number":43,"context_line":"        \"\"\"Make sure both public and admin API work with 1-way SSL.\"\"\""},{"line_number":44,"context_line":"        paste_conf \u003d self._paste_config(\u0027keystone\u0027)"},{"line_number":45,"context_line":"        ssl_kwargs \u003d dict(cert\u003dCERT, key\u003dKEY, ca\u003dCA)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # Verify Admin"},{"line_number":48,"context_line":"        with appserver.AppServer(paste_conf, appserver.ADMIN, **ssl_kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B4fA%3D","line":45,"in_reply_to":"AAAATn%2F%2B5AI%3D","updated":"2013-11-19 00:49:12.000000000","message":"These are SSL tests so it makes sense to be explicit in these options rather than have a default.","commit_id":"f3bcd2c10ac871521eed3b8515d029c115ec6cf0"}]}