)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch added description support for registered"},{"line_number":10,"context_line":"limit and project limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia2023ca809b8c2f58af648cb7377f41cd220725b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df7087c5_7bc41b93","line":11,"updated":"2018-03-19 14:52:43.000000000","message":"Closes-Bug: 1754185","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a886f073fc326afe5effb90878cd8d5cdf1eecf7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch added description support for registered"},{"line_number":10,"context_line":"limit and project limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia2023ca809b8c2f58af648cb7377f41cd220725b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df7087c5_78064b23","line":11,"in_reply_to":"df7087c5_7bc41b93","updated":"2018-03-20 10:16:47.000000000","message":"Done","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"}],"api-ref/source/v3/parameters.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":650,"context_line":"  in: body"},{"line_number":651,"context_line":"  required: true"},{"line_number":652,"context_line":"  type: string"},{"line_number":653,"context_line":"description_registred_limit_request_body:"},{"line_number":654,"context_line":"  description: |"},{"line_number":655,"context_line":"    The registred limit description."},{"line_number":656,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_cecb9e50","line":653,"range":{"start_line":653,"start_character":12,"end_line":653,"end_character":21},"updated":"2018-03-23 15:48:48.000000000","message":"registered","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":650,"context_line":"  in: body"},{"line_number":651,"context_line":"  required: true"},{"line_number":652,"context_line":"  type: string"},{"line_number":653,"context_line":"description_registred_limit_request_body:"},{"line_number":654,"context_line":"  description: |"},{"line_number":655,"context_line":"    The registred limit description."},{"line_number":656,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_34fd543a","line":653,"range":{"start_line":653,"start_character":12,"end_line":653,"end_character":21},"in_reply_to":"df7087c5_cecb9e50","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":652,"context_line":"  type: string"},{"line_number":653,"context_line":"description_registred_limit_request_body:"},{"line_number":654,"context_line":"  description: |"},{"line_number":655,"context_line":"    The registred limit description."},{"line_number":656,"context_line":"  in: body"},{"line_number":657,"context_line":"  required: false"},{"line_number":658,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_ced07efa","line":655,"range":{"start_line":655,"start_character":8,"end_line":655,"end_character":17},"updated":"2018-03-23 15:48:48.000000000","message":"registered","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":652,"context_line":"  type: string"},{"line_number":653,"context_line":"description_registred_limit_request_body:"},{"line_number":654,"context_line":"  description: |"},{"line_number":655,"context_line":"    The registred limit description."},{"line_number":656,"context_line":"  in: body"},{"line_number":657,"context_line":"  required: false"},{"line_number":658,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_54fa4842","line":655,"range":{"start_line":655,"start_character":8,"end_line":655,"end_character":17},"in_reply_to":"df7087c5_ced07efa","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":656,"context_line":"  in: body"},{"line_number":657,"context_line":"  required: false"},{"line_number":658,"context_line":"  type: string"},{"line_number":659,"context_line":"description_registred_limit_response_body:"},{"line_number":660,"context_line":"  description: |"},{"line_number":661,"context_line":"    The registred limit description."},{"line_number":662,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_aebe6aab","line":659,"range":{"start_line":659,"start_character":12,"end_line":659,"end_character":21},"updated":"2018-03-23 15:48:48.000000000","message":"registered","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":656,"context_line":"  in: body"},{"line_number":657,"context_line":"  required: false"},{"line_number":658,"context_line":"  type: string"},{"line_number":659,"context_line":"description_registred_limit_response_body:"},{"line_number":660,"context_line":"  description: |"},{"line_number":661,"context_line":"    The registred limit description."},{"line_number":662,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_f494bcea","line":659,"range":{"start_line":659,"start_character":12,"end_line":659,"end_character":21},"in_reply_to":"df7087c5_aebe6aab","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":658,"context_line":"  type: string"},{"line_number":659,"context_line":"description_registred_limit_response_body:"},{"line_number":660,"context_line":"  description: |"},{"line_number":661,"context_line":"    The registred limit description."},{"line_number":662,"context_line":"  in: body"},{"line_number":663,"context_line":"  required: true"},{"line_number":664,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_8ed606f2","line":661,"range":{"start_line":661,"start_character":8,"end_line":661,"end_character":17},"updated":"2018-03-23 15:48:48.000000000","message":"registered","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":658,"context_line":"  type: string"},{"line_number":659,"context_line":"description_registred_limit_response_body:"},{"line_number":660,"context_line":"  description: |"},{"line_number":661,"context_line":"    The registred limit description."},{"line_number":662,"context_line":"  in: body"},{"line_number":663,"context_line":"  required: true"},{"line_number":664,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_149a9013","line":661,"range":{"start_line":661,"start_character":8,"end_line":661,"end_character":17},"in_reply_to":"df7087c5_8ed606f2","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"}],"api-ref/source/v3/samples/admin/limits-create-request.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \"project_id\": \"3a705b9f56bb439381b43c4fe59dccce\","},{"line_number":13,"context_line":"            \"resource_name\": \"volume\","},{"line_number":14,"context_line":"            \"resource_limit\": 10,"},{"line_number":15,"context_line":"            \"description\": \"test description\""},{"line_number":16,"context_line":"        }"},{"line_number":17,"context_line":"    ]"},{"line_number":18,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"df7087c5_98d6d5c3","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":45},"updated":"2018-03-19 14:52:43.000000000","message":"We could update this to be more realistic with respect to the other values in the example:\n\n  \"description\": \"Number of volumes for project 3a705b9f56bb439381b43c4fe59dccce\"","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a886f073fc326afe5effb90878cd8d5cdf1eecf7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \"project_id\": \"3a705b9f56bb439381b43c4fe59dccce\","},{"line_number":13,"context_line":"            \"resource_name\": \"volume\","},{"line_number":14,"context_line":"            \"resource_limit\": 10,"},{"line_number":15,"context_line":"            \"description\": \"test description\""},{"line_number":16,"context_line":"        }"},{"line_number":17,"context_line":"    ]"},{"line_number":18,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"df7087c5_2cfe5405","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":45},"in_reply_to":"df7087c5_98d6d5c3","updated":"2018-03-20 10:16:47.000000000","message":"Done","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"}],"api-ref/source/v3/samples/admin/limits-create-response.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"project_id\": \"3a705b9f56bb439381b43c4fe59dccce\","},{"line_number":11,"context_line":"            \"id\": \"25a04c7a065c430590881c646cdcdd58\","},{"line_number":12,"context_line":"            \"resource_limit\": 10,"},{"line_number":13,"context_line":"            \"description\": \"test description\""},{"line_number":14,"context_line":"        },"},{"line_number":15,"context_line":"        {"},{"line_number":16,"context_line":"            \"resource_name\": \"snapshot\","}],"source_content_type":"application/json","patch_set":4,"id":"df7087c5_b8e8797c","line":13,"updated":"2018-03-19 14:52:43.000000000","message":"Same comment here as the previous doc. Applies to other occurrences throughout the document.","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a886f073fc326afe5effb90878cd8d5cdf1eecf7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"project_id\": \"3a705b9f56bb439381b43c4fe59dccce\","},{"line_number":11,"context_line":"            \"id\": \"25a04c7a065c430590881c646cdcdd58\","},{"line_number":12,"context_line":"            \"resource_limit\": 10,"},{"line_number":13,"context_line":"            \"description\": \"test description\""},{"line_number":14,"context_line":"        },"},{"line_number":15,"context_line":"        {"},{"line_number":16,"context_line":"            \"resource_name\": \"snapshot\","}],"source_content_type":"application/json","patch_set":4,"id":"df7087c5_0c827050","line":13,"in_reply_to":"df7087c5_b8e8797c","updated":"2018-03-20 10:16:47.000000000","message":"Done","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"}],"api-ref/source/v3/samples/admin/limits-update-request.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"id\": \"3229b3849f584faea483d6851f7aab05\","},{"line_number":9,"context_line":"            \"resource_limit\": 5,"},{"line_number":10,"context_line":"            \"description\": \"Number of snapshot for project 3a705b9f56bb439381b43c4fe59dccce\""},{"line_number":11,"context_line":"        }"},{"line_number":12,"context_line":"    ]"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"bf659307_635e5e13","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":46},"updated":"2018-04-10 15:58:22.000000000","message":"snapshots* just to be consistent with the other examples for \"volumes\"","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"id\": \"3229b3849f584faea483d6851f7aab05\","},{"line_number":9,"context_line":"            \"resource_limit\": 5,"},{"line_number":10,"context_line":"            \"description\": \"Number of snapshot for project 3a705b9f56bb439381b43c4fe59dccce\""},{"line_number":11,"context_line":"        }"},{"line_number":12,"context_line":"    ]"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"bf659307_9c242562","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":46},"in_reply_to":"bf659307_635e5e13","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"}],"api-ref/source/v3/samples/admin/limits-update-response.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \"project_id\": \"3a705b9f56bb439381b43c4fe59dccce\","},{"line_number":23,"context_line":"            \"id\": \"3229b3849f584faea483d6851f7aab05\","},{"line_number":24,"context_line":"            \"resource_limit\": 5,"},{"line_number":25,"context_line":"            \"description\": \"Number of snapshot for project 3a705b9f56bb439381b43c4fe59dccce\""},{"line_number":26,"context_line":"        }"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"bf659307_239e26b8","line":25,"range":{"start_line":25,"start_character":38,"end_line":25,"end_character":46},"updated":"2018-04-10 15:58:22.000000000","message":"snapshots*","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \"project_id\": \"3a705b9f56bb439381b43c4fe59dccce\","},{"line_number":23,"context_line":"            \"id\": \"3229b3849f584faea483d6851f7aab05\","},{"line_number":24,"context_line":"            \"resource_limit\": 5,"},{"line_number":25,"context_line":"            \"description\": \"Number of snapshot for project 3a705b9f56bb439381b43c4fe59dccce\""},{"line_number":26,"context_line":"        }"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"bf659307_fcc1a155","line":25,"range":{"start_line":25,"start_character":38,"end_line":25,"end_character":46},"in_reply_to":"bf659307_239e26b8","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"}],"keystone/limit/backends/sql.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           sql.ForeignKey(\u0027region.id\u0027), nullable\u003dTrue)"},{"line_number":44,"context_line":"    resource_name \u003d sql.Column(sql.String(255))"},{"line_number":45,"context_line":"    default_limit \u003d sql.Column(sql.Integer, nullable\u003dFalse)"},{"line_number":46,"context_line":"    description \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    __table_args__ \u003d ("},{"line_number":49,"context_line":"        sqlalchemy.UniqueConstraint(\u0027service_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_31587f2f","line":46,"range":{"start_line":46,"start_character":46,"end_line":46,"end_character":60},"updated":"2018-03-23 15:48:48.000000000","message":"Commented on the migration, not sure if this is best. Commenting again here to make sure this is followed up on to ensure it\u0027s consistent with the migration.","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           sql.ForeignKey(\u0027region.id\u0027), nullable\u003dTrue)"},{"line_number":44,"context_line":"    resource_name \u003d sql.Column(sql.String(255))"},{"line_number":45,"context_line":"    default_limit \u003d sql.Column(sql.Integer, nullable\u003dFalse)"},{"line_number":46,"context_line":"    description \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    __table_args__ \u003d ("},{"line_number":49,"context_line":"        sqlalchemy.UniqueConstraint(\u0027service_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_eee30204","line":46,"range":{"start_line":46,"start_character":29,"end_line":46,"end_character":44},"updated":"2018-03-23 15:48:48.000000000","message":"should use sql.Text()","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           sql.ForeignKey(\u0027region.id\u0027), nullable\u003dTrue)"},{"line_number":44,"context_line":"    resource_name \u003d sql.Column(sql.String(255))"},{"line_number":45,"context_line":"    default_limit \u003d sql.Column(sql.Integer, nullable\u003dFalse)"},{"line_number":46,"context_line":"    description \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    __table_args__ \u003d ("},{"line_number":49,"context_line":"        sqlalchemy.UniqueConstraint(\u0027service_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_b4b72487","line":46,"range":{"start_line":46,"start_character":29,"end_line":46,"end_character":44},"in_reply_to":"df7087c5_eee30204","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    region_id \u003d sql.Column(sql.String(64), nullable\u003dTrue)"},{"line_number":71,"context_line":"    resource_name \u003d sql.Column(sql.String(255))"},{"line_number":72,"context_line":"    resource_limit \u003d sql.Column(sql.Integer, nullable\u003dFalse)"},{"line_number":73,"context_line":"    description \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    __table_args__ \u003d ("},{"line_number":76,"context_line":"        sqlalchemy.ForeignKeyConstraint([\u0027service_id\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_0eb2f606","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":44},"updated":"2018-03-23 15:48:48.000000000","message":"sql.Text()","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"}],"keystone/limit/schema.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":107,"context_line":"    \u0027properties\u0027: _limit_update_properties,"},{"line_number":108,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":109,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027resource_limit\u0027]"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"limit_update \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_ce4abe25","side":"PARENT","line":109,"range":{"start_line":109,"start_character":23,"end_line":109,"end_character":39},"updated":"2018-03-23 15:48:48.000000000","message":"Removing this seems like an error","commit_id":"88b733215eeeaa09ec8428b76a51ff901e8909e6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":107,"context_line":"    \u0027properties\u0027: _limit_update_properties,"},{"line_number":108,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":109,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027resource_limit\u0027]"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"limit_update \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_f7fefe03","side":"PARENT","line":109,"range":{"start_line":109,"start_character":23,"end_line":109,"end_character":39},"in_reply_to":"df7087c5_ce4abe25","updated":"2018-03-26 04:17:13.000000000","message":"resource_limit is the only property can be updated previous. So it was required. But once we add \"description\". User can update either \"resource_limit\" or \"description\", so I removed it here.","commit_id":"88b733215eeeaa09ec8428b76a51ff901e8909e6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    },"},{"line_number":28,"context_line":"    \u0027description\u0027: {"},{"line_number":29,"context_line":"        \u0027type\u0027: \u0027string\u0027"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_registered_limit_create \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_6ebdb2b5","line":30,"updated":"2018-03-23 15:48:48.000000000","message":"You could use parameter_types.description","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    },"},{"line_number":28,"context_line":"    \u0027description\u0027: {"},{"line_number":29,"context_line":"        \u0027type\u0027: \u0027string\u0027"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_registered_limit_create \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_745f4c41","line":30,"in_reply_to":"df7087c5_6ebdb2b5","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e6b7722ef0d30f0b23f4583a791a8045992689d8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":107,"context_line":"    \u0027properties\u0027: _limit_update_properties,"},{"line_number":108,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":109,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027resource_limit\u0027]"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"limit_update \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_a0c3af56","side":"PARENT","line":109,"range":{"start_line":109,"start_character":24,"end_line":109,"end_character":38},"updated":"2018-05-14 21:26:03.000000000","message":"Why was this removed?","commit_id":"403917cef96655546c247c86adb26d10984cfb67"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1c8023bc25a0d93e760cad62a715f0cc01a564dd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":107,"context_line":"    \u0027properties\u0027: _limit_update_properties,"},{"line_number":108,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":109,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027resource_limit\u0027]"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"limit_update \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_5c861a68","side":"PARENT","line":109,"range":{"start_line":109,"start_character":24,"end_line":109,"end_character":38},"in_reply_to":"5f7c97a3_1ec4433f","updated":"2018-05-16 15:16:36.000000000","message":"Ah - thanks!","commit_id":"403917cef96655546c247c86adb26d10984cfb67"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"0e2902ed1136078ab3e77ac36f473aa9affceb15","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":107,"context_line":"    \u0027properties\u0027: _limit_update_properties,"},{"line_number":108,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":109,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027resource_limit\u0027]"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"limit_update \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_1ec4433f","side":"PARENT","line":109,"range":{"start_line":109,"start_character":24,"end_line":109,"end_character":38},"in_reply_to":"5f7c97a3_a0c3af56","updated":"2018-05-15 00:52:46.000000000","message":"because now either \"resource_limit\" or \"description\" can be updated, so \"resource_limit\" is not required.","commit_id":"403917cef96655546c247c86adb26d10984cfb67"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1c8023bc25a0d93e760cad62a715f0cc01a564dd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":112,"context_line":"    \u0027properties\u0027: _limit_update_properties,"},{"line_number":113,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":114,"context_line":"    \u0027required\u0027: [\u0027id\u0027, ]"},{"line_number":115,"context_line":"}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"limit_update \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_7cee7622","line":114,"range":{"start_line":114,"start_character":21,"end_line":114,"end_character":23},"updated":"2018-05-16 15:16:36.000000000","message":"This doesn\u0027t have an impact on the actual value of the list, so we could remove it.\n\nWe can do that in a follow up though.","commit_id":"9d7ffbc89e54bae1e9c3cdafec4c23edd77fc542"}],"keystone/tests/unit/core.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"09242f50a8bcb8212908b13adfc891698c9d7377","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        \u0027service_id\u0027: uuid.uuid4().hex,"},{"line_number":469,"context_line":"        \u0027resource_name\u0027: uuid.uuid4().hex,"},{"line_number":470,"context_line":"        \u0027default_limit\u0027: 10,"},{"line_number":471,"context_line":"        \u0027description\u0027: \u0027\u0027"},{"line_number":472,"context_line":"    }"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    ref.update(kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_ee24620f","line":471,"updated":"2018-03-23 15:48:48.000000000","message":"I would set a uuid value or omit completely","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"19851a99d4cb994b8068423fd3c5f22452d99406","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        \u0027service_id\u0027: uuid.uuid4().hex,"},{"line_number":469,"context_line":"        \u0027resource_name\u0027: uuid.uuid4().hex,"},{"line_number":470,"context_line":"        \u0027default_limit\u0027: 10,"},{"line_number":471,"context_line":"        \u0027description\u0027: \u0027\u0027"},{"line_number":472,"context_line":"    }"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    ref.update(kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_d70dfa37","line":471,"in_reply_to":"df7087c5_ee24620f","updated":"2018-03-26 04:17:13.000000000","message":"Done","commit_id":"a85987aca60dad54d8580ef3b6c6621d6b8d4354"}],"keystone/tests/unit/limit/test_backends.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          PROVIDERS.unified_limit_api.create_registered_limits,"},{"line_number":109,"context_line":"                          [registered_limit_1])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_create_registered_limit_description_None(self):"},{"line_number":112,"context_line":"        registered_limit \u003d unit.new_registered_limit_ref("},{"line_number":113,"context_line":"            service_id\u003dself.service_one[\u0027id\u0027],"},{"line_number":114,"context_line":"            region_id\u003dself.region_one[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_638c1e7f","line":111,"range":{"start_line":111,"start_character":49,"end_line":111,"end_character":53},"updated":"2018-04-10 15:58:22.000000000","message":"none*","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          PROVIDERS.unified_limit_api.create_registered_limits,"},{"line_number":109,"context_line":"                          [registered_limit_1])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_create_registered_limit_description_None(self):"},{"line_number":112,"context_line":"        registered_limit \u003d unit.new_registered_limit_ref("},{"line_number":113,"context_line":"            service_id\u003dself.service_one[\u0027id\u0027],"},{"line_number":114,"context_line":"            region_id\u003dself.region_one[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_9cb2e505","line":111,"range":{"start_line":111,"start_character":49,"end_line":111,"end_character":53},"in_reply_to":"bf659307_638c1e7f","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                          PROVIDERS.unified_limit_api.create_limits,"},{"line_number":465,"context_line":"                          [limit_1])"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def test_create_limit_description_None(self):"},{"line_number":468,"context_line":"        limit \u003d unit.new_limit_ref("},{"line_number":469,"context_line":"            project_id\u003dself.tenant_bar[\u0027id\u0027],"},{"line_number":470,"context_line":"            service_id\u003dself.service_one[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_c3f2ca06","line":467,"range":{"start_line":467,"start_character":38,"end_line":467,"end_character":42},"updated":"2018-04-10 15:58:22.000000000","message":"none*","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                          PROVIDERS.unified_limit_api.create_limits,"},{"line_number":465,"context_line":"                          [limit_1])"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def test_create_limit_description_None(self):"},{"line_number":468,"context_line":"        limit \u003d unit.new_limit_ref("},{"line_number":469,"context_line":"            project_id\u003dself.tenant_bar[\u0027id\u0027],"},{"line_number":470,"context_line":"            service_id\u003dself.service_one[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_5cd0cd1f","line":467,"range":{"start_line":467,"start_character":38,"end_line":467,"end_character":42},"in_reply_to":"bf659307_c3f2ca06","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"}],"keystone/tests/unit/test_limits.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.assertEqual(new_registered_limits[\u0027resource_name\u0027], \u0027snapshot\u0027)"},{"line_number":150,"context_line":"        self.assertEqual(new_registered_limits[\u0027default_limit\u0027], 5)"},{"line_number":151,"context_line":"        self.assertEqual(new_registered_limits[\u0027description\u0027],"},{"line_number":152,"context_line":"                         \u0027test description\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_update_multi_registered_limit(self):"},{"line_number":155,"context_line":"        ref \u003d unit.new_registered_limit_ref(service_id\u003dself.service_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_5b3117ec","line":152,"updated":"2018-03-19 14:52:43.000000000","message":"We should add a test to make sure we can override a description we\u0027ve provided (e.g. setting it back to \u0027\u0027 from \u0027test description\u0027).","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a886f073fc326afe5effb90878cd8d5cdf1eecf7","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.assertEqual(new_registered_limits[\u0027resource_name\u0027], \u0027snapshot\u0027)"},{"line_number":150,"context_line":"        self.assertEqual(new_registered_limits[\u0027default_limit\u0027], 5)"},{"line_number":151,"context_line":"        self.assertEqual(new_registered_limits[\u0027description\u0027],"},{"line_number":152,"context_line":"                         \u0027test description\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_update_multi_registered_limit(self):"},{"line_number":155,"context_line":"        ref \u003d unit.new_registered_limit_ref(service_id\u003dself.service_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_8c8d207d","line":152,"in_reply_to":"df7087c5_5b3117ec","updated":"2018-03-20 10:16:47.000000000","message":"sure","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        update_ref4 \u003d unit.new_registered_limit_ref(id\u003duuid.uuid4().hex,"},{"line_number":212,"context_line":"                                                    region_id\u003d\u0027fake_region\u0027)"},{"line_number":213,"context_line":"        update_ref5 \u003d unit.new_registered_limit_ref(id\u003duuid.uuid4().hex,"},{"line_number":214,"context_line":"                                                    description\u003d123)"},{"line_number":215,"context_line":"        for input_limit in [update_ref1, update_ref2, update_ref3,"},{"line_number":216,"context_line":"                            update_ref4, update_ref5]:"},{"line_number":217,"context_line":"            self.put("}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_7b689bb9","line":214,"range":{"start_line":214,"start_character":52,"end_line":214,"end_character":68},"updated":"2018-03-19 14:52:43.000000000","message":"This should be a good candidate for the json_schema testing in keystone/tests/unit/test_validation.py (along with description\u003dTrue, description\u003d123, etc..)","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a886f073fc326afe5effb90878cd8d5cdf1eecf7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        update_ref4 \u003d unit.new_registered_limit_ref(id\u003duuid.uuid4().hex,"},{"line_number":212,"context_line":"                                                    region_id\u003d\u0027fake_region\u0027)"},{"line_number":213,"context_line":"        update_ref5 \u003d unit.new_registered_limit_ref(id\u003duuid.uuid4().hex,"},{"line_number":214,"context_line":"                                                    description\u003d123)"},{"line_number":215,"context_line":"        for input_limit in [update_ref1, update_ref2, update_ref3,"},{"line_number":216,"context_line":"                            update_ref4, update_ref5]:"},{"line_number":217,"context_line":"            self.put("}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_2cbbb4e5","line":214,"range":{"start_line":214,"start_character":52,"end_line":214,"end_character":68},"in_reply_to":"df7087c5_7b689bb9","updated":"2018-03-20 10:16:47.000000000","message":"yeah, here is a double check to ensure the response code is correct.","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"}],"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"                            {\u0027region_id\u0027: 123},"},{"line_number":2516,"context_line":"                            {\u0027resource_name\u0027: 123},"},{"line_number":2517,"context_line":"                            {\u0027default_limit\u0027: \u0027not_int\u0027},"},{"line_number":2518,"context_line":"                            {\u0027description\u0027: 123}]"},{"line_number":2519,"context_line":"        for invalid_desc in _INVALID_FORMATS:"},{"line_number":2520,"context_line":"            request_to_validate \u003d [{\u0027service_id\u0027: uuid.uuid4().hex,"},{"line_number":2521,"context_line":"                                    \u0027region_id\u0027: \u0027RegionOne\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_9baa4fd0","line":2518,"updated":"2018-03-19 14:52:43.000000000","message":"We could also add booleans to this:\n\n  ...,\n  {\u0027description\u0027: 123},\n  {\u0027description\u0027: True}]","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a886f073fc326afe5effb90878cd8d5cdf1eecf7","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"                            {\u0027region_id\u0027: 123},"},{"line_number":2516,"context_line":"                            {\u0027resource_name\u0027: 123},"},{"line_number":2517,"context_line":"                            {\u0027default_limit\u0027: \u0027not_int\u0027},"},{"line_number":2518,"context_line":"                            {\u0027description\u0027: 123}]"},{"line_number":2519,"context_line":"        for invalid_desc in _INVALID_FORMATS:"},{"line_number":2520,"context_line":"            request_to_validate \u003d [{\u0027service_id\u0027: uuid.uuid4().hex,"},{"line_number":2521,"context_line":"                                    \u0027region_id\u0027: \u0027RegionOne\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_4cc06851","line":2518,"in_reply_to":"df7087c5_9baa4fd0","updated":"2018-03-20 10:16:47.000000000","message":"Done","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":2597,"context_line":"                                \u0027description\u0027: \u0027test description\u0027}]"},{"line_number":2598,"context_line":"        self.create_limits_validator.validate(request_to_validate)"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"    def test_validate_limit_create_request_without_optional(self):"},{"line_number":2601,"context_line":"        request_to_validate \u003d [{\u0027project_id\u0027: uuid.uuid4().hex,"},{"line_number":2602,"context_line":"                                \u0027service_id\u0027: uuid.uuid4().hex,"},{"line_number":2603,"context_line":"                                \u0027resource_name\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_7bdbbb7c","line":2600,"range":{"start_line":2600,"start_character":51,"end_line":2600,"end_character":59},"updated":"2018-03-19 14:52:43.000000000","message":"Good call on renaming this.","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"}],"releasenotes/notes/add-limit-description-c1f42641d9c6c33d.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    A new optional property `description` is added to registred limit and limit"},{"line_number":6,"context_line":"    rescource. The default value is \u0027\u0027. Users can create/update registred"},{"line_number":7,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df7087c5_78266119","line":4,"updated":"2018-03-19 14:52:43.000000000","message":"We could also add a link to the bug report [0], which will help people understand exactly why we needed to add support for this.\n\n[0] https://bugs.launchpad.net/keystone/+bug/1754185","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    A new optional property `description` is added to registred limit and limit"},{"line_number":6,"context_line":"    rescource. The default value is \u0027\u0027. Users can create/update registred"},{"line_number":7,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df7087c5_387549fb","line":6,"range":{"start_line":6,"start_character":64,"end_line":6,"end_character":73},"updated":"2018-03-19 14:52:43.000000000","message":"nit: a registered limit or a project limit","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"86d066f0590e18ef85c88ab850a7223de0bfece0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    A new optional property `description` is added to registred limit and limit"},{"line_number":6,"context_line":"    rescource. The default value is \u0027\u0027. Users can create/update registred"},{"line_number":7,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df7087c5_187de5e6","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":13},"updated":"2018-03-19 14:52:43.000000000","message":"nit: resources*","commit_id":"f621f9d278882ff52ef234c2f1db231581ea745f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    [`bug 1754185 \u003chttps://bugs.launchpad.net/keystone/+bug/1754185\u003e`_]"},{"line_number":6,"context_line":"    A new optional property `description` which is nullable is added to"},{"line_number":7,"context_line":"    registred limit and limit rescources. Users can create/update a registred"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_a3c0f67d","line":4,"range":{"start_line":4,"start_character":5,"end_line":4,"end_character":96},"updated":"2018-04-10 15:58:22.000000000","message":"Since we don\u0027t have a specification for this work yet, we might be fine just linking to the bug report.","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    [`bug 1754185 \u003chttps://bugs.launchpad.net/keystone/+bug/1754185\u003e`_]"},{"line_number":6,"context_line":"    A new optional property `description` which is nullable is added to"},{"line_number":7,"context_line":"    registred limit and limit rescources. Users can create/update a registred"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_bcac899f","line":4,"range":{"start_line":4,"start_character":5,"end_line":4,"end_character":96},"in_reply_to":"bf659307_a3c0f67d","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    [`bug 1754185 \u003chttps://bugs.launchpad.net/keystone/+bug/1754185\u003e`_]"},{"line_number":6,"context_line":"    A new optional property `description` which is nullable is added to"},{"line_number":7,"context_line":"    registred limit and limit rescources. Users can create/update a registred"},{"line_number":8,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_436d5a96","line":6,"updated":"2018-04-10 15:58:22.000000000","message":"nit:\n\n  Registered limits and project limits now support an\n  optional, nullable property called `description`.","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    [`bug 1754185 \u003chttps://bugs.launchpad.net/keystone/+bug/1754185\u003e`_]"},{"line_number":6,"context_line":"    A new optional property `description` which is nullable is added to"},{"line_number":7,"context_line":"    registred limit and limit rescources. Users can create/update a registred"},{"line_number":8,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_7c927159","line":6,"in_reply_to":"bf659307_436d5a96","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8a94657184645aa37ab371afd55ea73fd3d9d141","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    [`bug 1754185 \u003chttps://bugs.launchpad.net/keystone/+bug/1754185\u003e`_]"},{"line_number":6,"context_line":"    A new optional property `description` which is nullable is added to"},{"line_number":7,"context_line":"    registred limit and limit rescources. Users can create/update a registred"},{"line_number":8,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_834a9224","line":7,"range":{"start_line":7,"start_character":68,"end_line":7,"end_character":77},"updated":"2018-04-10 15:58:22.000000000","message":"registered*","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9cbe70c67f22242991471f760a1035eb9d2768f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`blueprint unified-limit \u003chttps://blueprints.launchpad.net/keystone/+spec/unified-limit\u003e`_]"},{"line_number":5,"context_line":"    [`bug 1754185 \u003chttps://bugs.launchpad.net/keystone/+bug/1754185\u003e`_]"},{"line_number":6,"context_line":"    A new optional property `description` which is nullable is added to"},{"line_number":7,"context_line":"    registred limit and limit rescources. Users can create/update a registred"},{"line_number":8,"context_line":"    limit or project limit with `description` now."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_3c987973","line":7,"range":{"start_line":7,"start_character":68,"end_line":7,"end_character":77},"in_reply_to":"bf659307_834a9224","updated":"2018-04-11 01:48:03.000000000","message":"Done","commit_id":"e06708834e6e33111e88abe0e4f571aabf4f4212"}]}