)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d45bf223e9163260ceb6eed9a5baedfb6f01966","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Token data doesn\u0027t contain extra property at all."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Clean up the realted code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I828cc0ad3ac265abdfea2e1571806add128ae51e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_345632d0","line":12,"updated":"2018-03-23 14:10:49.000000000","message":"Could you go a little deeper into how you determined this wasn\u0027t needed? Removing things from the token provider is a little scary. Also keep in mind that some auth plugins might be out of tree.","commit_id":"1740055f09884a7342069207470c0d4ed970f201"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ea67fda726ea68bb4a9d6a087981da922fbd41c7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Token data doesn\u0027t contain extra property at all."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Clean up the realted code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I828cc0ad3ac265abdfea2e1571806add128ae51e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf659307_f6b7e339","line":12,"in_reply_to":"df7087c5_345632d0","updated":"2018-03-26 01:33:31.000000000","message":"Sure, I\u0027ll write more.","commit_id":"1740055f09884a7342069207470c0d4ed970f201"}],"doc/source/api_curl_examples.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b5a26906d82270be7d8bb959d726f238e25231f8","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        \"id\": \"bd73972c0e14fb69bae8ff76e112a90\","},{"line_number":175,"context_line":"        \"name\": \"keystone\""},{"line_number":176,"context_line":"      }],"},{"line_number":177,"context_line":"      \"extras\": {},"},{"line_number":178,"context_line":"      \"user\": {"},{"line_number":179,"context_line":"        \"domain\": {"},{"line_number":180,"context_line":"          \"id\": \"default\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_2bd33862","side":"PARENT","line":177,"updated":"2018-04-11 19:05:19.000000000","message":"Wow - these must be stale! We could generate some new examples and compare them just to make sure we\u0027re not missing anything else or advertising inconsistencies.","commit_id":"6d0223367666f17bd864a8e3c0d02f4b76ab1e79"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bc53b01c19cc9eeda21e86cf72acedb100a5dc","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        \"id\": \"bd73972c0e14fb69bae8ff76e112a90\","},{"line_number":175,"context_line":"        \"name\": \"keystone\""},{"line_number":176,"context_line":"      }],"},{"line_number":177,"context_line":"      \"extras\": {},"},{"line_number":178,"context_line":"      \"user\": {"},{"line_number":179,"context_line":"        \"domain\": {"},{"line_number":180,"context_line":"          \"id\": \"default\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_fce42ae2","side":"PARENT","line":177,"in_reply_to":"5f7c97a3_078bdd6d","updated":"2018-05-11 03:44:28.000000000","message":"Done","commit_id":"6d0223367666f17bd864a8e3c0d02f4b76ab1e79"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"31459d77a632caa5b199d1b3dfe177d2b95c8462","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        \"id\": \"bd73972c0e14fb69bae8ff76e112a90\","},{"line_number":175,"context_line":"        \"name\": \"keystone\""},{"line_number":176,"context_line":"      }],"},{"line_number":177,"context_line":"      \"extras\": {},"},{"line_number":178,"context_line":"      \"user\": {"},{"line_number":179,"context_line":"        \"domain\": {"},{"line_number":180,"context_line":"          \"id\": \"default\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_078bdd6d","side":"PARENT","line":177,"in_reply_to":"bf659307_2bd33862","updated":"2018-05-10 14:35:52.000000000","message":"++","commit_id":"6d0223367666f17bd864a8e3c0d02f4b76ab1e79"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0b23aa8b162ac53247bf7b6be8c0daa523522f1d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        \"id\": \"bd73972c0e14fb69bae8ff76e112a90\","},{"line_number":175,"context_line":"        \"name\": \"keystone\""},{"line_number":176,"context_line":"      }],"},{"line_number":177,"context_line":"      \"extras\": {},"},{"line_number":178,"context_line":"      \"user\": {"},{"line_number":179,"context_line":"        \"domain\": {"},{"line_number":180,"context_line":"          \"id\": \"default\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_4a36a353","side":"PARENT","line":177,"in_reply_to":"bf659307_2bd33862","updated":"2018-04-11 22:12:30.000000000","message":"++, definitely should update this, if not here then in another change.","commit_id":"6d0223367666f17bd864a8e3c0d02f4b76ab1e79"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7036e611fcae020d7779c964502920a27d982c0b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        \"id\": \"8538a3f13f9541b28c2620eb19065e45\","},{"line_number":154,"context_line":"        \"name\": \"admin\""},{"line_number":155,"context_line":"      },"},{"line_number":156,"context_line":"      \"catalog\": [{"},{"line_number":157,"context_line":"        \"endpoints\": [{"},{"line_number":158,"context_line":"          \"url\": \"http://localhost:3537/v2.0\","},{"line_number":159,"context_line":"          \"region\": \"RegionOne\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_c0fcab71","side":"PARENT","line":156,"range":{"start_line":156,"start_character":7,"end_line":156,"end_character":14},"updated":"2018-05-14 21:38:05.000000000","message":"We don\u0027t want to update this example with the catalog?","commit_id":"d0fc578305bb7e4d6a81708b3690d9546ec6fe22"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"aa9dd1aaf9e2faabefcb45b577dd2bc5aec6466e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        \"id\": \"8538a3f13f9541b28c2620eb19065e45\","},{"line_number":154,"context_line":"        \"name\": \"admin\""},{"line_number":155,"context_line":"      },"},{"line_number":156,"context_line":"      \"catalog\": [{"},{"line_number":157,"context_line":"        \"endpoints\": [{"},{"line_number":158,"context_line":"          \"url\": \"http://localhost:3537/v2.0\","},{"line_number":159,"context_line":"          \"region\": \"RegionOne\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_3eed7fb6","side":"PARENT","line":156,"range":{"start_line":156,"start_character":7,"end_line":156,"end_character":14},"in_reply_to":"5f7c97a3_c0fcab71","updated":"2018-05-15 00:57:03.000000000","message":"Actually it\u0027s an unscoped token, so there is no catalog in the token data.\n\nI changed the title at L101, because I don\u0027t think Keystone support the \"default scope\" if the input is like L108-L124","commit_id":"d0fc578305bb7e4d6a81708b3690d9546ec6fe22"}],"keystone/auth/plugins/base.py":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0b23aa8b162ac53247bf7b6be8c0daa523522f1d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        in case authentication is for re-scoping. For example, if the"},{"line_number":48,"context_line":"        authentication is for re-scoping, plugin must append the previous"},{"line_number":49,"context_line":"        method names into ``method_names``; NOTE: This behavior is exclusive"},{"line_number":50,"context_line":"        to the re-scope type action.Here\u0027s an example of ``response_data`` on"},{"line_number":51,"context_line":"        successful authentication::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_ca4153a8","line":50,"updated":"2018-04-11 22:12:30.000000000","message":"nit: needs a space here","commit_id":"86948f39b0f6e41d014a5186cb49d6a6830e78bb"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bc53b01c19cc9eeda21e86cf72acedb100a5dc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        in case authentication is for re-scoping. For example, if the"},{"line_number":48,"context_line":"        authentication is for re-scoping, plugin must append the previous"},{"line_number":49,"context_line":"        method names into ``method_names``; NOTE: This behavior is exclusive"},{"line_number":50,"context_line":"        to the re-scope type action.Here\u0027s an example of ``response_data`` on"},{"line_number":51,"context_line":"        successful authentication::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_7c525ae0","line":50,"in_reply_to":"bf659307_ca4153a8","updated":"2018-05-11 03:44:28.000000000","message":"Done","commit_id":"86948f39b0f6e41d014a5186cb49d6a6830e78bb"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d45bf223e9163260ceb6eed9a5baedfb6f01966","unresolved":false,"context_lines":[{"line_number":2453,"context_line":"        r \u003d self.get(\u0027/auth/tokens\u0027, headers\u003dself.headers)"},{"line_number":2454,"context_line":""},{"line_number":2455,"context_line":"        # populate the response result with some extra data"},{"line_number":2456,"context_line":"        r.result[\u0027token\u0027][u\u0027extra\u0027] \u003d six.text_type(uuid.uuid4().hex)"},{"line_number":2457,"context_line":"        self.assertRaises(exception.SchemaValidationError,"},{"line_number":2458,"context_line":"                          self.assertValidUnscopedTokenResponse,"},{"line_number":2459,"context_line":"                          r)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_b4e2422f","side":"PARENT","line":2456,"updated":"2018-03-23 14:10:49.000000000","message":"This test is about a garbage property of \u0027extra\u0027 but your change is about a property called \u0027extras\u0027, I think this test should probably stay? Same with below.","commit_id":"d4f3160334838c592cc8616bba85c13f308468f6"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7bff1f1154443fc4dbd7cc050d5755c8fe745198","unresolved":false,"context_lines":[{"line_number":2453,"context_line":"        r \u003d self.get(\u0027/auth/tokens\u0027, headers\u003dself.headers)"},{"line_number":2454,"context_line":""},{"line_number":2455,"context_line":"        # populate the response result with some extra data"},{"line_number":2456,"context_line":"        r.result[\u0027token\u0027][u\u0027extra\u0027] \u003d six.text_type(uuid.uuid4().hex)"},{"line_number":2457,"context_line":"        self.assertRaises(exception.SchemaValidationError,"},{"line_number":2458,"context_line":"                          self.assertValidUnscopedTokenResponse,"},{"line_number":2459,"context_line":"                          r)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_caecf3bc","side":"PARENT","line":2456,"in_reply_to":"bf659307_56ab2fd5","updated":"2018-04-11 22:08:59.000000000","message":"Maybe rename \"extra\" here to something else.","commit_id":"d4f3160334838c592cc8616bba85c13f308468f6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ea67fda726ea68bb4a9d6a087981da922fbd41c7","unresolved":false,"context_lines":[{"line_number":2453,"context_line":"        r \u003d self.get(\u0027/auth/tokens\u0027, headers\u003dself.headers)"},{"line_number":2454,"context_line":""},{"line_number":2455,"context_line":"        # populate the response result with some extra data"},{"line_number":2456,"context_line":"        r.result[\u0027token\u0027][u\u0027extra\u0027] \u003d six.text_type(uuid.uuid4().hex)"},{"line_number":2457,"context_line":"        self.assertRaises(exception.SchemaValidationError,"},{"line_number":2458,"context_line":"                          self.assertValidUnscopedTokenResponse,"},{"line_number":2459,"context_line":"                          r)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_56ab2fd5","side":"PARENT","line":2456,"in_reply_to":"df7087c5_b4e2422f","updated":"2018-03-26 01:33:31.000000000","message":"These three tests don\u0027t relate to the code change indeed. But IMO these three tests are useless now, because they test a case which will never happen. Anyway, I\u0027ll add them back since this is another problem.","commit_id":"d4f3160334838c592cc8616bba85c13f308468f6"}]}