)]}'
{"keystone/identity/controllers.py":[{"author":{"_account_id":7476,"name":"kaitian521","email":"kaitian521@gmail.com"},"change_message_id":"6c76da0f811b09f421555940094d59a50279de7d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        return o"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _check_description(self, tenant):"},{"line_number":171,"context_line":"        if \u0027description\u0027 not in tenant or not tenant[\u0027description\u0027]:"},{"line_number":172,"context_line":"            tenant[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":173,"context_line":"        return tenant"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FXHo%3D","line":171,"updated":"2013-11-08 07:38:35.000000000","message":"if not tenant.get(\u0027description\u0027):\n    tenant[\u0027descripton\u0027] \u003d \u0027\u0027\n\n???","commit_id":"22b48188cf3dfa716ba9fc40c1ac49987e62cc5b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"61e74f445e41687c42778b9f3e384f05a7d7c9df","unresolved":false,"context_lines":[{"line_number":167,"context_line":"             \u0027tenants_links\u0027: []}"},{"line_number":168,"context_line":"        return o"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _check_description(self, tenant):"},{"line_number":171,"context_line":"        if not tenant.get(\u0027description\u0027):"},{"line_number":172,"context_line":"            tenant[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":173,"context_line":"        return tenant"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9%2FvQ%3D","line":170,"updated":"2013-12-03 17:01:17.000000000","message":"this isn\u0027t a \"check\" -- it\u0027s actually modifying the referenced object","commit_id":"5516abcf456d17cf2f9962f57e0c0146204b0d68"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"61e74f445e41687c42778b9f3e384f05a7d7c9df","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        return o"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _check_description(self, tenant):"},{"line_number":171,"context_line":"        if not tenant.get(\u0027description\u0027):"},{"line_number":172,"context_line":"            tenant[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":173,"context_line":"        return tenant"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9%2Fvs%3D","line":171,"updated":"2013-12-03 17:01:17.000000000","message":"i\u0027m not sure if you mean to replace null, unset AND empty string descriptions with empty strings (that doesn\u0027t make much sense to me?).... i\u0027m wondering if you meant:\n\n  tenant.setdefault(\u0027description\u0027, \u0027\u0027)","commit_id":"5516abcf456d17cf2f9962f57e0c0146204b0d68"}],"keystone/tests/test_keystoneclient.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7dc219f5dd1742ac27426457c7f196124a0043f6","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        tenants \u003d client.tenants.list()"},{"line_number":392,"context_line":"        self.assertEqual(len(tenants), len(default_fixtures.TENANTS))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test_tenant_with_description(self):"},{"line_number":395,"context_line":"        admin_client \u003d self.get_client(admin\u003dTrue)"},{"line_number":396,"context_line":"        tenant_name \u003d uuid.uuid4().hex"},{"line_number":397,"context_line":"        tenant_ref \u003d admin_client.tenants.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FRg4%3D","line":394,"updated":"2013-11-11 22:07:02.000000000","message":"Here we are testing \u0027with\u0027 a description but we are passing None in the tenants.create? Should this test case be testing \u0027with\u0027 description and a separate test case testing the negative path \u0027without\u0027 description?","commit_id":"2065b1c8e0706461eff33980abd3c6e421d91054"},{"author":{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},"change_message_id":"dee522fa1874d27fb24ee9408538a52bf350795a","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        tenants \u003d client.tenants.list()"},{"line_number":392,"context_line":"        self.assertEqual(len(tenants), len(default_fixtures.TENANTS))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test_tenant_with_description(self):"},{"line_number":395,"context_line":"        admin_client \u003d self.get_client(admin\u003dTrue)"},{"line_number":396,"context_line":"        tenant_name \u003d uuid.uuid4().hex"},{"line_number":397,"context_line":"        tenant_ref \u003d admin_client.tenants.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FRaQ%3D","line":394,"updated":"2013-11-11 23:23:42.000000000","message":"We should have test for both the scenarios, with/without description.","commit_id":"2065b1c8e0706461eff33980abd3c6e421d91054"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"88b85b82da372c821d97c2d886db3d9adcc6aee2","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        tenants \u003d client.tenants.list()"},{"line_number":392,"context_line":"        self.assertEqual(len(tenants), len(default_fixtures.TENANTS))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test_tenant_with_description(self):"},{"line_number":395,"context_line":"        admin_client \u003d self.get_client(admin\u003dTrue)"},{"line_number":396,"context_line":"        tenant_name \u003d uuid.uuid4().hex"},{"line_number":397,"context_line":"        tenant_ref \u003d admin_client.tenants.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FRCk%3D","line":394,"in_reply_to":"AAAATn%2F%2FRaQ%3D","updated":"2013-11-12 01:48:32.000000000","message":"Actually, in the test method, the scenario whitout description is tested. See #399 line. \n\nBut yes, the method name is confused. I have separate these two case.","commit_id":"2065b1c8e0706461eff33980abd3c6e421d91054"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"61e74f445e41687c42778b9f3e384f05a7d7c9df","unresolved":false,"context_lines":[{"line_number":959,"context_line":"            tenant_id \u003d uuid.uuid4().hex"},{"line_number":960,"context_line":"            tenant \u003d {\u0027name\u0027: \u0027tenant-%s\u0027 % tenant_id, \u0027id\u0027: tenant_id,"},{"line_number":961,"context_line":"                      \u0027domain_id\u0027: DEFAULT_DOMAIN_ID,"},{"line_number":962,"context_line":"                      \u0027description\u0027: \u0027description\u0027}"},{"line_number":963,"context_line":"            self.assignment_api.create_project(tenant_id, tenant)"},{"line_number":964,"context_line":"            self.assignment_api.add_user_to_project(tenant_id,"},{"line_number":965,"context_line":"                                                    self.user_foo[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9%2FuU%3D","line":962,"updated":"2013-12-03 17:01:17.000000000","message":"if this change requires this \"fix\" -- then this change looks broken. please remove these new descriptions","commit_id":"5516abcf456d17cf2f9962f57e0c0146204b0d68"}]}