)]}'
{"keystone/tests/unit/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0b824fcc758bc2c72ec1bb4cfa0cedfc43bb92b4","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        \u0027description\u0027: \u0027\u0027,"},{"line_number":337,"context_line":"    }"},{"line_number":338,"context_line":"    ref.update(kwargs)"},{"line_number":339,"context_line":"    return ref"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def new_group_ref(domain_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_041e86ba","line":339,"updated":"2018-08-22 13:05:36.000000000","message":"Just double checking, but these are needed because we\u0027re now check FK constraints, right?","commit_id":"42bd2aadf6b0219a373d8bc7686894cca74a9e4c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4e3a49031cd0f43735f7706fdd33fe19cac747ee","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        \u0027description\u0027: \u0027\u0027,"},{"line_number":337,"context_line":"    }"},{"line_number":338,"context_line":"    ref.update(kwargs)"},{"line_number":339,"context_line":"    return ref"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def new_group_ref(domain_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_3f6939f8","line":339,"in_reply_to":"3f79a3b5_041e86ba","updated":"2018-08-23 01:39:02.000000000","message":"yes, they are used for federation identity. For example:\nhttps://github.com/openstack/keystone/blob/master/keystone/tests/unit/identity/test_backends.py#L485\nit\u0027ll create a federated user","commit_id":"42bd2aadf6b0219a373d8bc7686894cca74a9e4c"}],"keystone/tests/unit/resource/test_backends.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a4a5211ea82330adc19f14a8eb8fe68af85ce2de","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        PROVIDERS.resource_api.create_domain(domain1[\u0027id\u0027], domain1)"},{"line_number":255,"context_line":"        PROVIDERS.resource_api.create_domain(domain2[\u0027id\u0027], domain2)"},{"line_number":256,"context_line":"        domains \u003d PROVIDERS.resource_api.list_domains()"},{"line_number":257,"context_line":"        # 2 is the new created ones. 2 is the idp auto generated ones. 1 is the"},{"line_number":258,"context_line":"        # \u0027default\u0027 domain."},{"line_number":259,"context_line":"        self.assertEqual(5, len(domains))"},{"line_number":260,"context_line":"        domain_ids \u003d []"},{"line_number":261,"context_line":"        for domain in domains:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_5207b81d","line":258,"range":{"start_line":257,"start_character":0,"end_line":258,"end_character":27},"updated":"2018-08-06 23:35:47.000000000","message":"instead of using the comment, why not use constants?","commit_id":"9fac92e05459b48f9a3231852b7913fbf35772c4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"70c6a08a06f283bba17c0a92661f91401e6a1be9","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        PROVIDERS.resource_api.create_domain(domain1[\u0027id\u0027], domain1)"},{"line_number":255,"context_line":"        PROVIDERS.resource_api.create_domain(domain2[\u0027id\u0027], domain2)"},{"line_number":256,"context_line":"        domains \u003d PROVIDERS.resource_api.list_domains()"},{"line_number":257,"context_line":"        # 2 is the new created ones. 2 is the idp auto generated ones. 1 is the"},{"line_number":258,"context_line":"        # \u0027default\u0027 domain."},{"line_number":259,"context_line":"        self.assertEqual(5, len(domains))"},{"line_number":260,"context_line":"        domain_ids \u003d []"},{"line_number":261,"context_line":"        for domain in domains:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_feeb7c0f","line":258,"range":{"start_line":257,"start_character":0,"end_line":258,"end_character":27},"in_reply_to":"3f79a3b5_5207b81d","updated":"2018-08-15 07:51:55.000000000","message":"Done","commit_id":"9fac92e05459b48f9a3231852b7913fbf35772c4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"eebd67acd5c13758dbfe19eb4db609d7c8a0b792","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        PROVIDERS.resource_api.create_domain(domain2[\u0027id\u0027], domain2)"},{"line_number":256,"context_line":"        domains \u003d PROVIDERS.resource_api.list_domains()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        test_created_domain_number \u003d 2"},{"line_number":259,"context_line":"        idp_auto_generated_domain_number \u003d 2"},{"line_number":260,"context_line":"        default_domain_number \u003d 1"},{"line_number":261,"context_line":"        total_domain_number \u003d (test_created_domain_number +"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_625d7c77","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":34},"updated":"2018-08-16 00:28:31.000000000","message":"nit: I would call this and others of `..._count` instead of `..._number`.","commit_id":"42bd2aadf6b0219a373d8bc7686894cca74a9e4c"}],"keystone/tests/unit/test_backend_sql.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"072b3a7c6769d5d994a32c167dc9c2c77fda4fcc","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                  assignment_tests.AssignmentTests,"},{"line_number":236,"context_line":"                  assignment_tests.SystemAssignmentTests,"},{"line_number":237,"context_line":"                  resource_tests.ResourceTests):"},{"line_number":238,"context_line":"    def setUp(self):"},{"line_number":239,"context_line":"        super(SqlIdentity, self).setUp()"},{"line_number":240,"context_line":"        # create one test mapping, two idps and two protocols for federation"},{"line_number":241,"context_line":"        # test."}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_deb61cdd","line":238,"updated":"2018-09-03 19:36:54.000000000","message":"This seems out of place to me. Not all of the tests in this class are about federation. The fact that the number of domains is changing in the sql resource tests shows that this is leaking. Could we change this set up to only happen for the tests it\u0027s relevant for?","commit_id":"278cdbea327d647c38f3166aa44c52b8eacda5d9"}]}