)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"92ef426d21a867d1c725be3e5807610be5886e27","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference the OpenStack hacking guide in HACKING.rst and remove"},{"line_number":10,"context_line":"duplicated entries."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If82077e4f288b83b7d5d1ca68a2cc02d7644be4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2Bz4s%3D","line":11,"updated":"2013-11-19 20:43:24.000000000","message":"Please add the relevant bug for this patchset bug: 1252454\n\nThanks!","commit_id":"bbcf7853dfb8c614f653a1c8e01e9635bee3ed96"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"049531cf462a923481d05884c39c89909d0394ec","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference the OpenStack hacking guide in HACKING.rst and remove"},{"line_number":10,"context_line":"duplicated entries."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If82077e4f288b83b7d5d1ca68a2cc02d7644be4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2Bzro%3D","line":11,"in_reply_to":"AAAATn%2F%2Bz4s%3D","updated":"2013-11-19 23:03:30.000000000","message":"Bug https://bugs.launchpad.net/keystone/+bug/1252454 isn\u0027t actually related to this patch beyond this review raised the issue.\n\nWhat would you like me to say here? As this is only tangentially related and definitely doesn\u0027t fix bug 1252454","commit_id":"bbcf7853dfb8c614f653a1c8e01e9635bee3ed96"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"3950e639a070082166e41d69eecff222350f19a3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference the OpenStack hacking guide in HACKING.rst and remove"},{"line_number":10,"context_line":"duplicated entries."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If82077e4f288b83b7d5d1ca68a2cc02d7644be4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2Bzbo%3D","line":11,"in_reply_to":"AAAATn%2F%2BzcE%3D","updated":"2013-11-19 23:15:51.000000000","message":"but its not related","commit_id":"bbcf7853dfb8c614f653a1c8e01e9635bee3ed96"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d3a8a11a6d87f62e9fc121308c9450b50bce0c00","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference the OpenStack hacking guide in HACKING.rst and remove"},{"line_number":10,"context_line":"duplicated entries."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If82077e4f288b83b7d5d1ca68a2cc02d7644be4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BzcE%3D","line":11,"in_reply_to":"AAAATn%2F%2Bzro%3D","updated":"2013-11-19 23:14:44.000000000","message":"as I recall, related-bug: \u003cid\u003e is the correct nomenclature.  Please correct me if i\u0027m wrong.","commit_id":"bbcf7853dfb8c614f653a1c8e01e9635bee3ed96"}],"HACKING.rst":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e7788c84606d9bc4fe008f0c80588f5b232c21c5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Include your name with TODOs as in \"#TODO(termie)\""},{"line_number":18,"context_line":"- Do not name anything the same name as a built-in or reserved word"},{"line_number":19,"context_line":"- When defining global constants, define them before functions and classes"},{"line_number":20,"context_line":"- Avoid using \"double quotes\" where you can reasonably use \u0027single quotes\u0027"},{"line_number":21,"context_line":"- Use the \"is not\" operator when testing for unequal identities. Example::"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if not X is Y:  # BAD, intended behavior is ambiguous"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2BmnM%3D","side":"PARENT","line":20,"updated":"2013-11-22 15:53:26.000000000","message":"i swear i\u0027ve commented on this before, but perhaps it was in a previous change-id?\n\nanyway, the single quotes thing is not reflected in http://docs.openstack.org/developer/hacking/ so it should either be added there or preserved here","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1a3dc2800bc6ec78fe7837ee96d44f3828815526","unresolved":false,"context_lines":[{"line_number":234,"context_line":"submitted bug fix does have a unit test, be sure to add a new one that fails"},{"line_number":235,"context_line":"without the patch and passes with the patch."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"For more information on creating unit tests and utilizing the testing"},{"line_number":238,"context_line":"infrastructure in OpenStack Nova, please read nova/testing/README.rst."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2FR0E%3D","side":"PARENT","line":237,"updated":"2013-11-11 20:21:38.000000000","message":"These two sentences now disappear forever as the content is not covered in docs.openstack.org/developer/hacking.  It\u0027s not the most impressive content on testingthat these sentences point to but its a shame to lose the reference","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"426ee601f2f161c01289ffc1a22738da9467902a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"submitted bug fix does have a unit test, be sure to add a new one that fails"},{"line_number":235,"context_line":"without the patch and passes with the patch."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"For more information on creating unit tests and utilizing the testing"},{"line_number":238,"context_line":"infrastructure in OpenStack Nova, please read nova/testing/README.rst."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2B5oI%3D","side":"PARENT","line":237,"in_reply_to":"AAAATn%2F%2FAIw%3D","updated":"2013-11-18 20:13:14.000000000","message":"Sure, but TBH  I am not really sure what the bug should say. I\u0027ll try anyway and we can tweak it.\n\nhttps://bugs.launchpad.net/keystone/+bug/1252454","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ade6d046cb4fb24112312bdd6261b87974ff31df","unresolved":false,"context_lines":[{"line_number":234,"context_line":"submitted bug fix does have a unit test, be sure to add a new one that fails"},{"line_number":235,"context_line":"without the patch and passes with the patch."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"For more information on creating unit tests and utilizing the testing"},{"line_number":238,"context_line":"infrastructure in OpenStack Nova, please read nova/testing/README.rst."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2FRzQ%3D","side":"PARENT","line":237,"in_reply_to":"AAAATn%2F%2FR0E%3D","updated":"2013-11-11 20:29:41.000000000","message":"this refers to a file in nova/testing/README.rst, not sure why keystone is point to that.\n\nwhen moving things to  docs.openstack.org/developer/hacking this line was omitted because it was nova specific.  If we want this testing information perhaps we should find a better home for it then just pointing to the nova repo","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d74dade8ea39da72e0c05821b745b9adead75cf4","unresolved":false,"context_lines":[{"line_number":234,"context_line":"submitted bug fix does have a unit test, be sure to add a new one that fails"},{"line_number":235,"context_line":"without the patch and passes with the patch."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"For more information on creating unit tests and utilizing the testing"},{"line_number":238,"context_line":"infrastructure in OpenStack Nova, please read nova/testing/README.rst."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2FAIw%3D","side":"PARENT","line":237,"in_reply_to":"AAAATn%2F%2FRu4%3D","updated":"2013-11-15 21:29:45.000000000","message":"Could a bug be opened for documenting this for Keystone?","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"e884127f2ce5e86e1756b39a15f25a1624db59bf","unresolved":false,"context_lines":[{"line_number":234,"context_line":"submitted bug fix does have a unit test, be sure to add a new one that fails"},{"line_number":235,"context_line":"without the patch and passes with the patch."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"For more information on creating unit tests and utilizing the testing"},{"line_number":238,"context_line":"infrastructure in OpenStack Nova, please read nova/testing/README.rst."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2FRu4%3D","side":"PARENT","line":237,"in_reply_to":"AAAATn%2F%2FRzQ%3D","updated":"2013-11-11 20:58:45.000000000","message":"I hear ya.","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"f040eec9a162005f9db9b1424cf17aede9b59e0f","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"oslo-incubator"},{"line_number":242,"context_line":"----------------"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"A number of modules from oslo-incubator are imported into the project."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"These modules are \"incubating\" in oslo-incubator and are kept in sync"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2B5qU%3D","side":"PARENT","line":243,"updated":"2013-11-18 19:54:56.000000000","message":"Isn\u0027t this not covered by the generic include above?. if i\u0027m missing something let me know...I\u0027ll +1 once i can understand if the specific stuff is still included somewhere or if its whiped with the include vs. old rev text","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"5703694c35a32f6b611e9db262efe03079621feb","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"oslo-incubator"},{"line_number":242,"context_line":"----------------"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"A number of modules from oslo-incubator are imported into the project."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"These modules are \"incubating\" in oslo-incubator and are kept in sync"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2B5hs%3D","side":"PARENT","line":243,"in_reply_to":"AAAATn%2F%2B5oQ%3D","updated":"2013-11-18 20:36:12.000000000","message":"Done","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"426ee601f2f161c01289ffc1a22738da9467902a","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"oslo-incubator"},{"line_number":242,"context_line":"----------------"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"A number of modules from oslo-incubator are imported into the project."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"These modules are \"incubating\" in oslo-incubator and are kept in sync"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F%2B5oQ%3D","side":"PARENT","line":243,"in_reply_to":"AAAATn%2F%2B5qU%3D","updated":"2013-11-18 20:13:14.000000000","message":"See http://docs.openstack.org/developer/hacking/#oslo-incubator","commit_id":"6751c7dc3b1b364e8f59d452f5702e89d4d56bcb"}]}