)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e118385676bba75a5f3a7a8e25932efb4f48db7a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The test that IdP and domain is unique constraint is wrong."},{"line_number":10,"context_line":"Keystone never support Idp:domain is 1:1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixed the error to make sure Idp:domain is n:1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I90a0ed677aa9d666a220bd2456dac336378cd3ba"},{"line_number":15,"context_line":"Closes-bug: #1760843"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_010ce4a2","line":12,"updated":"2018-04-24 14:23:17.000000000","message":"We can clarify this relationship further in our documentation: \n\nhttps://developer.openstack.org/api-ref/identity/v3-ext/index.html#id260","commit_id":"436d59ffe541fdb9da71a5678b727907ff65b525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b23189830e0540d82fd1708a0bae53cecf9d9164","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The test that IdP and domain is unique constraint is wrong."},{"line_number":10,"context_line":"Keystone never support Idp:domain is 1:1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixed the error to make sure Idp:domain is n:1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I90a0ed677aa9d666a220bd2456dac336378cd3ba"},{"line_number":15,"context_line":"Closes-bug: #1760843"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_f4071fc9","line":12,"in_reply_to":"9f6a8fd7_010ce4a2","updated":"2018-04-25 03:12:55.000000000","message":"Done","commit_id":"436d59ffe541fdb9da71a5678b727907ff65b525"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"81a0a6f93a0b07ccf300251a6f2d07c75f9676e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The test that IdP and domain is unique constraint is wrong."},{"line_number":10,"context_line":"Keystone never support Idp:domain is 1:1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixed the error to make sure Idp:domain is n:1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I90a0ed677aa9d666a220bd2456dac336378cd3ba"},{"line_number":15,"context_line":"Closes-bug: #1760843"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_18f3a0a0","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"updated":"2018-05-05 02:45:14.000000000","message":"This patch doesn\u0027t fix the error but just a testcase.","commit_id":"f1432f9ade7c18eab25fa4c1d0f682d473fecbfb"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c188267898f4fe6e5a83b93bba283e81cc30db24","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The test that IdP and domain is unique constraint is wrong."},{"line_number":10,"context_line":"Keystone never support Idp:domain is 1:1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixed the error to make sure Idp:domain is n:1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I90a0ed677aa9d666a220bd2456dac336378cd3ba"},{"line_number":15,"context_line":"Closes-bug: #1760843"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_8ae42dae","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"5f7c97a3_18f3a0a0","updated":"2018-05-07 01:48:53.000000000","message":"Done","commit_id":"f1432f9ade7c18eab25fa4c1d0f682d473fecbfb"}],"api-ref/source/v3-ext/federation.inc":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d255166adde438586c5b3ef7734fc9885619730a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  The ID of the domain that is associated with the IdP."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  If a value is not specified by the client, the service will automatically"},{"line_number":80,"context_line":"  create a domain and associate it to the IdP. The ``domain_id`` is not unique"},{"line_number":81,"context_line":"  so that users can create multiple IdPs to one domain."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- ``description`` (string)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f6a8fd7_41aee1e7","line":81,"range":{"start_line":80,"start_character":47,"end_line":81,"end_character":55},"updated":"2018-05-01 02:49:56.000000000","message":"I don\u0027t understand what do you mean here.","commit_id":"42549130f0c62a0f690efa9f3b70a753067be397"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"59b63e376a92b3ec7886cbed6b2eb6876ad37049","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  If a value is not specified by the client, the service will automatically"},{"line_number":80,"context_line":"  create a domain and associate it to the IdP. The ``domain_id`` is not unique"},{"line_number":81,"context_line":"  so that users can create multiple IdPs to one domain."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- ``description`` (string)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5f7c97a3_fe88dac6","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":26},"updated":"2018-05-08 22:03:32.000000000","message":"s/create/link","commit_id":"962b06e22abe28a0200554764f421db102b03c60"}],"keystone/tests/unit/test_v3_federation.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e118385676bba75a5f3a7a8e25932efb4f48db7a","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        # since it wasn\u0027t auto-generated"},{"line_number":994,"context_line":"        self.assertIsNotNone(PROVIDERS.resource_api.get_domain(domain[\u0027id\u0027]))"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def test_create_multi_idp_in_one_domain(self):"},{"line_number":997,"context_line":"        # create domain and add domain_id to keys to check"},{"line_number":998,"context_line":"        domain \u003d unit.new_domain_ref()"},{"line_number":999,"context_line":"        PROVIDERS.resource_api.create_domain(domain[\u0027id\u0027], domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_81a0f491","line":996,"range":{"start_line":996,"start_character":30,"end_line":996,"end_character":32},"updated":"2018-04-24 14:23:17.000000000","message":"nit: to","commit_id":"436d59ffe541fdb9da71a5678b727907ff65b525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b23189830e0540d82fd1708a0bae53cecf9d9164","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        # since it wasn\u0027t auto-generated"},{"line_number":994,"context_line":"        self.assertIsNotNone(PROVIDERS.resource_api.get_domain(domain[\u0027id\u0027]))"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def test_create_multi_idp_in_one_domain(self):"},{"line_number":997,"context_line":"        # create domain and add domain_id to keys to check"},{"line_number":998,"context_line":"        domain \u003d unit.new_domain_ref()"},{"line_number":999,"context_line":"        PROVIDERS.resource_api.create_domain(domain[\u0027id\u0027], domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_140bb3d5","line":996,"range":{"start_line":996,"start_character":30,"end_line":996,"end_character":32},"in_reply_to":"9f6a8fd7_81a0f491","updated":"2018-04-25 03:12:55.000000000","message":"Done","commit_id":"436d59ffe541fdb9da71a5678b727907ff65b525"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d255166adde438586c5b3ef7734fc9885619730a","unresolved":false,"context_lines":[{"line_number":994,"context_line":"        # since it wasn\u0027t auto-generated"},{"line_number":995,"context_line":"        self.assertIsNotNone(PROVIDERS.resource_api.get_domain(domain[\u0027id\u0027]))"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"    @test_utils.wip(\"Keystone never support IdP:domain \u003d 1:1. This test should\""},{"line_number":998,"context_line":"                    \"be fixed to make sure IdP:domain is n:1\", bug\u003d\u00271760843\u0027)"},{"line_number":999,"context_line":"    def test_create_idp_domain_id_unique_constraint(self):"},{"line_number":1000,"context_line":"        # create domain and add domain_id to keys to check"},{"line_number":1001,"context_line":"        domain \u003d unit.new_domain_ref()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_816f19c4","side":"PARENT","line":998,"range":{"start_line":997,"start_character":62,"end_line":998,"end_character":77},"updated":"2018-05-01 02:49:56.000000000","message":"I am wondering how this bug got fixed without one line of changing in the source but just modify this testcase, and it passed?\n\nCould you pls add the link somewhere in order to let us know how the bug fixed?","commit_id":"cee989c9686398536b35c1fb674efe573cc03b95"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"47067813935759d46b3af48e1ae596cb680312bc","unresolved":false,"context_lines":[{"line_number":994,"context_line":"        # since it wasn\u0027t auto-generated"},{"line_number":995,"context_line":"        self.assertIsNotNone(PROVIDERS.resource_api.get_domain(domain[\u0027id\u0027]))"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"    @test_utils.wip(\"Keystone never support IdP:domain \u003d 1:1. This test should\""},{"line_number":998,"context_line":"                    \"be fixed to make sure IdP:domain is n:1\", bug\u003d\u00271760843\u0027)"},{"line_number":999,"context_line":"    def test_create_idp_domain_id_unique_constraint(self):"},{"line_number":1000,"context_line":"        # create domain and add domain_id to keys to check"},{"line_number":1001,"context_line":"        domain \u003d unit.new_domain_ref()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_348204ca","side":"PARENT","line":998,"range":{"start_line":997,"start_character":62,"end_line":998,"end_character":77},"in_reply_to":"9f6a8fd7_816f19c4","updated":"2018-05-01 13:14:24.000000000","message":"oh, this patch depends on this one which fixed the code: https://review.openstack.org/#/c/559676/7","commit_id":"cee989c9686398536b35c1fb674efe573cc03b95"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d255166adde438586c5b3ef7734fc9885619730a","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        body \u003d self.default_body.copy()"},{"line_number":1013,"context_line":"        body[\u0027description\u0027] \u003d uuid.uuid4().hex"},{"line_number":1014,"context_line":"        body[\u0027domain_id\u0027] \u003d domain[\u0027id\u0027]"},{"line_number":1015,"context_line":"        idp2 \u003d self.put(url, body\u003d{\u0027identity_provider\u0027: body},"},{"line_number":1016,"context_line":"                        expected_status\u003dhttp_client.CREATED)"},{"line_number":1017,"context_line":"        self.assertValidResponse(idp2, \u0027identity_provider\u0027, dummy_validator,"},{"line_number":1018,"context_line":"                                 keys_to_check\u003dkeys_to_check,"},{"line_number":1019,"context_line":"                                 ref\u003dbody)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_413b41d0","line":1016,"range":{"start_line":1015,"start_character":0,"end_line":1016,"end_character":60},"updated":"2018-05-01 02:49:56.000000000","message":"why not align with L1006 on how the idp is created?","commit_id":"42549130f0c62a0f690efa9f3b70a753067be397"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"47067813935759d46b3af48e1ae596cb680312bc","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        body \u003d self.default_body.copy()"},{"line_number":1013,"context_line":"        body[\u0027description\u0027] \u003d uuid.uuid4().hex"},{"line_number":1014,"context_line":"        body[\u0027domain_id\u0027] \u003d domain[\u0027id\u0027]"},{"line_number":1015,"context_line":"        idp2 \u003d self.put(url, body\u003d{\u0027identity_provider\u0027: body},"},{"line_number":1016,"context_line":"                        expected_status\u003dhttp_client.CREATED)"},{"line_number":1017,"context_line":"        self.assertValidResponse(idp2, \u0027identity_provider\u0027, dummy_validator,"},{"line_number":1018,"context_line":"                                 keys_to_check\u003dkeys_to_check,"},{"line_number":1019,"context_line":"                                 ref\u003dbody)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_f426cc16","line":1016,"range":{"start_line":1015,"start_character":0,"end_line":1016,"end_character":60},"in_reply_to":"9f6a8fd7_413b41d0","updated":"2018-05-01 13:14:24.000000000","message":"because I want make sure the domain id the same with the first IdP","commit_id":"42549130f0c62a0f690efa9f3b70a753067be397"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"81a0a6f93a0b07ccf300251a6f2d07c75f9676e8","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        # since it wasn\u0027t auto-generated"},{"line_number":994,"context_line":"        self.assertIsNotNone(PROVIDERS.resource_api.get_domain(domain[\u0027id\u0027]))"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def test_create_idp_domain_id_unique_constraint(self):"},{"line_number":997,"context_line":"        # create domain and add domain_id to keys to check"},{"line_number":998,"context_line":"        domain \u003d unit.new_domain_ref()"},{"line_number":999,"context_line":"        PROVIDERS.resource_api.create_domain(domain[\u0027id\u0027], domain)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_98ffb066","line":996,"range":{"start_line":996,"start_character":8,"end_line":996,"end_character":51},"updated":"2018-05-05 02:45:14.000000000","message":"name in PS2 looks better, fine as it is.","commit_id":"f1432f9ade7c18eab25fa4c1d0f682d473fecbfb"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c188267898f4fe6e5a83b93bba283e81cc30db24","unresolved":false,"context_lines":[{"line_number":993,"context_line":"        # since it wasn\u0027t auto-generated"},{"line_number":994,"context_line":"        self.assertIsNotNone(PROVIDERS.resource_api.get_domain(domain[\u0027id\u0027]))"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    def test_create_idp_domain_id_unique_constraint(self):"},{"line_number":997,"context_line":"        # create domain and add domain_id to keys to check"},{"line_number":998,"context_line":"        domain \u003d unit.new_domain_ref()"},{"line_number":999,"context_line":"        PROVIDERS.resource_api.create_domain(domain[\u0027id\u0027], domain)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_aae1e99c","line":996,"range":{"start_line":996,"start_character":8,"end_line":996,"end_character":51},"in_reply_to":"5f7c97a3_98ffb066","updated":"2018-05-07 01:48:53.000000000","message":"Done","commit_id":"f1432f9ade7c18eab25fa4c1d0f682d473fecbfb"}]}