)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9d9f0a175dcbb4fd961ea07012558ee37800f86f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The protocol_id and idp_id in federated user table is cascading"},{"line_number":10,"context_line":"deleted with the federation_protocol table. But the sql model"},{"line_number":11,"context_line":"doesn\u0027t. The model lost \u0027CASCADE\u0027 property."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I26f0cd600aa6248da4f190e933129bf2b7de1284"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_6fbe0eb5","line":11,"updated":"2018-08-13 06:29:10.000000000","message":"Interesting, when did this regress?","commit_id":"1a36404705c9098f4140cc2a270ae51f6f76d038"}],"keystone/identity/backends/sql_model.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9d9f0a175dcbb4fd961ea07012558ee37800f86f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        sqlalchemy.ForeignKeyConstraint([\u0027protocol_id\u0027, \u0027idp_id\u0027],"},{"line_number":352,"context_line":"                                        [\u0027federation_protocol.id\u0027,"},{"line_number":353,"context_line":"                                         \u0027federation_protocol.idp_id\u0027],"},{"line_number":354,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027)"},{"line_number":355,"context_line":"    )"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0faf5a7d","line":354,"updated":"2018-08-13 06:29:10.000000000","message":"Can we add a SQL test case for this so that we don\u0027t accidentally lose this in the future?","commit_id":"1a36404705c9098f4140cc2a270ae51f6f76d038"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"242ce1c21f1a878e15f500eeac90481576252a16","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        sqlalchemy.ForeignKeyConstraint([\u0027protocol_id\u0027, \u0027idp_id\u0027],"},{"line_number":352,"context_line":"                                        [\u0027federation_protocol.id\u0027,"},{"line_number":353,"context_line":"                                         \u0027federation_protocol.idp_id\u0027],"},{"line_number":354,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027)"},{"line_number":355,"context_line":"    )"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d24b4528","line":354,"in_reply_to":"3f79a3b5_0faf5a7d","updated":"2018-08-13 06:53:30.000000000","message":"Digging through the code and [0] seems to pop out as something that would fail if we implemented FKs in SQLite, but I\u0027m unable to tell for sure without testing the patches manually. \n\nI think it would be a good idea to explicitly test this, if not here in a follow on patch.\n\n[0] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_v3_federation.py#L1359","commit_id":"1a36404705c9098f4140cc2a270ae51f6f76d038"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"af7d8655ee2e9fa605c4f378c51d4eceb6fffa70","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        sqlalchemy.ForeignKeyConstraint([\u0027protocol_id\u0027, \u0027idp_id\u0027],"},{"line_number":352,"context_line":"                                        [\u0027federation_protocol.id\u0027,"},{"line_number":353,"context_line":"                                         \u0027federation_protocol.idp_id\u0027],"},{"line_number":354,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027)"},{"line_number":355,"context_line":"    )"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9eda8875","line":354,"in_reply_to":"3f79a3b5_145765cc","updated":"2018-08-15 07:53:19.000000000","message":"Added a test here https://review.openstack.org/#/c/591946/ after enabling fk for unit test.","commit_id":"1a36404705c9098f4140cc2a270ae51f6f76d038"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"521a05f4e4b84aa41aafdd4de5b3d04a3fe3cfab","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        sqlalchemy.ForeignKeyConstraint([\u0027protocol_id\u0027, \u0027idp_id\u0027],"},{"line_number":352,"context_line":"                                        [\u0027federation_protocol.id\u0027,"},{"line_number":353,"context_line":"                                         \u0027federation_protocol.idp_id\u0027],"},{"line_number":354,"context_line":"                                        ondelete\u003d\u0027CASCADE\u0027)"},{"line_number":355,"context_line":"    )"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_145765cc","line":354,"in_reply_to":"3f79a3b5_d24b4528","updated":"2018-08-13 12:27:09.000000000","message":"when enable FK in unit test, this test will fail: http://paste.openstack.org/show/727922/","commit_id":"1a36404705c9098f4140cc2a270ae51f6f76d038"}]}