)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"59eafaffd1a9d5134083cc3a86b580d703f17f32","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"standard-threads\", \"pydev-debug-host\" and \"pydev-debug-port\""},{"line_number":10,"context_line":"cli configuration items were only uesed by Keystone eventlet model"},{"line_number":11,"context_line":"in a few releases before. Deprecate them now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If4f2f318999fc291ce93b12ce57a95dfca5dcf05"},{"line_number":14,"context_line":"bp: deprecated-as-of-stein"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_834eda6a","line":11,"updated":"2018-10-25 12:33:16.000000000","message":"Pl see my above comment","commit_id":"4b05183612d7739bfbec937946e54a1cdaf0aae6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3f1927bd9b24f7199a48add9f057409defd9d184","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate eventlet related configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"standard-threads\", \"pydev-debug-host\" and \"pydev-debug-port\""},{"line_number":10,"context_line":"cli configuration items were only uesed by Keystone eventlet model"},{"line_number":11,"context_line":"in Netwon release. Deprecate them now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If4f2f318999fc291ce93b12ce57a95dfca5dcf05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_09da8fe5","line":10,"updated":"2018-10-31 00:28:11.000000000","message":"used","commit_id":"2b27fa47f9519951af7d90f9cb681091249e3778"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3f1927bd9b24f7199a48add9f057409defd9d184","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \"standard-threads\", \"pydev-debug-host\" and \"pydev-debug-port\""},{"line_number":10,"context_line":"cli configuration items were only uesed by Keystone eventlet model"},{"line_number":11,"context_line":"in Netwon release. Deprecate them now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If4f2f318999fc291ce93b12ce57a95dfca5dcf05"},{"line_number":14,"context_line":"bp: deprecated-as-of-stein"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_49d087c7","line":11,"updated":"2018-10-31 00:28:11.000000000","message":"typo Newton","commit_id":"2b27fa47f9519951af7d90f9cb681091249e3778"}],"keystone/conf/__init__.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8cf1ce99b3b664ca13e7b10635510ca54272e055","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    if conf is None:"},{"line_number":121,"context_line":"        conf \u003d CONF"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    conf.register_cli_opt("},{"line_number":124,"context_line":"        cfg.BoolOpt(\u0027standard-threads\u0027, default\u003dFalse,"},{"line_number":125,"context_line":"                    help\u003d\u0027Do not monkey-patch threading system modules.\u0027))"},{"line_number":126,"context_line":"    conf.register_cli_opt("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc3d4ac4","side":"PARENT","line":123,"updated":"2018-05-16 15:11:33.000000000","message":"Did we ever formally deprecate this stuff? I wonder if developers are using it anywhere?","commit_id":"f45f922a52afdab2bb7b7979de227989549f7221"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"431046b5c953ac9f1aa895adfb93933b359c1ee7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    if conf is None:"},{"line_number":121,"context_line":"        conf \u003d CONF"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    conf.register_cli_opt("},{"line_number":124,"context_line":"        cfg.BoolOpt(\u0027standard-threads\u0027, default\u003dFalse,"},{"line_number":125,"context_line":"                    help\u003d\u0027Do not monkey-patch threading system modules.\u0027))"},{"line_number":126,"context_line":"    conf.register_cli_opt("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0017b5f0","side":"PARENT","line":123,"in_reply_to":"5f7c97a3_c89c926c","updated":"2018-06-28 13:08:45.000000000","message":"I think it would be good to formally deprecate them. Even if they don\u0027t do anything anymore, people have automation around the CLI that includes random flags and their automation will break if the flags are just yanked.","commit_id":"f45f922a52afdab2bb7b7979de227989549f7221"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"526b1ee3c326146803da944f087b3ef3530079ac","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    if conf is None:"},{"line_number":121,"context_line":"        conf \u003d CONF"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    conf.register_cli_opt("},{"line_number":124,"context_line":"        cfg.BoolOpt(\u0027standard-threads\u0027, default\u003dFalse,"},{"line_number":125,"context_line":"                    help\u003d\u0027Do not monkey-patch threading system modules.\u0027))"},{"line_number":126,"context_line":"    conf.register_cli_opt("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c89c926c","side":"PARENT","line":123,"in_reply_to":"5f7c97a3_dc3d4ac4","updated":"2018-05-17 09:37:12.000000000","message":"They were used for eventlet which was deprecated and removed a few release ago:\nhttps://github.com/openstack/keystone/blob/mitaka-eol/keystone/server/eventlet.py#L110-L112\n\nBut TBH, these three configuration didn\u0027t be deprecated by the config options way. So for eventlet sight, it\u0027s safe enough to remove them. For config options sight, we should deprecated them first.\n\nBoth of them works for me. Any idea?","commit_id":"f45f922a52afdab2bb7b7979de227989549f7221"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"f07ea59246c7631311f0d8d574ed4f1e28cff834","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"oslo_messaging.set_transport_defaults(control_exchange\u003d\u0027keystone\u0027)"},{"line_number":92,"context_line":"_DEPRECATED_REASON \u003d (\u0027This option is only used by eventlet mode which has\u0027"},{"line_number":93,"context_line":"                      \u0027been removed from Keystone for a few release.\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def set_default_for_default_log_levels():"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_800b302b","line":93,"updated":"2018-10-25 12:32:29.000000000","message":"little confusing \"For a few release\", We can mention which has been removed from N release of keystone.\n\nJust for the reference [1]\n[1] https://review.openstack.org/#/c/249486/","commit_id":"4b05183612d7739bfbec937946e54a1cdaf0aae6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b751edd290296a39af08b5aff7befbf6780f6386","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"oslo_messaging.set_transport_defaults(control_exchange\u003d\u0027keystone\u0027)"},{"line_number":92,"context_line":"_DEPRECATED_REASON \u003d (\u0027This option is only used by eventlet mode which has\u0027"},{"line_number":93,"context_line":"                      \u0027been removed from Keystone for a few release.\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def set_default_for_default_log_levels():"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5a6e15cc","line":93,"in_reply_to":"3f79a3b5_800b302b","updated":"2018-10-30 12:47:22.000000000","message":"Looks like that patch merged when Newton was under development.","commit_id":"4b05183612d7739bfbec937946e54a1cdaf0aae6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3f1927bd9b24f7199a48add9f057409defd9d184","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"oslo_messaging.set_transport_defaults(control_exchange\u003d\u0027keystone\u0027)"},{"line_number":92,"context_line":"_DEPRECATED_REASON \u003d (\u0027This option is only used by eventlet mode which has\u0027"},{"line_number":93,"context_line":"                      \u0027been removed from Keystone in Netwon release.\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def set_default_for_default_log_levels():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_69e2239f","line":93,"range":{"start_line":93,"start_character":52,"end_line":93,"end_character":60},"updated":"2018-10-31 00:28:11.000000000","message":"ditto","commit_id":"2b27fa47f9519951af7d90f9cb681091249e3778"}],"releasenotes/notes/deprecated-as-of-stein-0166965502cb3be2.yaml":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"f07ea59246c7631311f0d8d574ed4f1e28cff834","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    The commandline options `standard-threads, `pydev-debug-host` and"},{"line_number":5,"context_line":"    `pydev-debug-port` are only used by Keystone eventlet model in a few"},{"line_number":6,"context_line":"    releases before. They are deprecated now and will be removed in the next"},{"line_number":7,"context_line":"    release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_00ff2003","line":6,"updated":"2018-10-25 12:32:29.000000000","message":"ditto","commit_id":"4b05183612d7739bfbec937946e54a1cdaf0aae6"}]}