)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"673dd23f2bcf4d463df77f8ee7a30ac2c9416822","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The `test_change_user_password_also_deletes_tokens` test was not"},{"line_number":10,"context_line":"utilizing .get and therefore was not getting the \u0027/v3\u0027 prepended to"},{"line_number":11,"context_line":"the /auth/tokens request path. This resulted in an erroneous 404"},{"line_number":12,"context_line":"response from the server (in flask this generates as an text/html"},{"line_number":13,"context_line":"404 instead of an application handled application/json 404). This"},{"line_number":14,"context_line":"test would always succeed in the last step as the token was not"},{"line_number":15,"context_line":"actually validated. The 404 response was generated due to the"},{"line_number":16,"context_line":"lack of routing instead of the lack of a valid token."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_a37b79f2","line":13,"range":{"start_line":12,"start_character":24,"end_line":13,"end_character":59},"updated":"2018-06-04 14:29:11.000000000","message":"Nice - thanks for adding this. This helped me figure out what this was such a problem for you with the flask work (before is wasn\u0027t quite apparent to me).\n\nFor API contracts, is a HTTP 404 Not Found with application/json the same as HTTP 404 Not Found with text/html?\n\nI assume if HTTP 404 Not Found with text/html is built into a framework and probably the correct way to do things and out homegrown implementation was probably wrong. But does that technically classify as a backwards incompatible change? Or is it really just the http status code?","commit_id":"a9b415cddf1821b2ac1d855f947a2a6fa475a6d0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d6aec8ba66c18e52ff6c91c6eb7d6238aeecd4e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The `test_change_user_password_also_deletes_tokens` test was not"},{"line_number":10,"context_line":"utilizing .get and therefore was not getting the \u0027/v3\u0027 prepended to"},{"line_number":11,"context_line":"the /auth/tokens request path. This resulted in an erroneous 404"},{"line_number":12,"context_line":"response from the server (in flask this generates as an text/html"},{"line_number":13,"context_line":"404 instead of an application handled application/json 404). This"},{"line_number":14,"context_line":"test would always succeed in the last step as the token was not"},{"line_number":15,"context_line":"actually validated. The 404 response was generated due to the"},{"line_number":16,"context_line":"lack of routing instead of the lack of a valid token."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_667b2e7b","line":13,"range":{"start_line":12,"start_character":24,"end_line":13,"end_character":59},"in_reply_to":"5f7c97a3_43d70451","updated":"2018-06-04 14:55:50.000000000","message":"Sounds like a useful distinction to me, but I\u0027ll let other weigh in.","commit_id":"a9b415cddf1821b2ac1d855f947a2a6fa475a6d0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"85b82562ae6d6776a1bcece02b8a7f16b62eef8b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The `test_change_user_password_also_deletes_tokens` test was not"},{"line_number":10,"context_line":"utilizing .get and therefore was not getting the \u0027/v3\u0027 prepended to"},{"line_number":11,"context_line":"the /auth/tokens request path. This resulted in an erroneous 404"},{"line_number":12,"context_line":"response from the server (in flask this generates as an text/html"},{"line_number":13,"context_line":"404 instead of an application handled application/json 404). This"},{"line_number":14,"context_line":"test would always succeed in the last step as the token was not"},{"line_number":15,"context_line":"actually validated. The 404 response was generated due to the"},{"line_number":16,"context_line":"lack of routing instead of the lack of a valid token."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_43d70451","line":13,"range":{"start_line":12,"start_character":24,"end_line":13,"end_character":59},"in_reply_to":"5f7c97a3_a37b79f2","updated":"2018-06-04 14:32:54.000000000","message":"It\u0027s the same Status code, it probably is more correct this way. We\u0027re changing the response but... not in a meaningful way. It makes it so folks know if they hit an API or not.\n\nI don\u0027t see it as a breaking change, unless someone was hitting a non-routed api and assuming it was routed (and liked that)","commit_id":"a9b415cddf1821b2ac1d855f947a2a6fa475a6d0"}]}