)]}'
{"keystone/contrib/ec2/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3d172670350ed780626420ca047e00176d7f8463","unresolved":false,"context_lines":[{"line_number":55,"context_line":"PROVIDERS \u003d provider_api.ProviderAPIs"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class V2TokenDataHelper(provider_api.ProviderAPIMixin, object):"},{"line_number":59,"context_line":"    \"\"\"Create V2 token data.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def v3_to_v2_token(self, v3_token_data, token_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_90b6858a","side":"PARENT","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":23},"updated":"2018-06-06 19:48:18.000000000","message":"YASS!","commit_id":"7c5dea74d9108f0149a058639d4384ed451b1143"}],"keystone/tests/unit/test_versions.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3d172670350ed780626420ca047e00176d7f8463","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        data \u003d jsonutils.loads(resp.body)"},{"line_number":710,"context_line":"        expected \u003d VERSIONS_RESPONSE"},{"line_number":711,"context_line":"        for version in expected[\u0027versions\u0027][\u0027values\u0027]:"},{"line_number":712,"context_line":"            if version[\u0027id\u0027].startswith(\u0027v3\u0027):"},{"line_number":713,"context_line":"                self._paste_in_port("},{"line_number":714,"context_line":"                    version, \u0027http://localhost:%s/v3/\u0027 % self.public_port)"},{"line_number":715,"context_line":"        self.assertThat(data, _VersionsEqual(expected))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_500c6d41","line":712,"range":{"start_line":712,"start_character":12,"end_line":712,"end_character":46},"updated":"2018-06-06 19:48:18.000000000","message":"Do we need this conditional anymore?","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0925d847b49f43b1ab89402702a38859510a2bef","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        data \u003d jsonutils.loads(resp.body)"},{"line_number":710,"context_line":"        expected \u003d VERSIONS_RESPONSE"},{"line_number":711,"context_line":"        for version in expected[\u0027versions\u0027][\u0027values\u0027]:"},{"line_number":712,"context_line":"            if version[\u0027id\u0027].startswith(\u0027v3\u0027):"},{"line_number":713,"context_line":"                self._paste_in_port("},{"line_number":714,"context_line":"                    version, \u0027http://localhost:%s/v3/\u0027 % self.public_port)"},{"line_number":715,"context_line":"        self.assertThat(data, _VersionsEqual(expected))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8bd41321","line":712,"range":{"start_line":712,"start_character":12,"end_line":712,"end_character":46},"in_reply_to":"5f7c97a3_500c6d41","updated":"2018-06-06 19:53:57.000000000","message":"All of the conditionals were left as scaffolding incase we wanted a v4. Removing them should be added as another patch on the end of the series.\n\nI am happy to remove them.","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3d172670350ed780626420ca047e00176d7f8463","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        data \u003d jsonutils.loads(resp.body)"},{"line_number":722,"context_line":"        expected \u003d VERSIONS_RESPONSE"},{"line_number":723,"context_line":"        for version in expected[\u0027versions\u0027][\u0027values\u0027]:"},{"line_number":724,"context_line":"            if version[\u0027id\u0027].startswith(\u0027v3\u0027):"},{"line_number":725,"context_line":"                self._paste_in_port("},{"line_number":726,"context_line":"                    version, \u0027http://localhost:%s/v3/\u0027 % self.admin_port)"},{"line_number":727,"context_line":"        self.assertThat(data, _VersionsEqual(expected))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f01b397d","line":724,"range":{"start_line":724,"start_character":12,"end_line":724,"end_character":46},"updated":"2018-06-06 19:48:18.000000000","message":"Do we need this conditional anymore?","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3d172670350ed780626420ca047e00176d7f8463","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            expected \u003d VERSIONS_RESPONSE"},{"line_number":738,"context_line":"            for version in expected[\u0027versions\u0027][\u0027values\u0027]:"},{"line_number":739,"context_line":"                # localhost happens to be the site url for tests"},{"line_number":740,"context_line":"                if version[\u0027id\u0027].startswith(\u0027v3\u0027):"},{"line_number":741,"context_line":"                    self._paste_in_port("},{"line_number":742,"context_line":"                        version, \u0027http://localhost/v3/\u0027)"},{"line_number":743,"context_line":"            self.assertThat(data, _VersionsEqual(expected))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7007291f","line":740,"updated":"2018-06-06 19:48:18.000000000","message":"Same comment here as above.","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3d172670350ed780626420ca047e00176d7f8463","unresolved":false,"context_lines":[{"line_number":932,"context_line":"        data \u003d jsonutils.loads(resp.body)"},{"line_number":933,"context_line":"        expected \u003d VERSIONS_RESPONSE"},{"line_number":934,"context_line":"        for version in expected[\u0027versions\u0027][\u0027values\u0027]:"},{"line_number":935,"context_line":"            if version[\u0027id\u0027].startswith(\u0027v3\u0027):"},{"line_number":936,"context_line":"                self._paste_in_port("},{"line_number":937,"context_line":"                    version, \u0027http://localhost:%s/v3/\u0027 % app_port())"},{"line_number":938,"context_line":"        self.assertThat(data, _VersionsEqual(expected))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cbfd2c09","line":935,"updated":"2018-06-06 19:48:18.000000000","message":"Same comment here as above.","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"}],"keystone/tests/unit/token/test_fernet_provider.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d5fdfec291f2dc646259c2b9aeb0ba6581db2523","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            token_id)"},{"line_number":56,"context_line":"        self.assertIn(token_id, u\u0027%s\u0027 % e)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_invalid_v2_token_raises_token_not_found(self):"},{"line_number":59,"context_line":"        # NOTE(morgan): Kept for regression testing, should not be deleted"},{"line_number":60,"context_line":"        # even though it references V2.0"},{"line_number":61,"context_line":"        token_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4b5b5bf5","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":29},"updated":"2018-06-06 19:50:19.000000000","message":"Maybe updating the test name to not reference v2 would be good and remove the need for a comment.","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0925d847b49f43b1ab89402702a38859510a2bef","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            token_id)"},{"line_number":56,"context_line":"        self.assertIn(token_id, u\u0027%s\u0027 % e)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_invalid_v2_token_raises_token_not_found(self):"},{"line_number":59,"context_line":"        # NOTE(morgan): Kept for regression testing, should not be deleted"},{"line_number":60,"context_line":"        # even though it references V2.0"},{"line_number":61,"context_line":"        token_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ebcd8786","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":29},"in_reply_to":"5f7c97a3_4b5b5bf5","updated":"2018-06-06 19:53:57.000000000","message":"ah, yes. that we should do, i\u0027ll isolate this to a separate fix.","commit_id":"c298788ec86ccedcb45de46e28a76981db2dcf90"}]}