)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e1f765bef4b3b5e3239b76d6f08ba5586f8c88f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove get_catalog usage from contrib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_catalog is only used for V2 APIs, this patch removed"},{"line_number":10,"context_line":"the usage from contrib."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idcc236d3835ba02a2aefac5de68ebaa37aa1496b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_70898423","line":9,"updated":"2018-07-24 13:45:20.000000000","message":"But we still support the v2 API for ec2, can you explain more why you are changing this?","commit_id":"2528fa78fb1bbb18fc38af5af11415b9fe32792b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3c705e34dc249e0ec9608fb598bc52665b7e32fe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove get_catalog usage from contrib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_catalog is only used for V2 APIs, this patch removed"},{"line_number":10,"context_line":"the usage from contrib."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idcc236d3835ba02a2aefac5de68ebaa37aa1496b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d0189320","line":9,"in_reply_to":"5f7c97a3_70898423","updated":"2018-07-24 16:30:37.000000000","message":"The V2 support has been removed here if i remember correctly.\nhttps://github.com/openstack/keystone/commit/0211cdd05fd54cf69ecb3e1c34f96d8cf6fb06e9","commit_id":"2528fa78fb1bbb18fc38af5af11415b9fe32792b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"736f6facc2b9f3b638bd55958d3428bbcefd884d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove get_catalog usage from contrib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_catalog is only used for V2 APIs, this patch removed"},{"line_number":10,"context_line":"the usage from contrib."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idcc236d3835ba02a2aefac5de68ebaa37aa1496b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_df5deeeb","line":9,"in_reply_to":"5f7c97a3_d0189320","updated":"2018-07-25 09:03:10.000000000","message":"Sorry, you\u0027re correct, there\u0027s no more v2 API.\n\nIt looks like the usage of the catalog_ref from the _authenticate method was removed in this commit https://review.openstack.org/#/c/465530","commit_id":"2528fa78fb1bbb18fc38af5af11415b9fe32792b"}],"keystone/contrib/ec2/controllers.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"736f6facc2b9f3b638bd55958d3428bbcefd884d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _authenticate(self, credentials\u003dNone, ec2credentials\u003dNone):"},{"line_number":114,"context_line":"        \"\"\"Common code shared between the V2 and V3 authenticate methods."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :returns: user_ref, tenant_ref, roles_ref, catalog_ref"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        # FIXME(ja): validate that a service token was used!"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1f2b667c","line":116,"range":{"start_line":116,"start_character":51,"end_line":116,"end_character":62},"updated":"2018-07-25 09:03:10.000000000","message":"Could you fix this too?","commit_id":"2528fa78fb1bbb18fc38af5af11415b9fe32792b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7ee0faf384006a77fb99bbff4f7586250fd94784","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _authenticate(self, credentials\u003dNone, ec2credentials\u003dNone):"},{"line_number":114,"context_line":"        \"\"\"Common code shared between the V2 and V3 authenticate methods."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :returns: user_ref, tenant_ref, roles_ref, catalog_ref"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        # FIXME(ja): validate that a service token was used!"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f9d474be","line":116,"range":{"start_line":116,"start_character":51,"end_line":116,"end_character":62},"in_reply_to":"5f7c97a3_1f2b667c","updated":"2018-07-26 01:28:39.000000000","message":"Done","commit_id":"2528fa78fb1bbb18fc38af5af11415b9fe32792b"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"6213ee00d050302594f38fd7c6faed2767ce4e8b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                message\u003d_(\u0027User not valid for tenant.\u0027))"},{"line_number":154,"context_line":"        roles_ref \u003d [self.role_api.get_role(role_id) for role_id in roles]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        catalog_ref \u003d self.catalog_api.get_catalog("},{"line_number":157,"context_line":"            user_ref[\u0027id\u0027], tenant_ref[\u0027id\u0027])"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        return user_ref, tenant_ref, roles_ref, catalog_ref"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def create_credential(self, request, user_id, tenant_id):"},{"line_number":162,"context_line":"        \"\"\"Create a secret/access pair for use with ec2 style auth."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2b7252b1","side":"PARENT","line":159,"range":{"start_line":156,"start_character":0,"end_line":159,"end_character":59},"updated":"2018-07-29 10:42:57.000000000","message":"A little surprise that there is no testcases to validate the value returned.","commit_id":"31bc69300135425306db1106bbc5d132e0e99a62"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"6213ee00d050302594f38fd7c6faed2767ce4e8b","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        self.check_protection(request, prep_info, ref)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def authenticate(self, context, credentials\u003dNone, ec2Credentials\u003dNone):"},{"line_number":293,"context_line":"        (user_ref, project_ref, roles_ref, catalog_ref) \u003d self._authenticate("},{"line_number":294,"context_line":"            credentials\u003dcredentials, ec2credentials\u003dec2Credentials"},{"line_number":295,"context_line":"        )"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4b778ea0","side":"PARENT","line":293,"updated":"2018-07-29 10:42:57.000000000","message":"Looks like catalog_ref doesn\u0027t has anything to the result of ec2 `authenticae` process.","commit_id":"31bc69300135425306db1106bbc5d132e0e99a62"}]}