)]}'
{"keystone/auth/plugins/mapped.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9111a26dbc22fc7e45e3bd91dd1d726398da7b35","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        user_id \u003d user_name"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    if user_name:"},{"line_number":377,"context_line":"        user[\u0027name\u0027] \u003d user_name"},{"line_number":378,"context_line":"    user[\u0027id\u0027] \u003d parse.quote(user_id)"},{"line_number":379,"context_line":"    return (user[\u0027id\u0027], user[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e1203afb","line":377,"updated":"2018-06-19 18:25:27.000000000","message":"I was able to revert this change locally and the test didn\u0027t fail when I re-ran it. The test might need some additional work to hit this case?\n\nMy changes: http://paste.openstack.org/show/723849/\nTest results: http://paste.openstack.org/show/723850/","commit_id":"f07c2355d1c49ca3a19374de75afe542048fa24b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"e1b3f9d560f7a3af6ae933c22bc36ff7447970fa","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        user_id \u003d user_name"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    if user_name:"},{"line_number":377,"context_line":"        user[\u0027name\u0027] \u003d user_name"},{"line_number":378,"context_line":"    user[\u0027id\u0027] \u003d parse.quote(user_id)"},{"line_number":379,"context_line":"    return (user[\u0027id\u0027], user[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_692cd149","line":377,"in_reply_to":"5f7c97a3_e1203afb","updated":"2018-06-22 06:26:50.000000000","message":"Thanks for the comment. Changed the test case. Kindly check","commit_id":"f07c2355d1c49ca3a19374de75afe542048fa24b"}],"keystone/tests/unit/contrib/federation/test_utils.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"fb5f0db6d8aef243c5286fc6c001804ace89e733","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_get_user_unique_id_and_display_name(self):"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_EPHEMERAL_USER"},{"line_number":567,"context_line":"        assertion \u003d mapping_fixtures.EMPLOYEE_ASSERTION"},{"line_number":568,"context_line":"        FAKE_MAPPING_ID \u003d uuid.uuid4().hex"},{"line_number":569,"context_line":"        request \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4f634842","line":566,"updated":"2018-06-20 08:47:26.000000000","message":"I think it\u0027s because the mapping here uses user name, may try to use MAPPING_USER_IDS and \"bob\" remote user.","commit_id":"f07c2355d1c49ca3a19374de75afe542048fa24b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"e1b3f9d560f7a3af6ae933c22bc36ff7447970fa","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_get_user_unique_id_and_display_name(self):"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_EPHEMERAL_USER"},{"line_number":567,"context_line":"        assertion \u003d mapping_fixtures.EMPLOYEE_ASSERTION"},{"line_number":568,"context_line":"        FAKE_MAPPING_ID \u003d uuid.uuid4().hex"},{"line_number":569,"context_line":"        request \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_89312da5","line":566,"in_reply_to":"5f7c97a3_4f634842","updated":"2018-06-22 06:26:50.000000000","message":"Thanks for the comment. Uploaded a new set.","commit_id":"f07c2355d1c49ca3a19374de75afe542048fa24b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"08d728d5dc35bf54d9646db3d9eb02db474d8d49","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    def test_get_user_unique_id_and_display_name(self):"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_USER_IDS"},{"line_number":567,"context_line":"        assertion \u003d mapping_fixtures.EMPLOYEE_ASSERTION"},{"line_number":568,"context_line":"        FAKE_MAPPING_ID \u003d uuid.uuid4().hex"},{"line_number":569,"context_line":"        request \u003d webob.Request.blank(\u0027/\u0027)"},{"line_number":570,"context_line":"        rp \u003d mapping_utils.RuleProcessor(FAKE_MAPPING_ID, mapping[\u0027rules\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_084aa525","line":567,"range":{"start_line":567,"start_character":37,"end_line":567,"end_character":55},"updated":"2018-06-27 03:49:31.000000000","message":"I think we want to test the case that the user_name is missing, not is None.\nSo please use ADMIN_ASSERTION here, so that you don\u0027t need to set user_name\u003dNone at L574","commit_id":"ecefe392838317e73cf0105399e44788e621b74b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"b5b9c31877ef860fde6cced955208b564a648ace","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    def test_get_user_unique_id_and_display_name(self):"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_USER_IDS"},{"line_number":567,"context_line":"        assertion \u003d mapping_fixtures.EMPLOYEE_ASSERTION"},{"line_number":568,"context_line":"        FAKE_MAPPING_ID \u003d uuid.uuid4().hex"},{"line_number":569,"context_line":"        request \u003d webob.Request.blank(\u0027/\u0027)"},{"line_number":570,"context_line":"        rp \u003d mapping_utils.RuleProcessor(FAKE_MAPPING_ID, mapping[\u0027rules\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b3ebe6da","line":567,"range":{"start_line":567,"start_character":37,"end_line":567,"end_character":55},"in_reply_to":"5f7c97a3_084aa525","updated":"2018-06-27 05:31:23.000000000","message":"Thank for the comment wangxiyuan. Looking into ADMIN_ASSERTION it is setting user name \u003d bob. In that case also I have to set username\u003dNone.","commit_id":"ecefe392838317e73cf0105399e44788e621b74b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"46af83b815cf4fd2800d3564279e44e532040ba5","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    def test_get_user_unique_id_and_display_name(self):"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_USER_IDS"},{"line_number":567,"context_line":"        assertion \u003d mapping_fixtures.EMPLOYEE_ASSERTION"},{"line_number":568,"context_line":"        FAKE_MAPPING_ID \u003d uuid.uuid4().hex"},{"line_number":569,"context_line":"        request \u003d webob.Request.blank(\u0027/\u0027)"},{"line_number":570,"context_line":"        rp \u003d mapping_utils.RuleProcessor(FAKE_MAPPING_ID, mapping[\u0027rules\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ee3ad1ca","line":567,"range":{"start_line":567,"start_character":37,"end_line":567,"end_character":55},"in_reply_to":"5f7c97a3_b3ebe6da","updated":"2018-06-27 06:27:54.000000000","message":"No, if using ADMIN_ASSERTION, the \"mapped_properties\" will contain no user_name, because the mapping only transfter \"UserName\" to \"ID\" for bob: https://github.com/openstack/keystone/blob/master/keystone/tests/unit/mapping_fixtures.py#L941-L959\n\nThis patch want to test the case that KeyError won\u0027t happen, but in your test ,you set mapped_properties[\"user\"][\"name\"] \u003d None at L574, it means that the KeyError won\u0027t happen even without the change in this patch.\n\nThe test can be changed to:\nhttp://paste.openstack.org/show/724370/\n\nThen the test will raise KeyError before the fix in this patch, and will be passed after the fix.","commit_id":"ecefe392838317e73cf0105399e44788e621b74b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c4a1ef47fd8abafdfb39dde571600480f61c1160","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        self.assertEqual(\u0027bob\u0027, display_name)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_get_user_unique_id_and_display_name(self):"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        mapping \u003d mapping_fixtures.MAPPING_USER_IDS"},{"line_number":567,"context_line":"        assertion \u003d mapping_fixtures.ADMIN_ASSERTION"},{"line_number":568,"context_line":"        FAKE_MAPPING_ID \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_181df30f","line":565,"updated":"2018-06-28 09:17:31.000000000","message":"It would be good if this test had a docstring explaining the test plan and what the expected inputs and results are, like the reasoning behind using ADMIN_ASSERTION that wxy explained in ps2. Unfortunately I can tell that the docstrings for the other tests have been cargoculted and are incorrect, so missing it here does not really make it worse off than those.","commit_id":"f4729795ecfbc53ae391204726fd441ce4b462ef"}]}