)]}'
{"keystone/auth/plugins/external.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2f998b40b91dd3508fed24e88e73489270f238b2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        response_data[\u0027user_id\u0027] \u003d user_ref[\u0027id\u0027]"},{"line_number":52,"context_line":"        auth_type \u003d (request.auth_type or \u0027\u0027).lower()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if \u0027kerberos\u0027 in CONF.token.bind and auth_type \u003d\u003d \u0027negotiate\u0027:"},{"line_number":55,"context_line":"            response_data.setdefault(\u0027bind\u0027, {})[\u0027kerberos\u0027] \u003d user_ref[\u0027name\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        return base.AuthHandlerResponse(status\u003dTrue, response_body\u003dNone,"},{"line_number":58,"context_line":"                                        response_data\u003dresponse_data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4a839fcc","side":"PARENT","line":55,"range":{"start_line":54,"start_character":7,"end_line":55,"end_character":79},"updated":"2018-06-27 18:48:55.000000000","message":"Since CONF.token.bind wasn\u0027t actually deprecated properly, I\u0027m failing to understand the effects of removing this. If an operator had set [token]/bind\u003dkerberos and a user has set os_auth_type\u003dnegotiate, has that just been 500ing since we removed uuid tokens?","commit_id":"057c59f16fc04e5d4e63f408ac5810ebe6d5ac99"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c8797ac6321b8c536bac977f32c9288e15f627e1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        response_data[\u0027user_id\u0027] \u003d user_ref[\u0027id\u0027]"},{"line_number":52,"context_line":"        auth_type \u003d (request.auth_type or \u0027\u0027).lower()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if \u0027kerberos\u0027 in CONF.token.bind and auth_type \u003d\u003d \u0027negotiate\u0027:"},{"line_number":55,"context_line":"            response_data.setdefault(\u0027bind\u0027, {})[\u0027kerberos\u0027] \u003d user_ref[\u0027name\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        return base.AuthHandlerResponse(status\u003dTrue, response_body\u003dNone,"},{"line_number":58,"context_line":"                                        response_data\u003dresponse_data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7423e1ab","side":"PARENT","line":55,"range":{"start_line":54,"start_character":7,"end_line":55,"end_character":79},"in_reply_to":"5f7c97a3_4a839fcc","updated":"2018-06-27 20:21:10.000000000","message":"Worst case we would get hitting this I think [0]. I\u0027m also realizing the lack of documentation around *any* bind stuff.\n\nIf a deployment was using UUID and then switched to Fernet, they\u0027d be getting a 501 because fernet doesn\u0027t support unbound data in token payloads. If someone was using uuid and started consuming master, they\u0027d trip trying to start keystone.\n\n[0] https://git.openstack.org/cgit/openstack/keystone/tree/keystone/token/providers/common.py#n563","commit_id":"057c59f16fc04e5d4e63f408ac5810ebe6d5ac99"}],"keystone/conf/token.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"84a6ca54864b41011a74053f848102f328f3f027","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.conf import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"bind \u003d cfg.ListOpt("},{"line_number":22,"context_line":"    \u0027bind\u0027,"},{"line_number":23,"context_line":"    default\u003d[],"},{"line_number":24,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":25,"context_line":"This is a list of external authentication mechanisms which should add token"},{"line_number":26,"context_line":"binding metadata to tokens, such as `kerberos` or `x509`. Binding metadata is"},{"line_number":27,"context_line":"enforced according to the `[token] enforce_token_bind` option."},{"line_number":28,"context_line":"\"\"\"))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"enforce_token_bind \u003d cfg.StrOpt("},{"line_number":31,"context_line":"    \u0027enforce_token_bind\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_92a6db53","side":"PARENT","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":5},"updated":"2018-06-27 13:41:06.000000000","message":"This wasn\u0027t deprecated.","commit_id":"057c59f16fc04e5d4e63f408ac5810ebe6d5ac99"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6a89fb3eaa155d4b25e1b21f153ab0a3494a687c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.conf import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"bind \u003d cfg.ListOpt("},{"line_number":22,"context_line":"    \u0027bind\u0027,"},{"line_number":23,"context_line":"    default\u003d[],"},{"line_number":24,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":25,"context_line":"This is a list of external authentication mechanisms which should add token"},{"line_number":26,"context_line":"binding metadata to tokens, such as `kerberos` or `x509`. Binding metadata is"},{"line_number":27,"context_line":"enforced according to the `[token] enforce_token_bind` option."},{"line_number":28,"context_line":"\"\"\"))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"enforce_token_bind \u003d cfg.StrOpt("},{"line_number":31,"context_line":"    \u0027enforce_token_bind\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b8f5f553","side":"PARENT","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":5},"in_reply_to":"5f7c97a3_92a6db53","updated":"2018-06-27 15:09:09.000000000","message":"Reverted this change and added a note. This is probably safe to remove in Stein if it\u0027s currently ignored.","commit_id":"057c59f16fc04e5d4e63f408ac5810ebe6d5ac99"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2f998b40b91dd3508fed24e88e73489270f238b2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":26,"context_line":"This is a list of external authentication mechanisms which should add token"},{"line_number":27,"context_line":"binding metadata to tokens, such as `kerberos` or `x509`. Binding metadata is"},{"line_number":28,"context_line":"enforced according to the `[token] enforce_token_bind` option. Official support"},{"line_number":29,"context_line":"for binding metadata in tokens was deprecated in Pike and removed in Rocky."},{"line_number":30,"context_line":"This option no longer has any impact on the behavior of tokens and can be"},{"line_number":31,"context_line":"removed."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8a2bf7e8","line":28,"range":{"start_line":27,"start_character":58,"end_line":28,"end_character":62},"updated":"2018-06-27 18:48:55.000000000","message":"I guess this doesn\u0027t entirely make sense any more","commit_id":"23b0b0001fa7103cadfef80eb1101a4764cd3cf2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"235069b65ac487c95954e6663f4e1b30f21d7e1f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":26,"context_line":"This is a list of external authentication mechanisms which should add token"},{"line_number":27,"context_line":"binding metadata to tokens, such as `kerberos` or `x509`. Binding metadata is"},{"line_number":28,"context_line":"enforced according to the `[token] enforce_token_bind` option. Official support"},{"line_number":29,"context_line":"for binding metadata in tokens was deprecated in Pike and removed in Rocky."},{"line_number":30,"context_line":"This option no longer has any impact on the behavior of tokens and can be"},{"line_number":31,"context_line":"removed."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_57090729","line":28,"range":{"start_line":27,"start_character":58,"end_line":28,"end_character":62},"in_reply_to":"5f7c97a3_8a2bf7e8","updated":"2018-06-27 21:12:24.000000000","message":"Done","commit_id":"23b0b0001fa7103cadfef80eb1101a4764cd3cf2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"70e1ae611a81d34a802c6eef0cb944a55d36bb1f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"bind \u003d cfg.ListOpt("},{"line_number":21,"context_line":"    \u0027bind\u0027,"},{"line_number":22,"context_line":"    default\u003d[],"},{"line_number":23,"context_line":"    deprecated_since\u003dversionutils.deprecated.PIKE,"},{"line_number":24,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":26,"context_line":"This is a list of external authentication mechanisms which should add token"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_63ab2188","line":23,"range":{"start_line":23,"start_character":45,"end_line":23,"end_character":49},"updated":"2018-06-28 02:40:04.000000000","message":"PIKE?","commit_id":"dac4787f44fc414a99f73353d25ae1a258fb34d0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"01789dc2638f335085dbd9e5583f78b3c3288543","unresolved":false,"context_lines":[{"line_number":20,"context_line":"bind \u003d cfg.ListOpt("},{"line_number":21,"context_line":"    \u0027bind\u0027,"},{"line_number":22,"context_line":"    default\u003d[],"},{"line_number":23,"context_line":"    deprecated_since\u003dversionutils.deprecated.PIKE,"},{"line_number":24,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":26,"context_line":"This is a list of external authentication mechanisms which should add token"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_9b357848","line":23,"range":{"start_line":23,"start_character":45,"end_line":23,"end_character":49},"in_reply_to":"5f7c97a3_63ab2188","updated":"2018-06-28 13:50:08.000000000","message":"Yeah - unfortunately this should have been officially deprecated in https://review.openstack.org/#/c/428388/ but it wasn\u0027t. Putting PIKE on this so that it\u0027s at least accurate.","commit_id":"dac4787f44fc414a99f73353d25ae1a258fb34d0"}]}