)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"97dd24d2a9a1025b7cc62c1238cfb3bce91437af","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-07-26 11:04:17 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose random uuid bug in cadf notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8363f265faacb9ad5783b12d4a64b570b9af46f0"},{"line_number":10,"context_line":"Related-Bug: #1780503"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_67d651c7","line":8,"updated":"2018-07-27 15:59:35.000000000","message":"What\u0027s the bug?","commit_id":"5ea323b9d67d668656d052ef27ccff99d8c72d7c"}],"keystone/tests/unit/common/test_notifications.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61933c263156d2fc909d93ff9db1b9dab7577791","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"        while self._notifications:"},{"line_number":1137,"context_line":"            self._notifications.pop()"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        self.post(\u0027/auth/tokens\u0027, body\u003ddata)"},{"line_number":1140,"context_line":"        while self._notifications:"},{"line_number":1141,"context_line":"            note \u003d self._notifications.pop()"},{"line_number":1142,"context_line":"            initiator \u003d note[\u0027initiator\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_709952cd","line":1139,"updated":"2018-07-26 07:00:33.000000000","message":"so base on my previous comment. This line here actually sent two /auth/tokens request to Keystone. one without \u0027X-Auth-Token\u0027 header, but another with.\n\ntry to use \"self.get_scoped_token()\" here instead, there will be only one notification generated. then you don\u0027t need to compare all self._notifications at L1140.","commit_id":"4dc7e3ba7982479bc18b6a81878ed1d4460c3e5d"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"6a7fb440634e0eb35f88fcf018b5273991bf34bd","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"        while self._notifications:"},{"line_number":1137,"context_line":"            self._notifications.pop()"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        self.post(\u0027/auth/tokens\u0027, body\u003ddata)"},{"line_number":1140,"context_line":"        while self._notifications:"},{"line_number":1141,"context_line":"            note \u003d self._notifications.pop()"},{"line_number":1142,"context_line":"            initiator \u003d note[\u0027initiator\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_150fa28b","line":1139,"in_reply_to":"5f7c97a3_709952cd","updated":"2018-07-26 15:46:16.000000000","message":"Done, thanks for looking into this.","commit_id":"4dc7e3ba7982479bc18b6a81878ed1d4460c3e5d"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61933c263156d2fc909d93ff9db1b9dab7577791","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"                                                 user_domain_id\u003ddomain_id,"},{"line_number":1152,"context_line":"                                                 password\u003dpassword)"},{"line_number":1153,"context_line":"        self.post(\u0027/auth/tokens\u0027, body\u003ddata)"},{"line_number":1154,"context_line":"        self._assert_last_note(self.ACTION, user_id)"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    def test_v3_authenticate_user_id(self):"},{"line_number":1157,"context_line":"        user_id \u003d self.user_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_7082b253","line":1154,"updated":"2018-07-26 07:00:33.000000000","message":"This test passed because it compares the last notification which is generated by the request POST \u0027/auth/tokens\u0027 with \u0027X-Auth-Token\u0027 header.\n\nSo actually this is not a correct test IMO.","commit_id":"4dc7e3ba7982479bc18b6a81878ed1d4460c3e5d"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"6a7fb440634e0eb35f88fcf018b5273991bf34bd","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"                                                 user_domain_id\u003ddomain_id,"},{"line_number":1152,"context_line":"                                                 password\u003dpassword)"},{"line_number":1153,"context_line":"        self.post(\u0027/auth/tokens\u0027, body\u003ddata)"},{"line_number":1154,"context_line":"        self._assert_last_note(self.ACTION, user_id)"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    def test_v3_authenticate_user_id(self):"},{"line_number":1157,"context_line":"        user_id \u003d self.user_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d57daae6","line":1154,"in_reply_to":"5f7c97a3_7082b253","updated":"2018-07-26 15:46:16.000000000","message":"Yeah, this confused me for a bit (which is why I made another test instead of modifying this one). We can refactor this one later to be more accurate.","commit_id":"4dc7e3ba7982479bc18b6a81878ed1d4460c3e5d"}]}