)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4af00969042e7d8ea34b8e06c88869a76ff78ce1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When a path-prefix is moved to flask native dispatching, no longer"},{"line_number":10,"context_line":"allow that path prefix to be registered with the legacy dispatch"},{"line_number":11,"context_line":"middleware. This will ensure the entire Keystone path is moved"},{"line_number":12,"context_line":"and prevent bad behavior due to both dispatchers needing ot handle"},{"line_number":13,"context_line":"a URL."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ice800abf80a725349d6450b742a2c48238e11e6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_ec26d422","line":12,"range":{"start_line":12,"start_character":57,"end_line":12,"end_character":59},"updated":"2018-07-16 19:32:29.000000000","message":"nit: to\n\nonly if you have to rebase/respin for whatever reason though..","commit_id":"0d6b427fcc7f6b9b2a06bdd9a7af37064e7ddd51"}],"keystone/server/flask/application.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4af00969042e7d8ea34b8e06c88869a76ff78ce1","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(morgan): _MOVED_API_PREFIXES to be removed when the legacy dispatch"},{"line_number":47,"context_line":"# support is removed."},{"line_number":48,"context_line":"_MOVED_API_PREFIXES \u003d frozenset([])"},{"line_number":49,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ac09bc84","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":19},"updated":"2018-07-16 19:32:29.000000000","message":"When we get everything moved over to flask native, can we still keep this as a frozenset?","commit_id":"0d6b427fcc7f6b9b2a06bdd9a7af37064e7ddd51"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"425b35fde558d87605fb9aba4d0bf9e980735550","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(morgan): _MOVED_API_PREFIXES to be removed when the legacy dispatch"},{"line_number":47,"context_line":"# support is removed."},{"line_number":48,"context_line":"_MOVED_API_PREFIXES \u003d frozenset([])"},{"line_number":49,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6c096430","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":19},"in_reply_to":"5f7c97a3_ac09bc84","updated":"2018-07-16 19:47:51.000000000","message":"We can, we can also just make it disappear.","commit_id":"0d6b427fcc7f6b9b2a06bdd9a7af37064e7ddd51"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4af00969042e7d8ea34b8e06c88869a76ff78ce1","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                       pfx in getattr(api_routers, \u0027_path_prefixes\u0027, [])"},{"line_number":215,"context_line":"                       if pfx in _MOVED_API_PREFIXES]"},{"line_number":216,"context_line":"        if moved_found:"},{"line_number":217,"context_line":"            raise RuntimeError(\u0027An API Router is trying to register path \u0027"},{"line_number":218,"context_line":"                               \u0027prefix(s) `%(pfx)s` that is handled by the \u0027"},{"line_number":219,"context_line":"                               \u0027native Flask app. Keystone cannot \u0027"},{"line_number":220,"context_line":"                               \u0027start.\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2c44ccb7","line":217,"range":{"start_line":217,"start_character":18,"end_line":217,"end_character":30},"updated":"2018-07-16 19:32:29.000000000","message":"This will technically only happen if a developer made an error, right? Should this be a ProgrammingError?","commit_id":"0d6b427fcc7f6b9b2a06bdd9a7af37064e7ddd51"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"73adf0931901a46cb7991972b92a14aab0dfdbf1","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                       pfx in getattr(api_routers, \u0027_path_prefixes\u0027, [])"},{"line_number":215,"context_line":"                       if pfx in _MOVED_API_PREFIXES]"},{"line_number":216,"context_line":"        if moved_found:"},{"line_number":217,"context_line":"            raise RuntimeError(\u0027An API Router is trying to register path \u0027"},{"line_number":218,"context_line":"                               \u0027prefix(s) `%(pfx)s` that is handled by the \u0027"},{"line_number":219,"context_line":"                               \u0027native Flask app. Keystone cannot \u0027"},{"line_number":220,"context_line":"                               \u0027start.\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bd6b28ee","line":217,"range":{"start_line":217,"start_character":18,"end_line":217,"end_character":30},"in_reply_to":"5f7c97a3_2c44ccb7","updated":"2018-07-16 21:54:22.000000000","message":"Correct. This will never pass gate if this error has occurred, the app cannot start.","commit_id":"0d6b427fcc7f6b9b2a06bdd9a7af37064e7ddd51"}]}