)]}'
{"keystone/api/os_oauth1.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bf1124fb41d60519299b366aa14687a9266c1d3d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get(self, consumer_id\u003dNone):"},{"line_number":105,"context_line":"        if consumer_id is None:"},{"line_number":106,"context_line":"            return self._list_consumers()"},{"line_number":107,"context_line":"        return self._get_consumer(consumer_id)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def post(self):"},{"line_number":110,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:create_consumer\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bf13aeb6","line":107,"range":{"start_line":106,"start_character":12,"end_line":107,"end_character":46},"updated":"2018-08-01 21:06:44.000000000","message":"Is it possible to have two separate implementations of get() but one that has a wrapper that specifies the url?","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c48f2b758c2568e84dc1b8a05f32a9693cdbe5c9","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get(self, consumer_id\u003dNone):"},{"line_number":105,"context_line":"        if consumer_id is None:"},{"line_number":106,"context_line":"            return self._list_consumers()"},{"line_number":107,"context_line":"        return self._get_consumer(consumer_id)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def post(self):"},{"line_number":110,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:create_consumer\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9f2a71e3","line":107,"range":{"start_line":106,"start_character":12,"end_line":107,"end_character":46},"in_reply_to":"5f7c97a3_9f36f1b2","updated":"2018-08-01 21:31:10.000000000","message":"Not all, but most. I may consider changing it down the road to an isolated resource or baked into ResourceBase","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f0a8feb15f92e442d4ec095d7eb745479745e97f","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get(self, consumer_id\u003dNone):"},{"line_number":105,"context_line":"        if consumer_id is None:"},{"line_number":106,"context_line":"            return self._list_consumers()"},{"line_number":107,"context_line":"        return self._get_consumer(consumer_id)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def post(self):"},{"line_number":110,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:create_consumer\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dfab09d1","line":107,"range":{"start_line":106,"start_character":12,"end_line":107,"end_character":46},"in_reply_to":"5f7c97a3_bf13aeb6","updated":"2018-08-01 21:11:57.000000000","message":"No, The answer would be to have a separate resource just for listing.","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"81d93768dcb8d963dee1c238d90444b9fbb3dd3b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get(self, consumer_id\u003dNone):"},{"line_number":105,"context_line":"        if consumer_id is None:"},{"line_number":106,"context_line":"            return self._list_consumers()"},{"line_number":107,"context_line":"        return self._get_consumer(consumer_id)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def post(self):"},{"line_number":110,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:create_consumer\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9f36f1b2","line":107,"range":{"start_line":106,"start_character":12,"end_line":107,"end_character":46},"in_reply_to":"5f7c97a3_dfab09d1","updated":"2018-08-01 21:14:40.000000000","message":"Ack - thanks for the clarification. So this if statement will have to be present for all cases like this across our API?","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ac0ad378b6595e2bc196b3c4519226e44486328b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def post(self):"},{"line_number":149,"context_line":"        oauth_headers \u003d oauth1.get_oauth_headers(flask.request.headers)"},{"line_number":150,"context_line":"        consumer_id \u003d oauth_headers.get(\u0027oauth_consumer_key\u0027)"},{"line_number":151,"context_line":"        requested_project_id \u003d flask.headers.get(\u0027Requested-Project-Id\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not consumer_id:"},{"line_number":154,"context_line":"            raise exception.ValidationError("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5f913a44","line":151,"range":{"start_line":151,"start_character":37,"end_line":151,"end_character":44},"updated":"2018-08-01 20:47:22.000000000","message":"This bit is failing for me locally. I think we need http://flask.pocoo.org/docs/1.0/api/#flask.Request.headers\n\n  requested_project_id \u003d flask.request.headers.get()","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f0a8feb15f92e442d4ec095d7eb745479745e97f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def post(self):"},{"line_number":149,"context_line":"        oauth_headers \u003d oauth1.get_oauth_headers(flask.request.headers)"},{"line_number":150,"context_line":"        consumer_id \u003d oauth_headers.get(\u0027oauth_consumer_key\u0027)"},{"line_number":151,"context_line":"        requested_project_id \u003d flask.headers.get(\u0027Requested-Project-Id\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not consumer_id:"},{"line_number":154,"context_line":"            raise exception.ValidationError("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bf5bad20","line":151,"range":{"start_line":151,"start_character":37,"end_line":151,"end_character":44},"in_reply_to":"5f7c97a3_5f913a44","updated":"2018-08-01 21:11:57.000000000","message":"Yep.","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bf1124fb41d60519299b366aa14687a9266c1d3d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            result +\u003d expiry_bit"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        resp \u003d flask.make_response(result, http_client.CREATED)"},{"line_number":287,"context_line":"        resp.headers.update("},{"line_number":288,"context_line":"            {\u0027Content-Type\u0027: \u0027application/x-www-form-urlencoded\u0027})"},{"line_number":289,"context_line":"        return resp"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ff37e5e2","line":287,"range":{"start_line":287,"start_character":21,"end_line":287,"end_character":27},"updated":"2018-08-01 21:06:44.000000000","message":"These are some of the changes I made to get the tests passing locally (not sure how what you have here didn\u0027t work though?) \n\nhttp://paste.openstack.org/show/727090/","commit_id":"a91adc8916372c683db880e136c1d1ab3d5797b4"}]}
