)]}'
{"keystone/notifications.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2331db9dc1998f82f0515eecf5e0993bd050f6e1","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            \"\"\"Will always send a notification.\"\"\""},{"line_number":519,"context_line":"            target \u003d resource.Resource(typeURI\u003dtaxonomy.ACCOUNT_USER)"},{"line_number":520,"context_line":"            initiator \u003d request.audit_initiator"},{"line_number":521,"context_line":"            initiator.id \u003d utils.resource_uuid(user_id)"},{"line_number":522,"context_line":"            try:"},{"line_number":523,"context_line":"                result \u003d f(wrapped_self, request, user_id, *args, **kwargs)"},{"line_number":524,"context_line":"            except (exception.AccountLocked,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_93bb4ae2","line":521,"updated":"2018-08-02 02:15:33.000000000","message":"should add \"initiator.user_id \u003d user_id\" as well to keep the same with the common usage.\n\nhttps://github.com/openstack/keystone/blob/master/keystone/common/request.py#L116","commit_id":"0a593b1a8257dfb38ecd5c2bfba80c8e6b3befed"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"1328b710656b60927cb6d3d38847edcd2d5ecbbc","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            \"\"\"Will always send a notification.\"\"\""},{"line_number":519,"context_line":"            target \u003d resource.Resource(typeURI\u003dtaxonomy.ACCOUNT_USER)"},{"line_number":520,"context_line":"            initiator \u003d request.audit_initiator"},{"line_number":521,"context_line":"            initiator.user_id \u003d user_id"},{"line_number":522,"context_line":"            initiator.id \u003d utils.resource_uuid(user_id)"},{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                result \u003d f(wrapped_self, request, user_id, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0c405932","line":521,"range":{"start_line":521,"start_character":12,"end_line":521,"end_character":39},"updated":"2018-08-03 02:43:16.000000000","message":"None of the examples here[0] show a \"user_id\" in the initiator, wonder if it could be removed instead. Might be redundant since the id is also the user\u0027s id.\n\n[0] https://docs.openstack.org/keystone/latest/advanced-topics/event_notifications.html#auditing-with-cadf","commit_id":"64e4e41cfd657b78fd800962ac52ca2012bcc86c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"21af9b55fc85ea23b16ba1a833bcc081479a7812","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            \"\"\"Will always send a notification.\"\"\""},{"line_number":519,"context_line":"            target \u003d resource.Resource(typeURI\u003dtaxonomy.ACCOUNT_USER)"},{"line_number":520,"context_line":"            initiator \u003d request.audit_initiator"},{"line_number":521,"context_line":"            initiator.user_id \u003d user_id"},{"line_number":522,"context_line":"            initiator.id \u003d utils.resource_uuid(user_id)"},{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                result \u003d f(wrapped_self, request, user_id, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8c32295d","line":521,"range":{"start_line":521,"start_character":12,"end_line":521,"end_character":39},"in_reply_to":"5f7c97a3_0c405932","updated":"2018-08-03 06:10:37.000000000","message":"will there be a case that the initiator\u0027s id should not be user id?\ndo operators trace and use initiator.user_id?\n\nIf both of the answer are No. Then we can deprecate and remove  it","commit_id":"64e4e41cfd657b78fd800962ac52ca2012bcc86c"}],"keystone/tests/unit/common/test_notifications.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2331db9dc1998f82f0515eecf5e0993bd050f6e1","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"        self.assertEqual(len(self._notifications), 1)"},{"line_number":1129,"context_line":"        note \u003d self._notifications.pop()"},{"line_number":1130,"context_line":"        initiator \u003d note[\u0027initiator\u0027]"},{"line_number":1131,"context_line":"        self.assertEqual(self.user_id, initiator.id)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def test_v3_authenticate_user_name_and_domain_id(self):"},{"line_number":1134,"context_line":"        user_id \u003d self.user_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_53b132ff","line":1131,"updated":"2018-08-02 02:15:33.000000000","message":"ditto","commit_id":"0a593b1a8257dfb38ecd5c2bfba80c8e6b3befed"}]}