)]}'
{"keystone/resource/core.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7dd6a43e87edcf305b6ff0c2044a60ffde4792e4","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        except exception.ProjectNotFound:"},{"line_number":476,"context_line":"            if is_domain:"},{"line_number":477,"context_line":"                raise exception.DomainNotFound(domain_id\u003dproject_id)"},{"line_number":478,"context_line":"            raise exception.ProjectNotFound(project_id\u003dproject_id)"},{"line_number":479,"context_line":"        if project.get(\u0027is_domain\u0027):"},{"line_number":480,"context_line":"            self._delete_domain(project, initiator)"},{"line_number":481,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_21043717","line":478,"range":{"start_line":478,"start_character":12,"end_line":478,"end_character":66},"updated":"2018-08-06 14:08:23.000000000","message":"I think you could have\n\n except exception.ProjectNotFound as e:\n\nand then\n\n raise e\n\ninstead of reinitializing the same exception. But I don\u0027t think this exception handling should be moved here, see below comment.","commit_id":"a6a78250c6d2d485219c2cb6c0dc457974efcaf1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7dd6a43e87edcf305b6ff0c2044a60ffde4792e4","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        return domain_from_project"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def delete_domain(self, domain_id, initiator\u003dNone):"},{"line_number":791,"context_line":"        self.delete_project(domain_id, initiator, is_domain\u003dTrue)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def _delete_domain(self, domain, initiator\u003dNone):"},{"line_number":794,"context_line":"        # To help avoid inadvertent deletes, we insist that the domain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3c73fc82","line":791,"updated":"2018-08-06 14:08:23.000000000","message":"This seems a little roundabout. Could we just change _delete_project to accept a project reference but keep the exception catching logic here in this method? I don\u0027t see a reason to go through delete_project, I would rather that method not have its interface changed, and I\u0027d rather not have this jump from delete_domain to delete_project back to _delete_domain.","commit_id":"a6a78250c6d2d485219c2cb6c0dc457974efcaf1"}]}