)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1e0be84158edfce90d15633f4cc915045d015e86","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a translation of log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do not translate log messages. This fixes a translation of a log."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I030d96c1d3a4a348ea206c901fee7d03209ecc1c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_6f95ae32","line":9,"updated":"2018-08-13 06:15:56.000000000","message":"I think there is a document somewhere describing why we shouldn\u0027t translate log messages. I thought Doug referenced it the last time we were talking about this.\n\nIt would be good to include it here for context so others are familiar with the reasoning.","commit_id":"f9b70f1e839bf538fabf42efdee3d23e1adbf623"}],"keystone/server/flask/common.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b5a2dcd2b39ee8dc1f9378712e9889f053202383","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        else:"},{"line_number":904,"context_line":"            msg \u003d \u0027No domain information specified as part of list request\u0027"},{"line_number":905,"context_line":"            tr_msg \u003d _(\u0027No domain information specified as part of list \u0027"},{"line_number":906,"context_line":"                       \u0027request\u0027)"},{"line_number":907,"context_line":"            LOG.warning(msg)"},{"line_number":908,"context_line":"            raise exception.Unauthorized(tr_msg)"},{"line_number":909,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e0530416","line":906,"updated":"2018-08-13 14:24:10.000000000","message":"Is there a reason you didn\u0027t use _(msg) here?","commit_id":"f9b70f1e839bf538fabf42efdee3d23e1adbf623"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e11cd44094c8576b64b7c0cb1731b587c19715e7","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        else:"},{"line_number":904,"context_line":"            msg \u003d \u0027No domain information specified as part of list request\u0027"},{"line_number":905,"context_line":"            tr_msg \u003d _(\u0027No domain information specified as part of list \u0027"},{"line_number":906,"context_line":"                       \u0027request\u0027)"},{"line_number":907,"context_line":"            LOG.warning(msg)"},{"line_number":908,"context_line":"            raise exception.Unauthorized(tr_msg)"},{"line_number":909,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c1b40af5","line":906,"in_reply_to":"3f79a3b5_d45d1116","updated":"2018-09-03 08:48:01.000000000","message":"Okay. For the benefit of anyone else to whom that\u0027s not obvious, this is documented here: https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#using-a-marker-function","commit_id":"f9b70f1e839bf538fabf42efdee3d23e1adbf623"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"959cf4be037d49ba51ed1f9236bedabb10986354","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        else:"},{"line_number":904,"context_line":"            msg \u003d \u0027No domain information specified as part of list request\u0027"},{"line_number":905,"context_line":"            tr_msg \u003d _(\u0027No domain information specified as part of list \u0027"},{"line_number":906,"context_line":"                       \u0027request\u0027)"},{"line_number":907,"context_line":"            LOG.warning(msg)"},{"line_number":908,"context_line":"            raise exception.Unauthorized(tr_msg)"},{"line_number":909,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d45d1116","line":906,"in_reply_to":"3f79a3b5_e0530416","updated":"2018-08-28 20:25:21.000000000","message":"It does not work like that. Passing a variable causes an error. It must be an explicit string.","commit_id":"f9b70f1e839bf538fabf42efdee3d23e1adbf623"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"d87deb98fe0e9dfd755c4b403ca4707a4d6b94c3","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        Any other value is considered to be equivalent to"},{"line_number":769,"context_line":"        True, including the absence of a value (but existence"},{"line_number":770,"context_line":"        as a parameter)."},{"line_number":771,"context_line":"       "},{"line_number":772,"context_line":"        False Examples for param named `p`:"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"           * http://host/url"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3e43066f","line":771,"updated":"2018-08-28 19:33:37.000000000","message":"Seems you left whitespace here. please remove it.","commit_id":"e35af0c1d7e7eceddc7a7b49b4a7999f5e5772a8"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e11cd44094c8576b64b7c0cb1731b587c19715e7","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        Any other value is considered to be equivalent to"},{"line_number":769,"context_line":"        True, including the absence of a value (but existence"},{"line_number":770,"context_line":"        as a parameter)."},{"line_number":771,"context_line":"       "},{"line_number":772,"context_line":"        False Examples for param named `p`:"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"           * http://host/url"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_41c47a40","line":771,"in_reply_to":"3f79a3b5_3e43066f","updated":"2018-09-03 08:48:01.000000000","message":"This wasn\u0027t introduced in this patch, it will have to be fixed earlier in the stack.","commit_id":"e35af0c1d7e7eceddc7a7b49b4a7999f5e5772a8"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"d87deb98fe0e9dfd755c4b403ca4707a4d6b94c3","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            return token_ref.project_domain_id"},{"line_number":911,"context_line":"        else:"},{"line_number":912,"context_line":"            msg \u003d \u0027No domain information specified as part of list request\u0027"},{"line_number":913,"context_line":"            tr_msg \u003d _(\u0027No domain information specified as part of list \u0027"},{"line_number":914,"context_line":"                       \u0027request\u0027)"},{"line_number":915,"context_line":"            LOG.warning(msg)"},{"line_number":916,"context_line":"            raise exception.Unauthorized(tr_msg)"},{"line_number":917,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3e11c65e","line":914,"range":{"start_line":913,"start_character":24,"end_line":914,"end_character":31},"updated":"2018-08-28 19:33:37.000000000","message":"why \u0027msg\u0027 variable not being passed here instead of writing the same string multiple times.","commit_id":"e35af0c1d7e7eceddc7a7b49b4a7999f5e5772a8"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"0364aa03057017713e7ebca5604c4bbd5ca05181","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            return token_ref.project_domain_id"},{"line_number":911,"context_line":"        else:"},{"line_number":912,"context_line":"            msg \u003d \u0027No domain information specified as part of list request\u0027"},{"line_number":913,"context_line":"            tr_msg \u003d _(\u0027No domain information specified as part of list \u0027"},{"line_number":914,"context_line":"                       \u0027request\u0027)"},{"line_number":915,"context_line":"            LOG.warning(msg)"},{"line_number":916,"context_line":"            raise exception.Unauthorized(tr_msg)"},{"line_number":917,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_d444314a","line":914,"range":{"start_line":913,"start_character":24,"end_line":914,"end_character":31},"in_reply_to":"3f79a3b5_3e11c65e","updated":"2018-08-28 20:24:24.000000000","message":"Does not work like that. You cannot pass a variable into a TR function.","commit_id":"e35af0c1d7e7eceddc7a7b49b4a7999f5e5772a8"}]}